From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751644AbdE3J2l (ORCPT ); Tue, 30 May 2017 05:28:41 -0400 Received: from mail-he1eur01on0070.outbound.protection.outlook.com ([104.47.0.70]:10752 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751025AbdE3J2g (ORCPT ); Tue, 30 May 2017 05:28:36 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; Subject: Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC To: Arnd Bergmann References: <20170530092628.1306028-1-arnd@arndb.de> CC: "David S. Miller" , Ido Schimmel , Jiri Pirko , , From: Yotam Gigi Message-ID: Date: Tue, 30 May 2017 12:28:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170530092628.1306028-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [109.65.51.42] X-ClientProxiedBy: HE1PR09CA0070.eurprd09.prod.outlook.com (2603:10a6:7:3d::14) To VI1PR0502MB2973.eurprd05.prod.outlook.com (2603:10a6:800:b1::11) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0502MB2973: X-MS-Office365-Filtering-Correlation-Id: 1544abf3-fe22-4c24-be81-08d4a73e3deb X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:VI1PR0502MB2973; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0502MB2973;3:46x5vIB2yr7VR0HZRcAapxcWHbWmj2NLPlEc2qNrFb3l379Z81QlcKRWL0d7Hj5dImseodlGs2XpgsGfQ7sUdJet//T7SJbpM8KmmREHemSwVkkRO8Dpjv4y3elbAC9qxRBy7OkwbaVZojt4RwfHnRUjEUfHpNqFS6vRfmvqYmjmfwoLB9rCegwJLwUOHMgbjZLCt4LzCcdY4NwAv4peb2UAp5EvWh+2eGRzPYEiqtpUx8eosqb6AXrX5IcapAQF2Jxq2tk6pRfkc86sjJH2rtTzAou56MBiGGqNGhepj/gk0ekIJd6APnLlOH46Cwdt3AIU/aRY0Z1P+jsTzfTR0MCC9AokM89Kqdm8jDAb5ps=;25:h1lVfjyTlMUYAxdlxNTV7hPssdzi1r8N7WtulF/jqjw5FshKhHbF7+Df/QXR44NKwECRByJOV45nFegb2K9f8oDx3MF2vXUDYxsHkvruYzcUO2FyEggKBBSexciqICbwJOnHgTnG1rOz6WkxMRbZehth758ekuuLhjJWsUb/6i9/BwLX36a7fGQNE0vW09L4PF6wXSBhZunPDN5nvxZEvmp7ApWyciR6H1Z3NqBWNvqlT5rt7/QBpMfxgmRUmF9xZUxgobA6rRWF06OpvFFzr3ztItn2NEYPXDs+oXBjb/aoI4ggriMIZ1cYW1qmDJOXoxVP0I//ug2lhoKRSMkgYw6qCB1Xj542hQq1bQUZu3Kk15O7jxvyPp5duw7Z0l/QsEgv5PPvjc5Fb9FBJssPvls/9pNfe/1vBvlzoSLf6lB76PgEPAGPOqqTu7srOzLboB8XDMVtKVroo/0cA/uJ2jA6OL4+ULTFyrpuA966avs= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0502MB2973;31:GOUITYyWM53SOyxLNDyFAEsB5O9nvtca3kLn0ZrlXxfRYM7rmkwyz+xj60YQlfTo8KO/NQo2K+0cd2lKxowk244x1ijJ7K/ZDWK1ZciPp2zzlPzF6uxfDoaNvPoYk088cPgYjpCtQj9oZm4Nj9PM/VCehwvqx3vJvZzJrks5QsmYt/CtlMkVtY8ROZmG1JF6VGyDYUYhP46TcmUm1sm/5PtScoTfuXbW+zZdSpDKQEs=;20:OnDQbS9b14kWGQOE80rwUgaKX+Uxl4+B/eD8lKmMcdEYRWy6CIywb6joJo0YtfDYH89sjHnLdhCAj2g31cBfIGf27s8+sRGjyHY3jStmwcVjVilLA5tE9HVEkEU+PGZwY0fFhsevOKNKBOAtwIvkkA2qimK/Yxn5/lsoLulxmaidK1ZRxkX6HIVqxCCKq6nm2syPImuvuMAC/m5ikqS9pwlloJ5swDTEPdOq3/C0E1Hj7paqBPuCRpsDOs553wuq+aHcV34qS5643/bteX1a7NAWX5LvvaMjep4iwRiq8CpZXDHkZ+Wqrd/hLwB7WPHtFKtN8YLnBM66nPn1mfrQtJVxNa6T8VnQRgQd2/ehhhS9vLbutELKnhy1tcGhMllbBCTZ7zUF5XFvWcASt/5Ry2dlqFsurmlSx60Can4TJkTEae/E7y3CWox4KhZweWbT/dhXvoliJOtb1LxCk2aZ2wV2ZA0P0cSIg1pp1XrHU52fnkDLPbjpPRuFcrwIIq2Z X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(6072148);SRVR:VI1PR0502MB2973;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0502MB2973; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0502MB2973;4:Ej1Mnf/xIYIgQR2VnTrAjYAS2oL+IK2ax4sxmmQMiZz+ny/KRttezvrZUFIO6vYMkacXCiOAwY+ZMIik6PuXhQ3QcEPggZZh25IgRDnChNs4BGaOjQAjDSfPkzR4Z99k8XrfpbvJpS5KlpN5GHFg6CHQ2q8f8YM+bxPg3+J8WXHDkClGSHVjXiRN/ukUKua0RitQuc0/brRZwMMJ+GPmGVBdq6lAuKrsyHHMOfjpH96xMBQFgtm4xDpudhKJGUlNQxnSRh9txnKWR08FC7a5C7krtfPRr5f2gorVv2nnLuSBsbwjV1un1xjenvg5iItlIfovZpgTFBycqRYSNudeRk4j2fICinaxZTF2IPJ5q/k1sQhSLqWBFu2UhnnCNyCfzqWJOaSiDhiFFMVzCdpp0QH9S/1rmg0KdBBhptU2aEdSm6sU6yFzmpKdKUEyLKBGr1hWySVDI44R7ZXqa7PImVapJRnocFcSwvEEtTTogwHdTCDpqVczrPT32s7qCX3kjycosZh8FyWhoyX6U5gCViewKwE4QGb7Cbnv5eU/DvC7l4Fg4ex9Hb/39OJJHXAmnJlG8DNUAsZnjdjpSRl+yHNhENmwM+KR3PI8Q5kgabepECNxo2rfzcwVW7NGXh91NvyjHcLMRwF3hiFarQZ6bSpNLz0SXCjiAYFHTaPvaSDlaYtjYUtrUe5ivAKSPmEhWYJt+3KO7RrYtl1iH0OfNjere6kwiR4c+dvvAxAvYh1ka0p9IgsURrBKwgBPu3BI0Lw9XVjqCmig2U4Th6QEXs7KeBfuQ/h5ATA8JMYCiWJkqdajX/TrEnJn2E8yuBhF X-Forefront-PRVS: 032334F434 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39400400002)(39840400002)(39410400002)(39860400002)(39450400003)(39850400002)(24454002)(377454003)(33646002)(23746002)(478600001)(50466002)(31686004)(4001350100001)(42186005)(36756003)(65826007)(4326008)(189998001)(53546009)(64126003)(83506001)(25786009)(229853002)(47776003)(76176999)(54356999)(50986999)(65956001)(5660300001)(53936002)(66066001)(6916009)(6666003)(81166006)(230700001)(8676002)(86362001)(2950100002)(6506006)(6116002)(305945005)(31696002)(6486002)(2906002)(7736002)(3846002)(6512007)(54906002)(38730400002)(110136004)(6246003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0502MB2973;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0502MB2973;23:Atk3wvXTp+CzeDEi9vkBRyUQB/TjFvVh7Fr?= =?Windows-1252?Q?1QXeneKf9zQ1H1sN1/pqrNtFwZKoR5DjH2dqVjyk2l83+OxdVw3KJdXR?= =?Windows-1252?Q?DYWIxtnPlc95nil61l2UET7qCYBAW8F9y44gocnmdR57mycRIM3ltGqt?= =?Windows-1252?Q?m8uai4siXLvuzwZKDsiHBS1aYZgzEBvD8ljRe2oHcWUrgwGUW9yzfXjX?= =?Windows-1252?Q?4n+UL2iyYmLORgd2qOq8f9BBd+7FgcZitZmXLTIZt858bCmWfuNLi9BZ?= =?Windows-1252?Q?lTDTmLK5i9gb30n06M67t2mAES0Qt/zYHZuZTbdoaKVhkn8uOlhyDviS?= =?Windows-1252?Q?l1iJ/T6AlFrxhmCIA2x74S88X9UAIxqGXoxaQTLKLA7Js3zkmeTHUxwL?= =?Windows-1252?Q?9afEnY+NIUrPl6iflUeD/Jo/6E5Sxh9jhE1cpJcJIKpDnNL7Me9Kj3zp?= =?Windows-1252?Q?UBMGijU3xkLh+If5uYKy01LKvrZC855qbg6YPID9Lrqljo6QhjByqtgJ?= =?Windows-1252?Q?m4AvEekjosFB5K9x6j2holUdWMomZ7KbzW8D4CL4EzYi3Vl9R2MYtMwO?= =?Windows-1252?Q?JdX9kZTCQQ/ml8TFxN940I4AG8kHZMeOt4shyc5K5aFvgA+5OhZdRhxq?= =?Windows-1252?Q?miGHSM8Hk+dpZWWdKXHze9NYywGwX5jfY6oBA+Akvjr1t4SB7XiZG+eh?= =?Windows-1252?Q?9eUXRb4if/DZimkevon7NxmI6HAoOr0NRwTvLzG0J5CUpIqxGg/BSDjK?= =?Windows-1252?Q?6urFupebZtfNLHLqn+FrhISXiV40hBkQ0J5Vk0M1WRT7E5uk9O9Cl4ZW?= =?Windows-1252?Q?nAedP9Atyr2Dm587q274WfCg4+/Cw4Wdl/gtnopzAy82BhNuXfqxsSXm?= =?Windows-1252?Q?ljh3r3AAlPwabFx96f7JDDhuPtawoOpxnwXcTCC3tlCPdvglwShiZbfA?= =?Windows-1252?Q?dFQu8rtXm4p1gr3h+HgPCfRX1SBKKi9pH+tuiloJ+YpibCfai7glYRbs?= =?Windows-1252?Q?zM8jKy4UZRUy1XDoTbR2DQTq4BoJxo/M/dtzWeDaSTLqz2SeANItvRv7?= =?Windows-1252?Q?bp2E5TnXbtTqlJPsfu1tKZ7J0/P2FFB45thfJZ7jw5+Hbf3xjUVNya3N?= =?Windows-1252?Q?lhxURrEhXb6q/NH0+yrEXON+QQcJb2bka9i0B1Tzh33JumLV4y5RAxua?= =?Windows-1252?Q?6iD5ktL5X4yMOjyJbuKCgJi2CoAPPcLFZMgUr/28KRPJolwD2G1Q765s?= =?Windows-1252?Q?r/FVo/EAqvtq9xjigXIhSflfMr3SFA7ul7dkb2FuNzyzHxPTuB3TJM47?= =?Windows-1252?Q?vcSYUyj8A1ZcTYqriXLTVEDWZe1PLILNA2lkSl3XKgCtC3d/GK/hw/ch?= =?Windows-1252?Q?68RZlKqE6HnAGTmpphV/hGX/eC7yfbCUeMqW1n2+SNErq/weDa6ZfU+t?= =?Windows-1252?Q?qw9iG6gZTs1/jSxpYmvMF?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0502MB2973;6:fQwwpykgRxs1CAGqQ3G9ijoF713RC+0XFjbpibvkKy0nrVYmtSqRUN14rZXfcgfAOWZGY7fQnpNFRFhBjJHsjSXXn66KtS3b0pcdiSLUEBsLmYLdPwu5MLAdpcRjUj3XZX/HL2Ti5VYhE1jc/3Xoewf/T94wC/QZ2K6BmFlJ+XxpSu049ptqgKw2YTcoz87fQ9vB/97RGO6Adrnr9qg4V20JDdalweqiZqweAnSvTLHtx+9jz5/0rvY3YzMogmB0tTI4Zi1/74AyEg/JDPZjLwYK13jdKZaVWy56yOfl0RzNirorSdTaMRrKh2FpXdFsRzo5oe+qN3a9oVUOPDt+8EBHr0j+/0u7srWaEG+uZ8PeKC5ZYjMzRyhYfV3Za92j2s0wRhIR8SUZVo3FblReYq7ZMnkl4BHN0rfSwvaMaFiMWdlRNfal/x4YKSUGMktHUPyAt0T6rOYjp9DUbOKCW/ynx8OviMm31c3gM15h9nOWJlwO01F27GyRStiqmc5FaqE+3ATkwsgE/NM9/U0nAQvSm1O6TwXAR0etOx9ZcLg=;5:wqSCo58zI0U8x+wwDpr6hH1YDiLPCABG14+fmXJ6wxRV4LbkjD8swdemQu5g2867aaaSPsmnN/ne7suU9l8Qf6iOPdY89qkTHPaIl/PjfNGegAxr7S3yerd7Eee5wHlF+twsl5sx/AR7Czm+jysgtq/LyIAHHyGQm+m3qrQ7/h4=;24:scYoLocwCCGevCn8bkrAfm2e857r5wQHw1gHuiIOp/FEaORquJyuiTq+t88JU/VLmIWEcLKA17X4j2p8uqKqsUj7Ys8kXhp82yZ+ncdAz1o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0502MB2973;7:LN7VDIZhuKiD7VvONZN0c8sVtIsfzRODp9cVvSOQPLNuPLgobkKo/+fdmzFakaDUNBfQNMV5KtTTQxRVk90iyNcYYhWhQoKyiZkhZQeWGkhuuNCGKec4jHFHE41cRgc3Ca8LeXV5r4NHLOZW2mLGx5wmA4GdY7GAAcSnF171iTk9ciUT4ATeLVh2CXsrt8iSsANqgAAUGcbDSzPhi7snN5uJbwt6S+oIPp9WhCBvsK6obBKi+bn4LYy5dxkZLen8XG7lIXljOTjOwBDFAI59CFeIFWxLHiBJn+yLxP4rF7si3JUAV1LtnDEmjY/JYlcZi5hOa23nh8/L8Se/KWwicQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2017 09:28:31.9128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2973 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2017 12:26 PM, Arnd Bergmann wrote: > The new mlxfw code fails to build without the xz library: > > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_xz_dec_run': > :(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to `xz_dec_run' > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_file_component_get': > :(.text.mlxfw_mfa2_file_component_get+0x218): undefined reference to `xz_dec_init' > :(.text.mlxfw_mfa2_file_component_get+0x2c0): undefined reference to `xz_dec_end' > > This adds a Kconfig 'select' statement for it, which is also what > the other user of that library has. > > Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ethernet/mellanox/mlxfw/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlxfw/Kconfig b/drivers/net/ethernet/mellanox/mlxfw/Kconfig > index 56b60ac7bc34..2b21af8a2b1d 100644 > --- a/drivers/net/ethernet/mellanox/mlxfw/Kconfig > +++ b/drivers/net/ethernet/mellanox/mlxfw/Kconfig > @@ -4,3 +4,4 @@ > > config MLXFW > tristate "mlxfw" if COMPILE_TEST > + select XZ_DEC Thanks! Acked-by: Yotam Gigi