mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Axel Haslam <ahaslam@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	David Lechner <david@lechnology.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	"J, KEERTHY" <j-keerthy@ti.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip
Date: Tue, 8 Nov 2016 20:16:07 +0530	[thread overview]
Message-ID: <e17837bb-5856-63f8-5c32-3108651fbb65@ti.com> (raw)
In-Reply-To: <CACRpkdbVUwOtR9k7hXp+xdfro4QvTE5HWTdvXvD6FYBQi-pyYQ@mail.gmail.com>

On Tuesday 08 November 2016 07:01 PM, Linus Walleij wrote:
> On Thu, Nov 3, 2016 at 12:34 PM, Axel Haslam <ahaslam@baylibre.com> wrote:
> 
>> The gpiod framework uses the chip label to match a specific chip.
>> The davinci gpio driver, creates several chips using always the same
>> label, which is not compatible with gpiod.
>>
>> To allow platform data to declare gpio lookup tables, and for drivers
>> to use the gpiod framework, allocate unique label per registered chip.
>>
>> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> 
> Sekhar/Kevin: can either of you review this patch?

The patch looks good to me.

Reviewed-by: Sekhar Nori <nsekhar@ti.com>

I am traveling and did not really test the patch.

Thanks,
Sekhar

  reply	other threads:[~2016-11-08 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 11:34 Axel Haslam
2016-11-08 13:31 ` Linus Walleij
2016-11-08 14:46   ` Sekhar Nori [this message]
2016-11-08 18:16 ` Kevin Hilman
2016-11-09  8:14 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e17837bb-5856-63f8-5c32-3108651fbb65@ti.com \
    --to=nsekhar@ti.com \
    --cc=ahaslam@baylibre.com \
    --cc=david@lechnology.com \
    --cc=gnurou@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®