From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA783C4332F for ; Tue, 31 Oct 2023 13:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344481AbjJaNRG (ORCPT ); Tue, 31 Oct 2023 09:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344461AbjJaNRE (ORCPT ); Tue, 31 Oct 2023 09:17:04 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57FFDDE; Tue, 31 Oct 2023 06:17:02 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D7B1366073A3; Tue, 31 Oct 2023 13:16:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698758220; bh=UKig+LuihbJ88pZrqsdMkSm6GIDrEJck0xJqKEx+xT8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=heU/JmH5bzkBexwGGbhEbA2kshYTP/yFEexLfR0na3soREvJWMZbMgw79+2gwCwMt F+tEJDK14a+T+Vq2da+/j19xmN7Hjr4QzsCduGwPan6KMhAl2odY0UqnkXZjs+3/Uy iyZd8pINFEQ3IobDyIbhsRB3m66+AOxnXblcTQvgC4BVw5oU9cw5EYouoG/8rPFtUC HH+QNAl7XMxJr5VoMj9rBdKE6v35OZagcosKuzqFRaeC5WjXvrcaJH+KldiY5HU61h dBY/PKGKYmz0oyJUnvDs5fnbsHPKQDKEqqYfvjeXVTXmt5htOtYacdOgJWEWQfSBky wvflJV5wkGfuw== Message-ID: Date: Tue, 31 Oct 2023 14:16:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] MT8195 Cherry: Assign MFG vregs for power saving Content-Language: en-US To: Chen-Yu Tsai Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20231030132523.86123-1-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 31/10/23 10:19, Chen-Yu Tsai ha scritto: > On Mon, Oct 30, 2023 at 9:25 PM AngeloGioacchino Del Regno > wrote: >> >> This series assigns the right regulators to MFG0 and MFG1, respectively >> VGPU (GPU Core) and VSRAM_OTHERS (GPU SRAM), and removes the property >> regulator-always-on from both. >> >> This allows to save power both during runtime suspend and during system >> sleep; specifically because: >> 1. The GPU SRAM regulator is switched off during runtime suspend >> 2. The GPU Core regulator is switched off during system sleep >> >> Of course, in order for those power saving actions to actually take >> place, it is required to also have the code in [1]. >> Anyway, even without series [1], this will not introduce any unstability >> as the Vgpu regulator will simply not ever get turned off. >> >> [1]: https://lore.kernel.org/r/20231030132257.85379-1-angelogioacchino.delregno@collabora.com >> >> AngeloGioacchino Del Regno (2): >> arm64: dts: mediatek: mt8195-cherry: Add MFG0 domain supply >> arm64: dts: mediatek: mt8195-cherry: Assign sram supply to MFG1 pd > > Tested-by: Chen-Yu Tsai > > on Tomato without the power saving patches. Regulators are correctly > requested and I can see the SRAM regulator get turned on and off with > GPU usage. Yes, I confirm that the sram vreg going on/off is expected even without the power saving patches (as the power domain refcount decreases during runtime suspend). Thanks! Angelo