From: David Woodhouse <dwmw2@infradead.org>
To: Paolo Abeni <pabeni@redhat.com>,
"Chalios, Babis" <bchalios@amazon.es>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Graf (AWS), Alexander" <graf@amazon.de>,
"mzxreary@0pointer.de" <mzxreary@0pointer.de>,
"Cali, Marco" <xmarcalx@amazon.co.uk>
Subject: Re: [PATCH v4 0/7] ptp: vmclock: Add VM generation counter and ACPI notification
Date: Mon, 05 Jan 2026 15:13:06 +0100 [thread overview]
Message-ID: <e187364fe40bcc4d20f22b87cb6285ee1ed78643.camel@infradead.org> (raw)
In-Reply-To: <5fe241dd-ae17-4cfe-80f7-e7ea80f8b781@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Sun, 2025-12-28 at 15:42 +0100, Paolo Abeni wrote:
>
> There are a few formal things to adjust (reverse christmas tree order in
> variable declaration, empty changelog in patch 6/7, prefer #if
> IS_ENABLED() over #ifdef).
The changelog of patch 6 is not empty. It clearly states that it
removes the dependency on CONFIG_ACPI, and that's all it needs to say.
We could pointlessly repeat the first line of the changelog and say the
same thing twice, if that helps?
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
prev parent reply other threads:[~2026-01-05 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:24 Chalios, Babis
2025-12-18 14:24 ` [PATCH v4 1/7] ptp: vmclock: add vm generation counter Chalios, Babis
2025-12-18 14:24 ` [PATCH v4 2/7] ptp: vmclock: support device notifications Chalios, Babis
2025-12-18 14:24 ` [PATCH v4 3/7] dt-bindings: ptp: Add amazon,vmclock Chalios, Babis
2025-12-18 14:24 ` [PATCH v4 4/7] ptp: ptp_vmclock: Add device tree support Chalios, Babis
2025-12-18 14:25 ` [PATCH v4 5/7] ptp: ptp_vmclock: add 'VMCLOCK' to ACPI device match Chalios, Babis
2025-12-18 14:25 ` [PATCH v4 6/7] ptp: ptp_vmclock: remove dependency on CONFIG_ACPI Chalios, Babis
2025-12-18 14:25 ` [PATCH v4 7/7] ptp: ptp_vmclock: return TAI not UTC Chalios, Babis
2025-12-28 14:42 ` [PATCH v4 0/7] ptp: vmclock: Add VM generation counter and ACPI notification Paolo Abeni
2026-01-05 14:13 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e187364fe40bcc4d20f22b87cb6285ee1ed78643.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=andrew+netdev@lunn.ch \
--cc=bchalios@amazon.es \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=graf@amazon.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®