From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbdA3Xg6 (ORCPT ); Mon, 30 Jan 2017 18:36:58 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:36794 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbdA3Xgz (ORCPT ); Mon, 30 Jan 2017 18:36:55 -0500 Subject: Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver To: Gwendal Grignou , bleung@chromium.org References: <20170128003007.GA4191@google.com> <20170130193020.29623-1-gwendal@chromium.org> Cc: linux-kernel@vger.kernel.org From: Benson Leung Organization: Google Message-ID: Date: Mon, 30 Jan 2017 15:36:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170130193020.29623-1-gwendal@chromium.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2R8ikC9hiEkqGIC3WF9G85Q4wAOwWGR1R" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2R8ikC9hiEkqGIC3WF9G85Q4wAOwWGR1R Content-Type: multipart/mixed; boundary="GQDmRpNIx0t6Gv0mQe0aeK5IItCQhDMN4"; protected-headers="v1" From: Benson Leung To: Gwendal Grignou , bleung@chromium.org Cc: linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver References: <20170128003007.GA4191@google.com> <20170130193020.29623-1-gwendal@chromium.org> In-Reply-To: <20170130193020.29623-1-gwendal@chromium.org> --GQDmRpNIx0t6Gv0mQe0aeK5IItCQhDMN4 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Gwendal, Overall, this looks good to me, but please make sure this is based on upstream, and not the ChromeOS kernel trees. On 01/30/2017 11:30 AM, Gwendal Grignou wrote: > Add a kernel driver for GOOG0006, an ACPI driver reporting an event whe= n > the tablet switch status changes. >=20 > On an ACPI based convertible chromebook check evtest display tablet mod= e > switch changes: > Available devices: > .. > /dev/input/event3: Tablet Mode Switch > .. > Testing ... (interrupt to exit) > Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),= > value 1 > Event: time 1484879712.604360, -------------- SYN_REPORT ------------ > Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),= > value 0 > Event: time 1484879715.132228, -------------- SYN_REPORT ------------ > ... > Check state is updated at resume time when different from suspend time.= >=20 > Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2 Strip off the gerrit Change-Id: as it is meaningless upstream. Thanks! Benson --=20 Benson Leung Senior Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --GQDmRpNIx0t6Gv0mQe0aeK5IItCQhDMN4-- --2R8ikC9hiEkqGIC3WF9G85Q4wAOwWGR1R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJYj83mAAoJEB8J9XsKL+ZYOxgQAJKb5uX0yys/uKRgWkRzqOKo rnQJZK+r6TM8fDcMZjwlincrK9F0iqMtCuUM1IaVmCb2qaoIXn6B/AtDQ3LY4s8y /qYQ4LnI2AgaDJAp7Juhigc9HbaMM5lB3SsNRxETprYtOneU0yUXVImJ/AQ4d/D5 5ypXA/aDEKzhfgrxecacVtH4Z7NgXRxM6uV6RfnQ3fPMVClXR0P9LQWfbKf+TGRt khafgETn5P6/0Y+UcI83FYDLgLXhxEV/Tu92b9c56OzzR9PCNav6Qylxtcwyzyl+ +znH/knTf1p1Co3acCL6wYhRnM4CzHduH8sDTIPNI8787V2iBbDtdz9xdZkJ3gAu 6TY1ZVSLZx0ryKr/9RN7frwqzGljCSDXEBXDE9egVRf17h3tlc457Cd0rmIZi2hT F327BRrPYKv7U0ZI5XnFiDjk+0hBBGcvGLZ/JGxHyqQSjLEnIhcwu6jQDJRJM7LS y+6pbNhkg4mzHQKctT1LHq79LE/A5DguK5hfGUzC6HVaFk/7NJRBVJ9HXw0jOl3L nspNKFGySUihzQ8/HceqHBXytBZwkPPHcflH4ZayVEZzymJVFCEWZViWE7c1rEii tOSYpiLKWXsGGmsW77ohnDRuL5dmmRu5NYJBCidEaW0jDgVJy1TCBkZCJE2jEDuJ pcf5KW2LM0G6kc6q0Nns =5NVY -----END PGP SIGNATURE----- --2R8ikC9hiEkqGIC3WF9G85Q4wAOwWGR1R--