From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A743340298 for ; Sat, 25 Jul 2026 02:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784948318; cv=none; b=I6oGVTn+awsqzqHeHdEL2X542+KxeplPNY/w6dzRrcND3bYUtT8Qj9IXBkEsRatADFXEyR7bIx1WKaXdq5Jzyl/iypjxoSr7RmwV8JdCDDJnP3nOIPEnmEvuYq6HzHSLrMgmRV49jqGl9cNJLua/1QuFkWQkV2SKoAm6O8DW//M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784948318; c=relaxed/simple; bh=wCfhbLyWom6anCeu4al33aDrM55RZRPstVDfFxgADUM=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mOlUh35yZjaQwE/hQt0noxTGrNN5n7WYL59fptgtpBn/vBf6kNGaXS99mombD7ffR8NyId3zRtukNUezQQury5PEk/hOG84Ue9G7JIqAWf5ALzr9TP2Dyli9zBYyPdeF1AjeGAQpoUpDqR63bwIFUqzjkVyxhTxspHWJvaJWiA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1wnSas-000000002zF-3TCe; Sat, 25 Jul 2026 02:58:30 +0000 Date: Sat, 25 Jul 2026 03:58:27 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Allen Chen , Hermes Wu , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai Subject: [PATCH v6 03/13] drm/bridge: it6505: unregister DP AUX adapter on bridge detach Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: The DP AUX adapter is registered in .attach() but only unregistered in i2c remove(). Unbinding and rebinding the DRM device while the i2c driver stays bound registers the adapter a second time, which fails. Unregister it in .detach() instead, and also on the .attach() error path, which so far leaked the registration. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Signed-off-by: Daniel Golle --- v6: no changes. v5: new patch drivers/gpu/drm/bridge/ite-it6505.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 7c61b02cc7e6..c10cc6a786b5 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -3093,6 +3093,7 @@ static int it6505_bridge_attach(struct drm_bridge *bridge, ret = it6505_use_notifier_module(it6505); if (ret < 0) { dev_err(dev, "use notifier module failed"); + drm_dp_aux_unregister(&it6505->aux); return ret; } } @@ -3106,6 +3107,7 @@ static void it6505_bridge_detach(struct drm_bridge *bridge) flush_work(&it6505->link_works); it6505_remove_notifier_module(it6505); + drm_dp_aux_unregister(&it6505->aux); } static enum drm_mode_status @@ -3654,7 +3656,6 @@ static void it6505_i2c_remove(struct i2c_client *client) struct it6505 *it6505 = i2c_get_clientdata(client); drm_bridge_remove(&it6505->bridge); - drm_dp_aux_unregister(&it6505->aux); it6505_debugfs_remove(it6505); it6505_remove_notifier_module(it6505); disable_irq(it6505->irq); -- 2.55.0