From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D40C43461 for ; Thu, 17 Sep 2020 01:57:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C79ED20684 for ; Thu, 17 Sep 2020 01:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726064AbgIQB5U convert rfc822-to-8bit (ORCPT ); Wed, 16 Sep 2020 21:57:20 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:3518 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725886AbgIQB5T (ORCPT ); Wed, 16 Sep 2020 21:57:19 -0400 X-Greylist: delayed 937 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Sep 2020 21:57:18 EDT Received: from dggeme751-chm.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 685C42EE129367064534; Thu, 17 Sep 2020 09:41:38 +0800 (CST) Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme751-chm.china.huawei.com (10.3.19.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 17 Sep 2020 09:41:38 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Thu, 17 Sep 2020 09:41:37 +0800 From: linmiaohe To: Michal Hocko CC: "hannes@cmpxchg.org" , "vdavydov.dev@gmail.com" , "akpm@linux-foundation.org" , "cgroups@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm: memcontrol: correct the comment of mem_cgroup_unmark_under_oom() Thread-Topic: [PATCH] mm: memcontrol: correct the comment of mem_cgroup_unmark_under_oom() Thread-Index: AdaMk2onBuSUvuaupEiH3Zos6miJVQ== Date: Thu, 17 Sep 2020 01:41:37 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.109] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Hocko wrote: > On Wed 16-09-20 09:19:27, Miaohe Lin wrote: >> Since commit fb2a6fc56be6 ("mm: memcg: rework and document OOM waiting >> and wakeup"), we have renamed mem_cgroup_oom_lock to >> mem_cgroup_oom_trylock. So replace mem_cgroup_oom_lock with mem_cgroup_oom_trylock in comment. > >While you are right I find the comment more confusing then helpful. >What does it try to tell us actually? Is it still valid? Shouldn't we rather remove it or make it more clear? >> It seems this comment no long make sense. Many thanks for your nice advise.