From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757276AbdEOSMc (ORCPT ); Mon, 15 May 2017 14:12:32 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30589 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbdEOSMa (ORCPT ); Mon, 15 May 2017 14:12:30 -0400 Subject: Re: [v3 0/9] parallelized "struct page" zeroing To: Michal Hocko Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net References: <1494003796-748672-1-git-send-email-pasha.tatashin@oracle.com> <20170509181234.GA4397@dhcp22.suse.cz> From: Pasha Tatashin Message-ID: Date: Mon, 15 May 2017 14:12:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170509181234.GA4397@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, After looking at your suggested memblock_virt_alloc_core() change again, I decided to keep what I have. I do not want to inline memblock_virt_alloc_internal(), because it is not a performance critical path, and by inlining it we will unnecessarily increase the text size on all platforms. Also, because it will be very hard to make sure that no platform regresses by making memset() default in _memblock_virt_alloc_core() (as I already showed last week at least sun4v SPARC64 will require special changes in order for this to work), I decided to make it available only for "deferred struct page init" case. As, what is already in the patch. I am working on testing to make sure we do not need to double zero in the two cases that you found: sparsemem, and mem hotplug. Please let me know if you have any more comments, or if I can send new patches out when they are ready. Thank you, Pasha