From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbdBWSVT (ORCPT ); Thu, 23 Feb 2017 13:21:19 -0500 Received: from mail-by2nam01on0069.outbound.protection.outlook.com ([104.47.34.69]:52984 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750828AbdBWSVR (ORCPT ); Thu, 23 Feb 2017 13:21:17 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v8 9/9] perf/amd/iommu: Enable support for multiple IOMMUs To: Peter Zijlstra References: <1484551416-5440-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1484551416-5440-10-git-send-email-Suravee.Suthikulpanit@amd.com> <20170125094653.GO6515@twins.programming.kicks-ass.net> <20170214123149.GV6515@twins.programming.kicks-ass.net> <20170223181116.GJ6515@twins.programming.kicks-ass.net> CC: , , , , From: Suravee Suthikulpanit Message-ID: Date: Fri, 24 Feb 2017 01:20:58 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170223181116.GJ6515@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [110.169.70.255] X-ClientProxiedBy: SG2PR01CA0045.apcprd01.prod.exchangelabs.com (10.165.10.13) To CY4PR12MB1447.namprd12.prod.outlook.com (10.172.71.139) X-MS-Office365-Filtering-Correlation-Id: ef31583e-93c6-42f9-cdca-08d45c18c139 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:CY4PR12MB1447; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;3:LKGfJqXuVzdgBObq/q1OPzgeNpZnjrGAcCn+aGIfH2Nimd26Hj2qTw1wVYQFzbbLjbHNEdxvS14qrZc0Sq2vBYiLD7VGycoLCvA+u8KMpzBEOfAxUzQcq1tuuLMHFG+ihbK1dQXdoDB+C9Brx7VrpLIukNX+45aiefMhvgU8EUyHyFjCmJyz6WBfqhCkok2+IeNo/MMewRuLwIv7YBl1it01zBvIYLYGCl0u7sPPNOooEHly71iaaGFwA36fO13bD5S0dwJlKyEtEZHXOCC+qHCz+WAmTFisDABNA+VcnYs=;25:YiJL52jTSyLDjRRmSL2hrUwvdFXSKQx/1ygJz1e7guN4+51rv5FJJEBm/9fnIT2yrfpDcNskXaMeMKnd4GF2zkkqPF39M2/0EqBC34oCrREB8iC9WOi/IE/EtyOQfpPnQAdQPZVgHvRI7DGrIZ6XFguB0h796bIZMT+adXEQnrb+P3ETWhbuSy6/vA1bO0u2haIpB5HWN7j0fvasxR8EPBPQCIwwrShdrGM5SnxjEvyJ1P898bsw7wL1QM3hFcSQ/3XOGIldpiokK8DzkMr21vsxy6hQ029k/vpOdqMr8Q3SVwU7M9oR205P76ul2z3XB3p0kYzPwlQ/4pDPbsMZv78nX/F6Q3upD1VDfYYDQspmWMHgZwxhIO3AW1SPICbUJQDC6Az9zAW4E5bEqzWxpIGmeXu7APbev0Nsahp2gB7/YAnlbIRc84/PqgxeGxtB4gbJi25TtA85LC7wD940pQ== X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;31:a9lu/A2zmMQk/rHikKK1PJcHe+OLF7sHR9AZyTP17EcyA/MGD9CvWMM8mN0c0zCRzL0rdOPeNREkxbZL+ri5ZkNKg8dUbn3m5xV9bX6Rb/7wIkggIv15ZoYjsgbQ7A2JjlZmTdSFlUM5GpetelaJAzn/ImXfJCWxxFTnxT0OxKk/sp4kNreY708GtxOO2KcOIJQ7PNo/aa1/UGuZaFXPT0opp/aP5G5zPCeC1aLE/rtBf/VJ1W6JKWQbtb6ROkT6;20:IiCinul92hlpweoJbkzFfPBI7ojWmKqt/QmmeqyHtXpcU+O/EM3h9fRpTEuIR/SkU1s8iwhFtuPbRl6nDIY3a59wwY+yXW0Jb6aXC5HzyKEo2102Y06gEhld1jZGrj5gNqB0+FakZwJFiNT5j1Nj6hPt4lqx6dYfirjItMbZtrtDZrGthysH9xGAMT/uHQ/Uw9tYi3rBgH/Ftyy79aUR6G2Q5qzyIVCJ15C2ZsLlDwq3J64FqKgEaXb0OHpCpqFbNn0z2jzteacHCQT3XSn+tSA0n0pTpT9ZoigJqoBFligK2PD2CowwfwMRfOY3kTN29TFDqPaInXWV2M1mrw/nnmkPFOyppl7Om5QYnRCmGoj/W6PumkoZYtUZ9l0hlnon/0Vlj4zbuSqKJBWy8q0oDNq2MjbmaDBtiq82QTThgRLDYeU/rA55FwF34dX7QTlLf5QDuqgOIOLw0sjqNs4oj+FxsjcyMMmkz2gNDt1nNw9XDIrDeSD64SfuLWtV0hJu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558025)(20161123562025)(20161123564025)(6072148);SRVR:CY4PR12MB1447;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1447; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;4:3Ll2nKbw8z6/9ixMMh3dhXoh5BX3rdXY8eaV8x0jIs1Zoj61aoyFE/5FqvrmkijF+l4NM9pTCLV6S9TXKn8fJ1FtCmZCbvD5aC785/PsRKKp5m8sS4IWq+TCzSNx7dY4llx0KzBEFm6R/zFQVBSpSCDMraFZ2gSzx3IPZs0WayembjEDhjg5JB9PiOLm1AirvLpH5CxJqsIFRcNMXwFXu2SQsG4M57gPxnFuiQ0yWJCHoxFBNc/cC3WZk86y3we/upES7CWNd8GVZZ5in5zuZn1ZhGPXIsQGmMKMW7LgxVy+t6TCsE6WhCpSpHf4+60/212r6HNlMWqJVG2wkHOm2vRC6WyHKBgyvbwu9eqN5l4PFwYqs4nlnJ2HDUxnlcBLhOVtEbWgq8GWywukmV6xg7b5CniHEjHyMldbrmm2JRBjaEO0GxrNlYxKp1H0ayjj+tleWxKEmbmtBJIHGdroVtH/T6JVb7no7aUzxE4p+qsWzaND69RP+MaKYda8sqc3SbtSYWOTY8uNr2+k7GQUnTDyeGic8CXhLUlStAfIRiblfzndFFAfvprlUffcA2K4Bq+GeQTHvJV5UufICQQAvbOEigg7/oMP/kemY05vPUmrm6OgYla78a0N+hmZmqpV X-Forefront-PRVS: 02272225C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39860400002)(39850400002)(39410400002)(39450400003)(39840400002)(189002)(199003)(24454002)(76104003)(3846002)(65806001)(4326007)(47776003)(105586002)(86362001)(54356999)(229853002)(6116002)(101416001)(305945005)(50986999)(36756003)(6506006)(38730400002)(53546006)(106356001)(6246003)(110136004)(76176999)(53936002)(7736002)(23746002)(66066001)(68736007)(65956001)(230700001)(93886004)(31696002)(6486002)(25786008)(33646002)(8676002)(31686004)(54906002)(6916009)(189998001)(92566002)(2906002)(2950100002)(50466002)(6666003)(83506001)(81156014)(64126003)(65826007)(5660300001)(81166006)(6512007)(97736004)(4001350100001)(42186005)(7756004);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1447;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1447;23:h5oIfaie8O27ip+7coGR8PeBh/YeUgzWZVsze?= =?Windows-1252?Q?9mUnooqmKt8J3WgvqCSmES8G8/S5PsyDn3OJ42Y1qxdG6nFGCpkktFQr?= =?Windows-1252?Q?KUTF8nBt6fUl7MKadMFi+Tv3IB+Dq4dlPd/g3iflnf7kLOCG4zIQ0knE?= =?Windows-1252?Q?DMhvkUe6cW7DWE0Mb88Cf5nxdw7H/5vEAI2YDrRHZGkAhQpSF6uhlxzk?= =?Windows-1252?Q?pFt2BE1h8U/ayqaUCb9tyUsOzD10XcyFRG0e1tgoOuNElO0jnSyRn+ui?= =?Windows-1252?Q?LENjR14NWimyo4HuSJpkFz4HZg42ZZ92Gx2TZYL9s3iSGPFfG+qqRbQ3?= =?Windows-1252?Q?Ox8Yb6AxREAu5aam1TzEFW8KEZh2O/ljEhl3x/XeA1ezWNWTLTglKF+6?= =?Windows-1252?Q?wAcO1IOLJqheJHQ5F2vZ5JHwSwnwnlh7+WEqi+PEd/t4WOyefVLoGNAq?= =?Windows-1252?Q?hs+CIom85v7bopUM2HVMp1nltRVYot22xPFcQCt9IRwQaWCurTQXERMb?= =?Windows-1252?Q?pr2QYoHecWAszazln0C2/LFCfHh2IWtQrQnTI++GE4zz0skdH9vLr/GW?= =?Windows-1252?Q?mjNfx1JM7jSY6qgr/Ggbpr9/5A/iIz5/wXn6YOKxtXdfbLodZC82rSDX?= =?Windows-1252?Q?igJm1SVwnVfDvAcqoG9G56kqw9wYAF+Ot5IMliEiOSysPKr4al5JAq+W?= =?Windows-1252?Q?ngECPN8vEPV2d2lYl1JWFxGX+hpC21PPIOV8d6xljJ/hBdBEMTToLDv2?= =?Windows-1252?Q?WZY+llwiXZpXlsNZ6Rh0yyfkhRd7lVaq9D32hyIJJVuFcNqoAEiS7pmn?= =?Windows-1252?Q?OgUh/YHsTjvaUNS/mVwpXAx/rCVWu08TAzDhrLmqJzn2ZuRm4rWzc6PN?= =?Windows-1252?Q?Tnr3PquGLYI6N88NWRbZzik0i9RU2qHiVeDIXAY8RLKPC264J6laJqw7?= =?Windows-1252?Q?7LJoap48KrYKYt/A75Hm0MqpAdwaxOF6Gg9XgrIM5Dr/ZT1CMXvf60GO?= =?Windows-1252?Q?/J/O9BbwtQwyl+CIjRl+7/XVnsI8YuQfbnu1iOTluBZDIz/Y7ZvEYhJ9?= =?Windows-1252?Q?N9dCy61tpfurpPTHotf1pj0w7q28BlrO4A9Vjc2r+PCU7Ka/e5pjRlue?= =?Windows-1252?Q?walvuiza3wJHzG0nRa7K12AtKpJF+J6H9mN1gjiW9fu1zvrgPyR6Lsvv?= =?Windows-1252?Q?BnlFzpeJ+vlQ2vg4+rllUw4yfjAa2i8GNxlj3zSMJEG6z3gV5v0tjemE?= =?Windows-1252?Q?BwxOmFum2vgFIYymK7+3MwGpb4LZSiqrL47G+Tz0ICzc7B6P2GL755P2?= =?Windows-1252?Q?9T0lXvnXq+bNAOe/2qFTsgnEhXY10g2JhswqLdmIjgM1GrUGhlqJhqnn?= =?Windows-1252?Q?vNWho+iaBKFHKpLU0IoCtDb8ZLujK/p03ESaFSclCYn6Uslrsnca4D+D?= =?Windows-1252?Q?KpOLQe4hSeop0emsqTScFCAbJbtydSIoUFVrYj55ur1j+mEQynTqZ4nu?= =?Windows-1252?Q?kSqTQFswjDXhDh5dREaqwC0trjtuHwm7lr+MjaTTJoH9W6gNHRMRjWMc?= =?Windows-1252?Q?d95zB3kx68XX/wp4IoYZ2GA8/v3WFaFhQxno5fIN0b1nZx5V8WydM6xy?= =?Windows-1252?Q?b1PC9H5MRt3H9x8oEQ1mN28ovximEZ9JWUWPafg5OyRWMwCMOeZKxmx/?= =?Windows-1252?Q?krpk9+lrg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;6:bxG1IQjHRih/v/1RhJh8HsZ6innWoLlvbQrc5JQT/xeorxM1Pv0CeayfOHFvLjylV6VWhFCLP0Ihj3rmtp94L5WEFshCSvQu0GqKrMG99njxFUx31Ltj8EhcyZqwk7bJvCAnjtYu5RiSJCFRlaIgANaiNTp/Y52gjoXg13EsBj2YLRpff2MOiS5JiR6LmDPBGPS9v6pZaM6MJJgMkv8gpvbyqPjPOdUzQ5FrqicRKCAfMv9Lt8sQgvEhuIgQ5O4k9O2d40y3qO75yd4BkEvKuR9Qozdx5NvXZRPirNymN37OoiWSZJTyD3Ddr1cZmQ6SyxMKIlvIV4c5ov6reaYF61J6DUvmeQqswyaILrG8XzwNLyB/VK+gx1GSUdQWeeMY/ZxouwA1xinKOKClb+vRbNdzh9uC9QUtIw7arT9WEQ8=;5:JYh+g0SGXnpGPZtF7ZJthqsryNsS32MuzvoZp2VMsInaWvTrshiA53ewP/AnAxBJRaNtvKeBTl9l4TH6nJoh255pITVH29bLlCPOrPGUFn3UArm5KgN8vQWLP4LK70pLuvdjChgmNbA6KAlnX9Hlvw==;24:YYeIskkX/i9Nosq6t1B2nCH2cD5d/OMYLB4zoWxzAph3GayMCfwpaIBWxonas4qw5HCuWbR2qL65vdWUg6gw0IRgBHPJZj4EgDUE9vKn2fs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;7:a1oj3HAGtCiJxL+pHShLV6nsfTt/2j8MsBTtpKNxqXHDWY9GNn698H1s7g95jzryxG5QyoxGoU3YbX3Md4Tcky3R8s+rYoji3tLnbNmIciT9MIbrbqTwJoQNivDKFKP2kr+JthDf3LDZYrPspsM8IHfq37J6RV/jefEMlPxWztWa3CPv2sbrNftEzhS2OlInJbHfX67RYNtrzG20X519gdXgqDhyQPXAZagFVjFn08McunevGDPK3lpo0+ZmJxHMqvXSID0pzNgSzt4oFT4dI0vAPzjGUNrYInTemjyZ18jXjHPAtCppaFiQFCYPaVRP+ECUFEMyJQ579uCpOQDmtw==;20:O/gYfE586EZxkasfVVQFpHPYlJ7fqTnA5eySeEqK1d4JSN7xv1ukbfvXv4YFt36HEN/Gj3Si2Q7BagIzBWViadvZx9G2/o/C6O8FxDwkCXaXV1mpnqTJWU8mPkwr+rKVQ1cMjx4NwR9GR6cgE+TYsFv/Ek3eyhqbXVNT3WunoON2YypYsfo8hHZLzE0JLLBF1k8byHVsgFFwGN/s7Jc8LgZ74BGZkTUA10msOH/o2zmStjPBrX7JJ7g3iXA0KY/3 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2017 18:21:13.8128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1447 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/17 01:11, Peter Zijlstra wrote: >> However, I have looked into reworking to not use the extra_regs, and I see >> that the union in struct hw_perf_event currently contains various PMU-specific >> structures (hardware, software, tracepoint, intel_cqm, itrace, amd_power, >> and breakpoint). >> >> For amd_iommu PMU, we need additional registers for holding amd_iommu-specific >> parameters. So, it seems that we can just introduce amd_iommu-specific struct >> instead of re-using the existing structure for hardware events. >> >> I'm planning to add the following structure in the same union: >> >> union { >> ...... >> struct { /* amd_iommu */ >> u8 iommu_csource; >> u8 iommu_bank; >> u8 iommu_cntr; >> u16 iommu_devid; >> u16 iommu_devid_msk; >> u16 iommu_domid; >> u16 iommu_domid_msk; >> u32 iommu_pasid; >> u32 iommu_pasid_msk; >> }; >> }; >> >> Please let me know what you think, of if I am still missing your points. > Yes, adding a struct to that union is fine and clarifies things. And > just because I'm weird like that, there's a u8 hole after iommu_cntr. Ok, I'll update this in V10 that I'll be sending out this week. Thanks, Suravee