mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Christian Lamparter" <chunkeey@googlemail.com>,
	"Kalle Valo" <kvalo@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Felipe Balbi" <balbi@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree
Date: Tue, 14 Mar 2023 22:40:26 +0100	[thread overview]
Message-ID: <e19fd8bc-5944-409d-a4a1-3a3d53691634@app.fastmail.com> (raw)
In-Reply-To: <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org>

On Tue, Mar 14, 2023, at 20:57, Krzysztof Kozlowski wrote:
> On 14/03/2023 17:30, Arnd Bergmann wrote:
>
> Please split bindings to separate patch.
>
>>  MAINTAINERS                                   |  1 +
>>  arch/arm/boot/dts/omap2.dtsi                  |  4 ++
>>  arch/arm/boot/dts/omap2420-n8x0-common.dtsi   | 12 ++++
>
> DTS as well...

ok

>> +maintainers:
>> +  - Johannes Berg <johannes@sipsolutions.net>
>> +  - Christian Lamparter <chunkeey@web.de>
>> +
>> +description: |
>
> You can drop '|'.

ok

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - st,stlc4550
>> +      - st,stlc4560
>> +      - isil,p54spi
>> +      - cnxt,3110x
>
> Order above entries by name.

ok

>> +
>> +  power-gpios:
>
> If this is GPIO driving some power pin, then it should be
> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml)

As far as I can tell, it's the opposite: the gpio turns the power on
in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown,
if you think that's better, but I don't think that is how it was
meant.

>> +examples:
>> +  - |
>> +   gpio {
>
> Align example with above |, so four spaces. Or better indent entire
> example with four spaces.

Ok, that makes it much more readable.

>> +     gpio-controller;
>> +     #gpio-cells = <1>;
>> +     #interupt-cells = <1>;
>> +   };
>
> Drop "gpio" node. It's not needed for the example.

ok.

>> +   spi {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      wifi@0 {
>> +        reg = <0>;
>> +        compatible = "st,stlc4560";
>
> compatible before reg.

ok.

       Arnd

  reply	other threads:[~2023-03-14 21:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 16:30 Arnd Bergmann
2023-03-14 16:44 ` Johannes Berg
2023-03-14 19:57 ` Krzysztof Kozlowski
2023-03-14 21:40   ` Arnd Bergmann [this message]
2023-03-15  6:32     ` Krzysztof Kozlowski
2023-03-15  6:50       ` Arnd Bergmann
2023-03-15  7:11         ` Krzysztof Kozlowski
2023-03-14 20:18 ` Christian Lamparter
2023-03-15  5:32   ` Kalle Valo
2023-03-17 21:16 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e19fd8bc-5944-409d-a4a1-3a3d53691634@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=aaro.koskinen@iki.fi \
    --cc=arnd@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bcousson@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=chunkeey@googlemail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®