From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
llvm@lists.linux.dev, linux-kbuild@vger.kernel.org,
David Gow <davidgow@google.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386
Date: Tue, 4 Mar 2025 15:51:19 +0100 [thread overview]
Message-ID: <e1a1531d-6968-4ae8-a3b5-5ea0547ec4b3@t-8ch.de> (raw)
In-Reply-To: <20250304102536.GB2529736@ax162>
On 2025-03-04 11:25:36+0100, Nathan Chancellor wrote:
> On Mon, Mar 03, 2025 at 11:29:58PM +0100, Thomas Weißschuh wrote:
> > On 2025-03-03 13:52:41-0800, Kees Cook wrote:
<snip>
> > This is also what exists in tools/testing/selftests/lib.mk.
> > Minus the missing CONFIG_FORTIFY_SOURCE on clang x86_32
> > and a failure of overflow.DEFINE_FLEX_test (clang 19.1.7).
>
> Does Kees's other patch resolve the second issue? It'll obviously fix
> the first :P
>
> https://lore.kernel.org/20250303214929.work.499-kees@kernel.org/
No, it doesn't.
Running tests with:
$ .kunit/linux kunit.filter_glob=overflow.DEFINE_FLEX_test kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[15:48:30] =================== overflow (1 subtest) ===================
[15:48:30] # DEFINE_FLEX_test: EXPECTATION FAILED at lib/overflow_kunit.c:1200
[15:48:30] Expected __builtin_dynamic_object_size(two_but_zero, 0) == expected_raw_size, but
[15:48:30] __builtin_dynamic_object_size(two_but_zero, 0) == 12 (0xc)
[15:48:30] expected_raw_size == 8 (0x8)
[15:48:30] [FAILED] DEFINE_FLEX_test
[15:48:30] # module: overflow_kunit
[15:48:30] ==================== [FAILED] overflow =====================
[15:48:30] ============================================================
[15:48:30] Testing complete. Ran 1 tests: failed: 1
[15:48:31] Elapsed time: 43.985s total, 0.001s configuring, 43.818s building, 0.133s running
If I force CONFIG_CC_HAS_COUNTED_BY=n then the test succeeds.
Clang 19.1.7 from the Arch Linux repos.
<snip>
next prev parent reply other threads:[~2025-03-04 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 21:52 Kees Cook
2025-03-03 22:29 ` Thomas Weißschuh
2025-03-04 10:25 ` Nathan Chancellor
2025-03-04 14:51 ` Thomas Weißschuh [this message]
2025-03-04 17:07 ` Kees Cook
2025-03-05 14:45 ` Nathan Chancellor
2025-03-06 6:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a1531d-6968-4ae8-a3b5-5ea0547ec4b3@t-8ch.de \
--to=linux@weissschuh.net \
--cc=davidgow@google.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®