From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Carl Worth <carl@os.amperecomputing.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Sabrina Dubroca <sd@queasysnail.net>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: Fix data argument to coresight_enable_helpers
Date: Fri, 19 Sep 2025 09:20:55 +0800 [thread overview]
Message-ID: <e1a2ee99-07bc-40f3-8742-a0cb1c273350@oss.qualcomm.com> (raw)
In-Reply-To: <87frcj8kw7.fsf@rasp.cworth.amperemail.amperecomputing.com>
On 9/19/2025 6:18 AM, Carl Worth wrote:
> Jie Gan <jie.gan@oss.qualcomm.com> writes:
>> I dont think we can change back to sink_data since we introduced
>> coresight_path to wrap 'data' which is needed by the path.
>>
>> I suggest you to add the struct perf_output_handle to the
>> coresight_path, then retrieving it with data->perf_handle in
>> tmc_etr_get_buffer.
> ...
>> We can assign the perf_output_handle to the coresight_path after we
>> constructed the coresight_path in perf mode.
>
> Thanks. That much makes sense to me, and I'll put together a patch along
> those lines.
>
> But, further: with core coresight code assembling into the path all the
> data that is necessary, is there any reason to be using void* in these
> enable/disable functions?
In my opinion, yes, we can change void * to coresight_path * for
helper's enable/disable functions since we have everything in path so
the cast is not necessary now.
>
> Could we also change these functions to accept a coresight_path* and
> actually get some compiler help at finding mistakes like the one we're
> fixing here?
That's the only benefit in my mind so far.
Thanks,
Jie
>
> -Carl
next prev parent reply other threads:[~2025-09-19 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 22:44 Carl Worth
2025-09-17 1:35 ` Jie Gan
2025-09-17 9:37 ` Leo Yan
2025-09-18 22:18 ` Carl Worth
2025-09-19 1:20 ` Jie Gan [this message]
2025-09-19 7:43 ` Suzuki K Poulose
2025-09-19 20:12 ` Carl Worth
2025-09-19 17:49 ` [PATCH v2] coresight: Fix data arguments to coresight enable/disable helpers Carl Worth
2025-09-20 1:36 ` Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a2ee99-07bc-40f3-8742-a0cb1c273350@oss.qualcomm.com \
--to=jie.gan@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=carl@os.amperecomputing.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=sd@queasysnail.net \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®