From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Eric Woudstra <ericwouds@gmail.com>,
"Lucien.Jheng" <lucienzx159@gmail.com>,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn@mork.no,
frank-w@public-files.de, daniel@makrotopia.org,
lucien.jheng@airoha.com
Subject: Re: [PATCH v2] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support
Date: Sat, 28 Mar 2026 15:15:14 +0100 [thread overview]
Message-ID: <e1a3ca7c-99f0-4452-bd5e-ca3662fd8d9a@lunn.ch> (raw)
In-Reply-To: <acesgklpv8GlNeVf@shell.armlinux.org.uk>
On Sat, Mar 28, 2026 at 10:25:06AM +0000, Russell King (Oracle) wrote:
> On Sat, Mar 28, 2026 at 11:21:59AM +0100, Eric Woudstra wrote:
> > static int air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address,
> > u32 pbus_data)
> > {
> > int ret;
> >
> > mutex_lock(&mdio->bus->mdio_lock);
>
> I wonder why we have phy_lock_mdio_bus() but not mdio_bus_lock()...
> Should a helper be provided at mdio bus level to complement the PHY
> level helper if we're going to have MDIO drivers directly manipulating
> the lock?
DSA is pretty much the only class of mdio driver. And they mostly need
to use:
mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
Not the plain mutex_lock().
Hence it has not been added up until now.
But yes, such a helper would make sense for a PHY driver having to do
odd things.
Andrew
next prev parent reply other threads:[~2026-03-28 14:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 15:35 Lucien.Jheng
2026-03-26 20:00 ` Eric Woudstra
2026-03-29 4:59 ` Lucien.Jheng
2026-03-27 4:41 ` Eric Woudstra
2026-03-28 10:21 ` Eric Woudstra
2026-03-28 10:25 ` Russell King (Oracle)
2026-03-28 14:15 ` Andrew Lunn [this message]
2026-03-29 5:09 ` Lucien.Jheng
2026-03-29 5:05 ` Lucien.Jheng
2026-03-29 5:04 ` Lucien.Jheng
2026-04-16 15:24 ` Lucien.Jheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a3ca7c-99f0-4452-bd5e-ca3662fd8d9a@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lucien.jheng@airoha.com \
--cc=lucienzx159@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®