From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2E532B9B6 for ; Thu, 12 Mar 2026 16:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773333130; cv=none; b=Da6Mmz0/u6p/NCOhQqSap3bL+KTD+NZhN0CMiqxRAEywcWqqT0Cp+p5JnYsClPKQZrx2yNEf6tVgdkrmblY150D4yeUPDeXQRmiEw5Nc3Oms4RVtgOk4yfcVQxc1f+0mfkoz0L0XR3AUiFZS4BGcOmmCis8OKuJGeRZZzG2MTbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773333130; c=relaxed/simple; bh=Rj1aAzmENFbmH263gHgPBHHEzauaoZ9Ko2MKwh+ioR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h2+oLDtnjlgZeleSOx+QMg/gbCqvlNmwXQjO/if+vDKuce5NsORmtre23vJQZRNpNv7XakCRjPOejOeOe55DG+85aWS0DwuA4SQ3UiPgc2CQqYmKTEW0yepSOjNthCC+zkorvFt2DjjYkB84fLpcZiUpwUtPQUkV9zBTTNaiHTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GQaxnQaz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I77csMeM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GQaxnQaz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I77csMeM" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9XaFt1922655 for ; Thu, 12 Mar 2026 16:32:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PjpMODJr3NfcaI0ySY7IsYGndsEPTOCwMM567hJqs+Y=; b=GQaxnQazUfNQl3Ya f7V7vDxmI1ij1ocsRs89FV1nG37Psefohq7lzCsIhYx0fI4KfDrhUlMI7QJi1qWy Jf1T+IjvKrAl2Zg1AndrygzO/sU4nD8GhlyitdHKYM5Gvu4iOUAKUB7DaB9HFqVe ZrV6UUX8huuU1DQDU0MPpnAPQJMbljypGkjIwFTDKtx92m/5H7d4yceOwsnPutLc iR6sHMWb3MaPvuYsXbkukAepAmLgxKBoqq9jIBUiRqEtWWRoRdG6L/OwqVgMO/FY IHcZtknWeOtaEK4JH4YHR61zpYm04n9y3Y7H9E2WenBvqC774be4QPV+/gutZ1Vh Ob+BMg== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4wtu0t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 16:32:08 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-94ea014ec7cso1176103241.0 for ; Thu, 12 Mar 2026 09:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773333127; x=1773937927; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=PjpMODJr3NfcaI0ySY7IsYGndsEPTOCwMM567hJqs+Y=; b=I77csMeM8Jou/U/Z+Z9Abs4ccsrIZCDUNdlUKOtW1Os+d/iUApaOmsdZ7kkd5ESjjy 3RbsclQT+WRL/b4gWBDs8SWeesTG9RUPMH0dYA9K7SiGk0FE/XNwPS9x+T8t+v6T6/Ld QVN0V+X5nKX8DpM4zB+lknyjqiNGnyZr22AKjMkAs4RuO8gtLo0wYa2xPiTDQQa8uUUb FfWw25/L3IN8KWtPXf+u8DCO47GMO6m/qHIl+kITiUky86jEB0lZHne7jE8QH1XSbHkS N5/zuV5PsFJ/kUPc1XGwlVmTbThxb+yogNdPEl8FSoT8+fNb5sehOUOggxsrv1E2Bxep cjRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773333127; x=1773937927; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PjpMODJr3NfcaI0ySY7IsYGndsEPTOCwMM567hJqs+Y=; b=iapFFyUkiA7s9fOOF06ifavNri9kzggo1DS3TOAaMFX0HsDz06HwUP7CFJ93EqCrD9 Gaynbij36M7ZTt8mAOAB/wgAEegT2x00WmjhqG+J/2koNj7y6AnrgjavRUI3rTW976ay 26roCiKsclhnMqby9G5ZMtj066nh/+nxqEaEIvwYurV4oKJF4hz8n3B/3KRU5fu2zf1T v7zxFK4CfTbfAkBT8GO9Bsh/RNUgJkTiBiJU2fqBH+9o/Vvl7TeqdvmHt/oLvKEN4WDE o6IBkg8kLnT0mk0/UCO8GC1ZEH1C/M7YObBWAwJilqaM1LK4aFwBz+H2SZb4Ly/6j3EO 6+Mw== X-Forwarded-Encrypted: i=1; AJvYcCXEFA3L6Cy9c9GGLG4cMq59545E85vWdwSx8wm8V2BQ4/yA0rJtz9qDjEkR57YoBGujIs2+8taEo+OJ/x8=@vger.kernel.org X-Gm-Message-State: AOJu0YxlcCahnmcAcZI28+2uAAEwNQFIMPUbrZDoEEBh9WOvhbqnOG1W rqvn6EK8BIdrEZ4h2BrVwQg9spM+P9HBjdpAN0KrNyDaINuCPJvfKDIjTNtRlCe/rBjAM78msYo lKsenLeS06kI5zVOfCOBpItF8NOheOl81o4GmQXkRxbltzQlop0F25KJF8KgGJtdmKeY= X-Gm-Gg: ATEYQzykIqgaj50Im3qNB77Pnb8ybwgpp5cYCM/phEMnKGpdz6WqSTn2faW+zE/qNu+ gARQUJUsfy1N4zBRRbKHeXLoJEJllsE2EbP4h/Mv4ThwHedWyoPB7b4UOgNNvLRF4y+l5v9Wey9 EyQKNECg6ELLGJbbKVHmpn0jGBWG6v/CWajnGiVdLdjL22ouv/Z0mfb5GA48hqy6fWjdruME6BL itQz/P+T2kahgsNlnAbJc6rl1k/PwDheeIabMnWESP4KLb2t044jxXPxiCh5aNf4H4v3bC/S4iC vDxVhiNd0lzKAs2Nc8asEVNA12kMYWHshXiVVG7kFMv1nnHYQQIUse6oOpmp3jA3CXA30wV/Dz7 K96EqDpfKQiZEcBblTsATm8BU4iDa+Nx0gqTRxv+hDbWwBXbx X-Received: by 2002:a05:6102:5488:b0:601:fa6c:bb49 with SMTP id ada2fe7eead31-6020de40718mr67102137.0.1773333127241; Thu, 12 Mar 2026 09:32:07 -0700 (PDT) X-Received: by 2002:a05:6102:5488:b0:601:fa6c:bb49 with SMTP id ada2fe7eead31-6020de40718mr67055137.0.1773333126672; Thu, 12 Mar 2026 09:32:06 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b0dc76csm50243175e9.24.2026.03.12.09.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 09:32:05 -0700 (PDT) Message-ID: Date: Thu, 12 Mar 2026 17:32:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] drm/msm/hdmi: Simplify with dev_of_node() To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> <20260311-drm-msm-hdmi-cleanup-v1-1-c5535245f6de@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GcoaXAXL c=1 sm=1 tr=0 ts=69b2ea88 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=R8rHp1AcDowi_5njnBkA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-GUID: 609wIBMJY9t0HlzUtUlIQ-rPMnZnuQWu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEzMyBTYWx0ZWRfX94hJNr5W0L3u cAGho9WnDnKlfcm3kAkTyUF/CHzEpMaX+cGjwrtJlFfqHhXA0/qnBu9aUDI27thvBgNfNeUAk9F Cnfr5igp35hA859kt6UD6OWLBRxh9gncG6FbAMRpAKmKy2Dqd512aro6daNaXUmbRzzGnc8TEOv hyKVzGxFiTT/wqqPRWoxwsKzaGrkG7BRqbT9+Hx0taBGWJi8VK1187vPquJQuttepQQXPzNniwk ExFCHC7ZPInZJ/K/mO484Yk0Uoa8gDe2AMDiAaftEIgjzmE13Xd1uvt145/NUau0A6JSxD5kf0O ME9qPULv4YEw0tug0gc7+VnimJbOq1z4wNdjTWrzSMgFX6LqC/o/E1jE3+/EdDoqj+Ulg/q17+1 oKgcn+4f6WmT8GbtowwXdAMbSOXb5EEtR1RTzqTRpQC9Xb+pfipHEbs2H/cIds2XO34/lUGHf6l ko1A3+O8n5bi45Ro42Q== X-Proofpoint-ORIG-GUID: 609wIBMJY9t0HlzUtUlIQ-rPMnZnuQWu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_02,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120133 On 12/03/2026 03:41, Dmitry Baryshkov wrote: > On Wed, Mar 11, 2026 at 09:17:25PM +0100, Krzysztof Kozlowski wrote: >> Simplify chain of pointer dereferences with dev_of_node() which also >> checks if 'dev' argument is non-NULL. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/gpu/drm/msm/hdmi/hdmi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c >> index 5afac09c0d33..b1db1b597901 100644 >> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c >> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c >> @@ -91,7 +91,7 @@ static int msm_hdmi_get_phy(struct hdmi *hdmi) >> struct platform_device *phy_pdev; >> struct device_node *phy_node; >> >> - phy_node = of_parse_phandle(pdev->dev.of_node, "phys", 0); >> + phy_node = of_parse_phandle(dev_of_node(&pdev->dev), "phys", 0); >> if (!phy_node) { >> DRM_DEV_ERROR(&pdev->dev, "cannot find phy device\n"); >> return -ENXIO; >> @@ -287,7 +287,7 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) >> spin_lock_init(&hdmi->reg_lock); >> mutex_init(&hdmi->state_mutex); >> >> - ret = drm_of_find_panel_or_bridge(pdev->dev.of_node, 1, 0, NULL, &hdmi->next_bridge); >> + ret = drm_of_find_panel_or_bridge(dev_of_node(dev), 1, 0, NULL, &hdmi->next_bridge); > > dev_of_node(&pdev->dev)? Why? dev is already simpler. Best regards, Krzysztof