From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40068388382 for ; Fri, 3 Jul 2026 10:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783073930; cv=none; b=uvvKfIMMhLkA/2XPR8qit1HRFVDSMYAAjZRx878jqwSzKqGmIEamBIhryxMUOOr4G9C6RvYCTYP1Da6NsmG7w/hS/YPkDDIaKhRxzRkiSnfKGPJdloF+MvFDnxNHn8WuVsOOa5VQoC0yHDr0ONNu8YmaA0fIEQm3uJFBCeMva4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783073930; c=relaxed/simple; bh=8OFWNCbURolQD3Sov53H3npHaBN9A8nfkgPDw05e2ws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XF5NbLBQMmQzJ/q5AXc9z4jex0U8p9nnzlHab095opujN6RAfsGtEJ58XZn7Qqo36x4cmp2K9NnesSzlNfRLpE+hqV4QNv9Zd7Q7Q695rmxnhkGHbTZxldai8uL7p28Pkjj1IpJeryhtAo8gqj5QF+81eb3VloRSSZm5zbaruDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ln7Zp71s; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ln7Zp71s" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-461edb387ddso454502f8f.3 for ; Fri, 03 Jul 2026 03:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783073927; x=1783678727; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=J4TlNqV3mx8KyiPBJLJ8UAQ0DYIT8bRlsX65QUTl3AQ=; b=Ln7Zp71szlwPiS2w5rG867/PSvewV+qweyi/puLCarKDVElyuSDmfkSx3SIq6TnULX X4mgSf95JfOXG9Z5ALsmqyH/gGhF8PRWWeG7wjybKCkXhW+vkg/BGtAqqjIiDcfwqXJl 7wr+VJC+FN+ZyshMHeHqm2sOffU+f5HC3KFoUOcOsTwKk0JIEc2qkxBrAHgXtbdPrgN0 egHEHsaWj6JMV87A+nVEDAePnGy7gMVouMEatgGhCJtJdvNnGgXg8phWS3fs533u6BJD lCacijdXL0dcNSpGevq6lXXdx3JddmNdr+sKvyNgnwZLT39q7hTZzdNjkS/XtfAgXWW2 DlMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783073927; x=1783678727; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=J4TlNqV3mx8KyiPBJLJ8UAQ0DYIT8bRlsX65QUTl3AQ=; b=oXnlMiK+sHH5bACC1Otafye4ug8/qdr8kArSfY2Mj3rxBddveyJ2TuRORGQx8TxgoD wJPUT5xcOl8V+OHr3kIcUPfEokjbYBgJwMA/V+4awxQMJ4pf3IypOtgX0FJtCzI0dCKm ovNptREeO3F0EnyowJj1pJQBJmHDsqw1699kwGOv9oFoxo4OMFs52nH8PwgJ1U6dgvGr +zi3El/JAuavhuPI3DYvcddm/5ITx4YGUnU4DCxRmyYThUgr16j5jfk3LNch5YlwEw9/ l3ROwQ40U63Goi1BWlS03+B+cqMSYwyLisJ4I54DcYrzoDeRyiRG0RXFmTiS6rwYl3eB /O7w== X-Forwarded-Encrypted: i=1; AHgh+Ro536M8jKTl+WQVrB9hnPm0njp5hkRQM1k3JqYAY/O1E98NhXb1jWl4mQx9wbvpRyS97Dnwhoe0xlBhl5s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx93zxji3tc9oBB13fdGbSLwoJ6z2vxznFZdMbrm6b2uKZ4i21L ZgiMaCOfzZW3hdGhUPxPmghnWWgQ6TcU22/61FYoH3yfIEesdSvqWbfEZAIH X-Gm-Gg: AfdE7cnClgt4gGNjWwU8v4eEwxALy8YUEUVDqC+8bLPjOLSfuNwvabv9u1hCQMNGkKp wOuXZm0UnMK0MM4dwbAKMRnypWk99bJc5j0QrE4/u0e/LCp864HhjwwHNBROmiMOPL+tZPyvN4Q lbS1ZFLLMqIqQLwuFeEmAERc9lCOaXjNGyBIYonL0RDIIsKucM/QvFyMHWqUmMFwBKuiizR6xNt xut/eYvveaJC4hksO1EDkjk/WzYFCtQXNk3mVPL8MBcNq0ah4PyX/AilusXmI56BGJwUNTibdDB Pq+WGPAAsGrjMlhAIyS0Y4rpwVSFg5ovTrnlrkBkb4WQtrJBdNhAVbrv2cJjh2nEZHkdfQ5feGz 3NN76jzFNokf3qM/OL6FWjHRtxQOes0y2g7Kx+Wl7XXgsmBT5RgWZHyfS9wooFNQ= X-Received: by 2002:a05:6000:29c6:b0:46d:d90b:bbde with SMTP id ffacd0b85a97d-477b10fff8emr8997165f8f.38.1783073927161; Fri, 03 Jul 2026 03:18:47 -0700 (PDT) Received: from p183 ([178.172.147.205]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0f310sm16693810f8f.31.2026.07.03.03.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 03:18:46 -0700 (PDT) Date: Fri, 3 Jul 2026 13:21:57 +0300 From: Alexey Dobriyan To: Dmitry Antipov Cc: Andy Shevchenko , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Revert "lib: fix _parse_integer_limit() to handle overflow" Message-ID: References: <20260702180638.39196-1-adobriyan@gmail.com> <8283a924-2598-4627-b2d2-11912a8b4fd7@yandex.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8283a924-2598-4627-b2d2-11912a8b4fd7@yandex.ru> On Fri, Jul 03, 2026 at 09:52:34AM +0300, Dmitry Antipov wrote: > On 7/3/26 9:05 AM, Andy Shevchenko wrote: > > > +1. We need test cases, since there were none what is the real life example of > > the breakage? > > I've (qemu-)tried: > > CONFIG_PRINTF_KUNIT_TEST=y > CONFIG_SCANF_KUNIT_TEST=y > CONFIG_CMDLINE_KUNIT_TEST=y > > on x86_64, arm, and riscv - without seeing anything suspicious... This code was written in such a way to have common code between old scanf/strtoul code (which parsed incorrectly) and new kstrt*() code. scanf/strtoul instances were left alone to rot. You can not do "res = ULLONG_MAX;"