From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbdJXGZj (ORCPT ); Tue, 24 Oct 2017 02:25:39 -0400 Received: from 14.mo6.mail-out.ovh.net ([46.105.56.113]:35790 "EHLO 14.mo6.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbdJXGZK (ORCPT ); Tue, 24 Oct 2017 02:25:10 -0400 X-Greylist: delayed 1202 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 Oct 2017 02:25:10 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 24 Oct 2017 07:46:53 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Raveendra Padasalagi Cc: Rob Herring , Mark Rutland , Kishon Vijay Abraham I , Russell King , Scott Branden , Ray Jui , Srinath Mannam , Jon Mason , Florian Fainelli , Yoshihiro Shimoda , Raviteja Garimella , Arnd Bergmann , Viresh Kumar , Jaehoon Chung , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 2/3] drivers: phy: broadcom: Add driver for Cygnus USB phy controller In-Reply-To: <1508819822-29956-3-git-send-email-raveendra.padasalagi@broadcom.com> References: <1508819822-29956-1-git-send-email-raveendra.padasalagi@broadcom.com> <1508819822-29956-3-git-send-email-raveendra.padasalagi@broadcom.com> Message-ID: User-Agent: Roundcube Webmail/1.3.0 X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl X-Ovh-Tracer-Id: 15267484212524191457 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedttddrvdejgddutddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-10-24 06:37, Raveendra Padasalagi wrote: > Add driver for Broadcom's USB phy controller's used in Cygnus > familyof SoC. Cygnus has three USB phy controller's, port 0, > port 1 provides USB host functionality and port 2 can be configured > for host/device role. > > Configuration of host/device role for port 2 is achieved based on > the extcon events, the driver registers to extcon framework to get > appropriate connect events for Host/Device cables connect/disconnect > states based on VBUS and ID interrupts. Minor issues commented inline. > +#define USB2_IDM_IDM_IO_CONTROL_DIRECT_OFFSET 0x0408 > +#define USB2_IDM_IDM_IO_CONTROL_DIRECT_CLK_ENABLE BIT(0) Here you define reg bits using BIT(n). > +#define SUSPEND_OVERRIDE_0 13 > +#define SUSPEND_OVERRIDE_1 14 > +#define SUSPEND_OVERRIDE_2 15 > +#define USB2_IDM_IDM_RESET_CONTROL_OFFSET 0x0800 > +#define USB2_IDM_IDM_RESET_CONTROL__RESET 0 And here without BIT(n). Either is fine but it may be better to be consistent about it. > +static int cygnus_phy_probe(struct platform_device *pdev) > +{ > + struct resource *res; > + struct cygnus_phy_driver *phy_driver; > + struct phy_provider *phy_provider; > + int i, ret; > + u32 reg_val; > + struct device *dev = &pdev->dev; > + struct device_node *node = dev->of_node; > + > + /* allocate memory for each phy instance */ > + phy_driver = devm_kzalloc(dev, sizeof(struct cygnus_phy_driver), > + GFP_KERNEL); > + if (!phy_driver) > + return -ENOMEM; > + > + phy_driver->num_phys = of_get_child_count(node); > + > + if (phy_driver->num_phys == 0) { > + dev_err(dev, "PHY no child node\n"); > + return -ENODEV; > + } > + > + phy_driver->instances = devm_kcalloc(dev, phy_driver->num_phys, > + sizeof(struct cygnus_phy_instance), > + GFP_KERNEL); I don't think kcalloc is safe here. E.g. In cygnus_phy_shutdown you iterate over all instances reading the .power value. If cygnus_phy_shutdown gets called before having each instance powered up, you'll read random memory as .power value.