From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EDE2363C7A for ; Tue, 27 Jan 2026 15:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527602; cv=none; b=hKtORCRX5A72hYv2QbTCxPcCKEc/ao6gQo3oYou4XJGFTfu/9p1QZ2KwR0742NDoPp6CwYroNVXhDiVIOEIzTbmlo6L3F4SVW376bgoH90slyFpBdev6CO0lKfJjZvYuR1jgVkibih+KZG/8x/DCLKD3eKDGd9iBowJJKGSczl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527602; c=relaxed/simple; bh=vx3jLTsBw4rxu7hoSeZBPfSAXJs751JIn0jAWWF5Xbs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dy3Ju6Zs/5wNCCssfM95pQwkwGV4UJV9wqMKqgBGe5N/AoQ7vQVaDBvNS8c8SCYRqaXMCcy/50YbjpNbhUboJke+mlC8tc1JyXfiVFs6hlnNuiMVt9MOysYj6EuihM2xRbBZVm1xan0frj6na//kNDO3X3EvmY8lPL84Ak4Btds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QGP4ffXF; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QGP4ffXF" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-b4755f37c3eso3776629a12.3 for ; Tue, 27 Jan 2026 07:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769527599; x=1770132399; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M/fsCYTkIXDItTcE/n6muZz7y6GpmWCERYqeftONhwg=; b=QGP4ffXFHYsQg3cvB0lFgrynOjqO413hWZG7svBN6ys0WSKS5O9r1+eOhhxNc6eYVT vI+x1rHcenB6SMnKYfePU2+mVHaA88dAHf5tpIKpAoGpVq6joM0sDVeeL3l36983x+sF FQp7mDPHg1b3NU4jhQNl1zKBy0izeeanmPhEl0qdroxWyTsORsOq69xmXa8Yjq6koIxV Z0WCZbkvUHjQ4qz8xvc0KUh24fwlZ1YK/2UW/Og1wso0U70DWxmQs9uSbTBvc/UjJLs2 CNcN6GPNbCA+OCtiAf4E4CbfZ3hPDqkh1BUBM6126zZcgrtSYWeV7bwhushMLKPRfTCI RiUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769527599; x=1770132399; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M/fsCYTkIXDItTcE/n6muZz7y6GpmWCERYqeftONhwg=; b=HwGKmnKsKIdi532vZiCl35d/qxxWIV42zf0IrSXzB2VgvgAlXY0T3ELatvRdnS+43c n3hOd03PrB81hbcsPFKrNf4smoahgjMOLRFwAZDQHSJ8Sd1Q488YiVkJy0QU/PZYUR03 UiSj8ZqEiTltD3xDFt0jJGZXbE1ENqp7LIf+Ek4PFXx2fPKWlbQqjSPZcpMWShDt4FKm IA4XgasIg2UN+FVTYWmLhiqhuvJOEwOFF/WPs/H0fXjFTsUihW0FjyZ3S5PXXohXaSeH p4XUiY9+Ebw0+YZiecXKvn/8KBFYE0pUmbkSV4oMdHdo9wQV5QQ0wKbMNUwzut/jawyk UaQQ== X-Forwarded-Encrypted: i=1; AJvYcCXwp3AKNpOX/Uc8RGEHFPq7Xt13xbqUdz1ELGgLfOw0i5p1gmi3Gxc02UbXyxVf0qo8/FKAsJqEO96GEYc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5TWI8iZArWWfCAcC5R7xu3fyNb1OyFOoemEAjNsx6MkxZ15yz tCJ6bTU2XL3Cr2GRvltorWX9tzX+oPSHJo3bC0ckRhCx43GJPC3uXzSB X-Gm-Gg: AZuq6aJ4uhTU4QYSR9/FKBNpTWisSTJ5HWpMZF6abMPjiR+iHezHt5yblWug54PohDa moO1tdB2nCVzi4hh2LdM3IBnpwFeLYthQMGhmtjKXdqxT/ghh74UTvzGl+0sJ9dzt7aum/sMyAZ naJywffy7ZsYllOtYAkYVfQKWOnczC/jzLAqeykcSf+vK5XftF7xlDZ9/7uRBfGMEAscfJqPKgC GT0BMvlu9Ytd2eh5TV5C7UeFLAlHbwUb69n8ajnd/7XU1Aet+hkgkmMjA5fr6BrAdp6pjuBKXmE Ehp5JWWNjReovtOr+heltf2aOioMv7yP2cAFpKFgcDkbxJrcg18BYDf5GI5omGUd8m6gS97zOnB f0m4uTjKqWf+TbRxPh2pa78fwNXFdL3xLHmK097DlBEiIqbuJAVrEXC7FMf7yE1ZvOceq3Ji83y QTAhw6RjaWT5V4MlyE3cydmyX/gFbM9/YLSBI= X-Received: by 2002:a17:903:2cf:b0:295:1e50:e7cb with SMTP id d9443c01a7336-2a870d7446cmr22169425ad.23.1769527599292; Tue, 27 Jan 2026 07:26:39 -0800 (PST) Received: from [192.168.1.5] ([115.99.251.203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802fdd70asm123437515ad.92.2026.01.27.07.26.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 07:26:38 -0800 (PST) Message-ID: Date: Tue, 27 Jan 2026 20:56:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: usb: ti,omap4-musb: convert to DT schema To: Rob Herring Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Felipe Balbi , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260126-ti-usb-v1-0-2855c129eb6d@gmail.com> <20260126-ti-usb-v1-1-2855c129eb6d@gmail.com> <20260126160610.GA2471873-robh@kernel.org> Content-Language: en-US From: Charan Pedumuru In-Reply-To: <20260126160610.GA2471873-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26-01-2026 21:36, Rob Herring wrote: > On Mon, Jan 26, 2026 at 01:22:04PM +0000, Charan Pedumuru wrote: >> Convert OMAP MUSB USB OTG Controller binding to DT schema. >> Changes during conversion: >> - Introduce new compatible string patterns "am35x_otg_hs" and "usb_otg_hs" >> to properly match existing nodes already defined in the DT sources. >> - Include "interrupts" and "interrupt-names" properties in the YAML, as >> they are used by many in-tree DTS files. >> - Extend the "power" property to allow the value 150 (in addition to >> existing values), since this is present in several in-tree DTS examples. >> >> Signed-off-by: Charan Pedumuru >> --- >> .../devicetree/bindings/usb/ti,omap4-musb.yaml | 133 +++++++++++++++++++++ >> 1 file changed, 133 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/ti,omap4-musb.yaml b/Documentation/devicetree/bindings/usb/ti,omap4-musb.yaml >> new file mode 100644 >> index 000000000000..16e95fe4c38d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/ti,omap4-musb.yaml >> @@ -0,0 +1,133 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/usb/ti,omap4-musb.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments OMAP MUSB USB OTG Controller >> + >> +maintainers: >> + - Felipe Balbi > Missing '>' Yeah, I missed it, will add in the next rev. > >> + >> +description: >> + Texas Instruments glue layer for the Mentor Graphics MUSB OTG controller. >> + Handles SoC-specific integration including PHY interface bridging(ULPI/ >> + UTMI), interrupt aggregation, DMA engine coordination (internal/ >> + external), VBUS/session control via control module mailbox, and >> + clock/reset management. Provides fixed hardware configuration parameters >> + to the generic MUSB core driver. >> + >> +properties: >> + $nodename: >> + pattern: "^(am35x_otg_hs|usb_otg_hs|usb)@[0-9a-f]+$" > > Again, do not document non-standard names. That's anything not in the DT > spec. Sure, I will remove pattern entirely. > >> + >> + compatible: >> + enum: >> + - ti,omap3-musb >> + - ti,omap4-musb >> + >> + reg: >> + maxItems: 1 >> + >> + ti,hwmods: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: >> + Specifies the name of the TI PRCM (Power, Reset and Clock Management) >> + hardware module that must be enabled (powered and clocked) for this >> + device node to operate. The value "usb_otg_hs" refers to the USB >> + On-The-Go High-Speed controller IP block. >> + const: usb_otg_hs > > deprecated: true > > (I think we want that everywhere?) > > Actually, looks like only omap2430 sets this, but that's not covered by > this schema. Unless you need to add "ti,omap2-musb"? Okay, in that case I will drop the property. > >> + >> + interrupts: >> + minItems: 1 >> + maxItems: 2 >> + >> + interrupt-names: >> + minItems: 1 >> + maxItems: 2 >> + items: >> + enum: [mc, dma] > > I would assume only 'dma' is optional? Does this work?: > > items: > - const: mc > - const: dma Yes, this works. > >> + >> + multipoint: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Indicates the MUSB controller supports multipoint. This is a MUSB >> + configuration-specific setting. >> + const: 1 >> + >> + num-eps: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Specifies the number of endpoints. This is a MUSB configuration >> + specific setting. >> + const: 16 >> + >> + ram-bits: >> + description: >> + Specifies the RAM address size. >> + const: 12 >> + >> + interface-type: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Describes the type of interface between the controller and the PHY. >> + 0 for ULPI, 1 for UTMI. >> + enum: [0, 1] >> + >> + mode: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: 1 for HOST, 2 for PERIPHERAL, 3 for OTG. >> + enum: [1, 2, 3] >> + >> + power: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Signifies the controller can supply up to 100mA when operating >> + in host mode. >> + enum: [50, 150] > > Which value corresponds to 100mA? 50 corresponds to 100mA, I will add it to the description. > >> + >> + phys: >> + maxItems: 1 >> + >> + phy-names: >> + const: usb2-phy >> + >> + usb-phy: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: Phandle for the PHY device. >> + deprecated: true >> + >> + ctrl-module: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle of the control module this glue uses to write to mailbox. >> + >> +required: >> + - reg >> + - compatible >> + - interrupts >> + - interrupt-names >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + usb_otg_hs@4a0ab000 { > > usb@... Okay. > >> + compatible = "ti,omap4-musb"; >> + reg = <0x4a0ab000 0x1000>; >> + interrupts = , >> + ; >> + interrupt-names = "mc", "dma"; >> + ti,hwmods = "usb_otg_hs"; >> + multipoint = <1>; >> + num-eps = <16>; >> + ram-bits = <12>; >> + ctrl-module = <&omap_control_usb>; >> + phys = <&usb2_phy>; >> + phy-names = "usb2-phy"; >> + interface-type = <1>; >> + mode = <3>; >> + power = <50>; >> + }; >> +... >> >> -- >> 2.52.0 >> -- Best Regards, Charan.