From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49232.qiye.163.com (mail-m49232.qiye.163.com [45.254.49.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D19B3081B0 for ; Mon, 12 Jan 2026 08:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768205701; cv=none; b=XCM12D7F84RuJwHi3LNniD7tOMspZoVBLy1APsBj7ENmeHkD9FT/ezChjnRrGzdY7Sk0kcPs65nqEGkDDV7Nltg6YnimKVP4mIdLAAcsrliFmgmxPK7Nz0Wmu/dacmvEBASA60WFjzIb5kdXNXo8QbMPIwET+QRppXj4ztnePPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768205701; c=relaxed/simple; bh=fzZAV1A2W37d7jkgemAznjRxGJ5kpk15gasBGRgzKG4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JYkSeChLblNqBOdkdzw+DK3Ao34VDOmhpvSktc/PLzXjROQAWercVDIo7uat1/Sm7/6ETBqujw4LlAbPg/cP8nktyRnQCMiQ/EFNrkD63LAtIlj0j+TeGHZEagydmO046RY6s47u+Gptmi1JLOjvoJwmYvZkOFaz6h15ucVd0sA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=QHAq8MO7; arc=none smtp.client-ip=45.254.49.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="QHAq8MO7" Received: from [172.16.12.163] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 304e3eef6; Mon, 12 Jan 2026 16:14:47 +0800 (GMT+08:00) Message-ID: Date: Mon, 12 Jan 2026 16:14:44 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding To: Diederik de Haas , lee@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20251231030951.818-1-chenjh@rock-chips.com> <20251231030951.818-2-chenjh@rock-chips.com> From: Joseph Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9bb1459c1209d2kunm351b8d254ad0a2 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGk0YQ1ZCT0pDQhpKQ0IaGk5WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=QHAq8MO7b62Tt85f3nezmMwT/z8KCURMhdqbXZn+wAHn6B2khbW4RoeBZpHjdymNPiRQKb+9XvcVnI/1FR2Zm9mtSWuurPuhzGintbJnJdP9SywWlKtdoyPff2Eq8+2o892YoalAyZuldre6ADSXSZ+m78huDyObZbow6GjrxLE=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=Q66TpXs0dOTOSgQzUkBqxcuA/Fv1aGNrZKeB5wXl244=; h=date:mime-version:subject:message-id:from; 在 2025/12/31 21:36, Diederik de Haas 写道: > On Wed Dec 31, 2025 at 4:09 AM CET, Joseph Chen wrote: >> Add DT binding document for Rockchip's RK801 PMIC >> >> Signed-off-by: Joseph Chen >> --- >> .../bindings/mfd/rockchip,rk801.yaml | 199 ++++++++++++++++++ >> 1 file changed, 199 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml >> new file mode 100644 >> index 00000000000..d591125dfe8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml >> @@ -0,0 +1,199 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/rockchip,rk801.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: RK801 Power Management Integrated Circuit >> + >> +maintainers: >> + - Joseph Chen >> + >> +description: | >> + Rockchip RK801 series PMIC. This device consists of an i2c controlled MFD >> + that includes multiple switchable regulators. >> + >> +properties: >> + compatible: >> + enum: >> + - rockchip,rk801 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + rockchip,system-power-controller: >> + type: boolean >> + description: >> + Telling whether or not this PMIC is controlling the system power. >> + >> + system-power-controller: true > Why add 'rockchip,system-power-controller' while also adding > 'system-power-controller'? > > Property 'rockchip,system-power-controller' was deprecated in commit > 961748bb1555 ("dt-bindings: mfd: rk8xx: Deprecate rockchip,system-power-controller") > > And because of that I submitted this patch/commit: > b99ac7e2a1cc ("arm64: dts: rockchip: Drop rockchip prefix of s-p-c PMIC prop from rk356x") > to replace the deprecated variant with the non-deprecated one. > > Cheers, > Diederik Thanks for the review. I will drop this property in v2. >> + >> + wakeup-source: >> + type: boolean >> + description: >> + Device can be used as a wakeup source. >> + >> + vcc1-supply: >> + description: >> + The input supply for DCDC_REG1. >> + >> + vcc2-supply: >> + description: >> + The input supply for DCDC_REG2. >> + >> + vcc3-supply: >> + description: >> + The input supply for DCDC_REG3. >> + >> + vcc4-supply: >> + description: >> + The input supply for DCDC_REG4. >> + >> + vcc5-supply: >> + description: >> + The input supply for LDO_REG1. >> + >> + vcc6-supply: >> + description: >> + The input supply for LDO_REG2. >> + >> + vcc7-supply: >> + description: >> + The input supply for SWITCH_REG. >> + >> + regulators: >> + type: object >> + patternProperties: >> + "^(DCDC_REG[1-4]|LDO_REG[1-2]|SWITCH_REG)$": >> + type: object >> + $ref: /schemas/regulator/regulator.yaml# >> + unevaluatedProperties: false >> + unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + rk801: rk801@27 { >> + compatible = "rockchip,rk801"; >> + reg = <0x27>; >> + interrupt-parent = <&gpio0>; >> + interrupts = ; >> + pwrctrl-gpios = <&gpio0 RK_PC1 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pmic_int_l>; >> + rockchip,system-power-controller; >> + wakeup-source; >> + >> + vcc1-supply = <&vcc12v_dcin>; >> + vcc2-supply = <&vcc12v_dcin>; >> + vcc3-supply = <&vcc5v0_sys>; >> + vcc4-supply = <&vcc5v0_sys>; >> + vcc5-supply = <&vcc3v3_sys>; >> + vcc6-supply = <&vcc3v3_sys>; >> + vcc7-supply = <&vcc3v3_sys>; >> + >> + regulators { >> + vdd_cpu: DCDC_REG1 { >> + regulator-name = "vdd_cpu"; >> + regulator-min-microvolt = <500000>; >> + regulator-max-microvolt = <1500000>; >> + regulator-initial-mode = <0x1>; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-mode = <0x2>; >> + regulator-off-in-suspend; >> + regulator-suspend-microvolt = <950000>; >> + }; >> + }; >> + >> + vcc3v3_sys: DCDC_REG2 { >> + regulator-name = "vcc3v3_sys"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-initial-mode = <0x1>; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-mode = <0x2>; >> + regulator-on-in-suspend; >> + regulator-suspend-microvolt = <3300000>; >> + }; >> + }; >> + >> + vcc_ddr: DCDC_REG3 { >> + regulator-name = "vcc_ddr"; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-mode = <0x2>; >> + regulator-on-in-suspend; >> + }; >> + }; >> + >> + vdd_logic: DCDC_REG4 { >> + regulator-name = "vdd_logic"; >> + regulator-min-microvolt = <500000>; >> + regulator-max-microvolt = <1500000>; >> + regulator-initial-mode = <0x1>; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-mode = <0x2>; >> + regulator-off-in-suspend; >> + regulator-suspend-microvolt = <900000>; >> + }; >> + }; >> + >> + vdd0v9_sys: LDO_REG1 { >> + regulator-name = "vdd0v9_sys"; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <900000>; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + regulator-suspend-microvolt = <900000>; >> + }; >> + }; >> + >> + vcc_1v8: LDO_REG2 { >> + regulator-name = "vcc_1v8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + regulator-suspend-microvolt = <1800000>; >> + }; >> + }; >> + >> + vcc_3v3: SWITCH_REG { >> + regulator-name = "vcc_3v3"; >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + regulator-suspend-microvolt = <3300000>; >> + }; >> + }; >> + }; >> + }; >> + }; > > -- Best regards, Joseph Chen