From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E164F4743 for ; Wed, 14 Oct 2026 11:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791977181; cv=none; b=QgV2gwLIXSadCZBBLVmh2W2PNTC6HMLF0E8D5+C4xDRPYhySMukgy2C4nJ92sx+TDUprz/ifoQ2mz7ZMzGNq0cs6sgmNMPGanRkQOyx22xegoYY37erTD85ySe8V08agIbiPKuliSUXxyn+nldMw884QPYWUaYDlI15kM4R/SIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791977181; c=relaxed/simple; bh=zes7WRJqROE+3USwCgJF90m2S/ahuHQhT9F5Bstf5nk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NKmcgQzy076nYM3tPN0sgW+ht95syIMptIjhw0worigfeEJLEfitFtWIUcenR82bYT9WEvgPTfQDwNWmPJh0ghBmqRHHUKyTlYu+zB0PRSTUD1O1F9XITLLjW0cWO83ov/5rwdX6MTjuIJHpAZPpnpjAuRwiuHyDo1GGDoylMpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ke3jMVin; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EjhBKOaO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ke3jMVin"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EjhBKOaO" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69E7UL4N2873874 for ; Wed, 14 Oct 2026 11:26:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GJUhqTehC/TBaJjoHjfTPZQvGroVm27uWPQqsihFEok=; b=ke3jMVinGT84S5GK 20UqgRmt2tDmchJqsQG2m5ZRh/VV9oSZA4vXs1zIlToKlJ/a2kjmYM+FMqK0h7Ml U3ySSsp6VNVCNSqHcaJSqjVn8UNM3zAVWpV5VG80QEtD4kxZf9ICiWknzq6oSni4 SL867OrV3kt3QVkbWPTW+235m+h7gH3uyFQbAVis04iytCbHuJLkpGsurvEyBASV 9gwoH4eqmexFIoxVwoFVqwnvsPsD8t29LetYqZGbLjUEyDC9w6qZ7KOmC9OZQlrY R5Rms2uNgzHq1Gbmqc23Ox0ALGvr+353E7aucLx9wQ1PcrEQC5PFKBfvKqUa3mTH a/ai7Q== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h9yphj9hc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 11:26:18 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2e869e00005so11193135ad.2 for ; Wed, 14 Oct 2026 04:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791977178; x=1792581978; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GJUhqTehC/TBaJjoHjfTPZQvGroVm27uWPQqsihFEok=; b=EjhBKOaONc9N63CooXoaFm0ZU/0uai0KGm+zVK/MCAVegsXlhv9KiIQPkjVSp0rl9i DiYYkyMYf/1B5CmiMwU4CV3a4kb4M/Bmw9m2qNgWdOfsIRqRtfgdIiXGgVXhLu+mLgAp ATIS8tW5VL0SVti5nzbK421TzIJnUI1AG6e7IzZ6LJ78z2nKuD2QTI0l3oxG4HqvcdoP jmsauXeczm4llxGjFYS5CPl4r7f6mueZEHposjaBNcADOazqJTGAFTxQdw6ur8W95kHW TW82Cc4CM+oMkVI6jb2Mjts78n2pfGFN2CDogrXvhU5NeJuyimamoqcLhV43DKaISx5w +XBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791977178; x=1792581978; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GJUhqTehC/TBaJjoHjfTPZQvGroVm27uWPQqsihFEok=; b=C9V3TLwoT9SdXgpJqYvobQ29Ue/BLs6L8vC45BUTfwiVAIu8GMGzO2zxpiApGzkaoT Fd5VrTFWOAQNyBk5reJLBiHiLHWoYsR3BDCumjqNEu7txC2MOyZkr+YpwzAKBt/a0Q03 1fQ3jZqe0efd/4BqQ1eVuXivFsHC/u/ytpXZVbz8iKDA3eet96MRONy0GPMFGnV3WYZ+ HW5q2YgBe2UjYe5CUmWyFJh3dXj+GDM6+nhkU+EOqIF2kTp+yoDkJWw0+28biM2OiK/w sECK07tsG2Jv9TGx5igEe+XrbFRDVqHqxoekW1AFAPnvyG9RMJDYds8nUx0ZbjPtY5dr 8//w== X-Forwarded-Encrypted: i=1; AKwUvBxvGDkQKAI3x0w3NukWfXhy2vKfqLjhy4i2oQKoTbWUYm9gl6Njvrx2KRlPewE84uT/972wDDYmKgfKMv0=@vger.kernel.org X-Gm-Message-State: AFq9FYKNfcAdDA2Fb30ChvDXol1yMwBvc1zHj9Diw1O9YZaNK259LFMZ 1mlQe8aI0I4Z5+dRkSDUiU7oGPa3KUzsFrADJNoGMMGdykhAiuoSXph9T7fqqXMMJ+sEPgC8brL 1LTkkiNy/2UkUzyruB5+q6+3FWGUhr0asdA36riuh4YRa2nRmTWVcNbCbR0d7YA5lvdw= X-Gm-Gg: AYBFou3Et93bIgdHgokDPc8bxbIvQFzcCkjGmJVm5ZC7/2W+ZQbVvUESWzM0YqWPWDi 3bzdhRI3StDd5wmMCNMiasoVZJJSdYLfOd5TeQUeeiA1MfGzpZCwJhgyEwbfJlhGX4ozpt/tiIj WUZlwpd82eHfPYxFkp+30FHLmJlYRyJpuoSoDpTRXOVpnCG4t8gbbZs+V/nTKfu+UtoYeLsgKNr 92LyMfBM24v7khNGIj6ykwI39vDOqWJtfdNxXwAXxq3Q0gEwFh5323Anr2Yk8spXF1BmRSGARFt DkJGb5hNy7zijSqXKhIvaoJJmV+ZiF3ZgtSTLdU6P0yejh7GpPDdIirLj4me4bUngQqxkFtyEfO xMDZf0J2WdNDyHvAOrZMaaw8W2OdB X-Received: by 2002:a17:902:dac6:b0:2dd:c100:4253 with SMTP id d9443c01a7336-2e842e061d7mr134166795ad.55.1791977177766; Wed, 14 Oct 2026 04:26:17 -0700 (PDT) X-Received: by 2002:a17:902:dac6:b0:2dd:c100:4253 with SMTP id d9443c01a7336-2e842e061d7mr134166495ad.55.1791977177190; Wed, 14 Oct 2026 04:26:17 -0700 (PDT) Received: from [10.217.219.145] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8419ff572sm67497455ad.2.2026.10.14.04.26.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 04:26:16 -0700 (PDT) Message-ID: Date: Wed, 14 Oct 2026 16:55:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: dwc3: host: Mark dwc->xhci as null if xhci probe fails To: Greg Kroah-Hartman Cc: Thinh Nguyen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261014105711.1708244-1-prashanth.k@oss.qualcomm.com> <2026101452-wow-scarecrow-c7d8@gregkh> Content-Language: en-US From: Prashanth K In-Reply-To: <2026101452-wow-scarecrow-c7d8@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 4HRehfT1oYPl_Q92vqoMkNqwwkaFuurv X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA0NSBTYWx0ZWRfX6GZ12kvkj5s0 7310MFqmGt/6AEWpYyvtrgetVvLFHBNewMjNrEmsnQCXmfqeTHCK8Op/vD+f9u1x37ufgFeU1Eq zJ0ctte1mH4tYC8CUtpJSs9Ez47OJAY= X-Proofpoint-ORIG-GUID: 4HRehfT1oYPl_Q92vqoMkNqwwkaFuurv X-Authority-Analysis: v=2.4 cv=Uv72pOwB c=1 sm=1 tr=0 ts=6acf66da cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=faojglw4N2pyK_-Dy4YA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA0NSBTYWx0ZWRfX3OUijL08JWuE g5i9Gwx0QE3Ps6lWmCe3RwEnFnsZ/VDyNbxjCNiOICEu29yjk4gnD7KJOkFzyhFwnVVjrxDXWXi JiIr/OPVRrSn7u+xe3OzMjRGCNFKQmnGRqH+jwLOa3mWo0I70ffknT/QXSiWmMn6Gzvbz/F0WGV jGLTFq5QvFAflvoWSfUHfRXHtQHjlTu7rP+kxuoEB9bp8/ZRwr5JG9BQ4Vq8u+KuJhaNzvSFMiO tAnmBBi7v070I0m0cwqDAnzY5InXlW1R6NRuvJc+DIMX6JpvAhrQSxGdUCH4Xfm7qNxXsVNbC/g SxyOwc8ThZyFJQ1pobHde7IXkkWWI3/QBsWJxlj2q+TlIHAaZKey568tnk7aTTsJV+b9nyXg2u+ F4Esv0lgA4PMWbRqAJZvlFSZm8RLBe8XBB1cOwOnpqYMm71LdQuJFSXQ2rdfE4DThUPdMEmZoom nX/SlmXJEJxzYPR9cPA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140045 On 10/14/2026 4:47 PM, Greg Kroah-Hartman wrote: > On Wed, Oct 14, 2026 at 04:27:11PM +0530, Prashanth K wrote: >> Currently dwc->xhci is not cleared when xhci_plat_probe fails, >> leading to null pointer dereference in dwc3_qcom_read_usb2_speed. > > Why would that happen? What causes it and requires it? > >> Mark the xhci pointer as NULL to prevent this. >> >> Signed-off-by: Prashanth K > > What commit id does this fix? > How was it tested? > > thanks, > > greg k-h This might not fix the issue, because it doesn't take the 'err' path, just realized that platform_device_add() doesn't return error value if the device probe fails. The crash happens because xhci_halt failed (not sure what caused it), thats a functional failure from USB, but later the device crashed while trying to perform system suspend. Unable to handle kernel NULL pointer dereference at virtual address 0000000000000058 Call trace: dwc3_qcom_pm_suspend dpm_run_callback device_suspend dpm_suspend dpm_suspend_start suspend_devices_and_enter pm_suspend Sorry for the spam, Prashanth K