From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5466334D395 for ; Fri, 13 Feb 2026 09:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975645; cv=none; b=DoEu3rmQFF8Dv0ubOOEoa4dxQszqlZtTVa2itGRNE9vn7RZ+Tz+INsXO0+3HBGTj+kwC3cv7ZpyoF01lWOxN0+wPNh7ZEhp31vdo3fOVGj1CrcC4jSuQOIvzJ9RB3jSQxjETenYjlzeFAF3q6I6qvN925EzOSlOrdwzmahClxzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975645; c=relaxed/simple; bh=U7P3olTVkeLfckuqtGg3Ez5sD1mEL8bWEzzRb2X9380=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uaEc1zGqmTHrOFxcpyFNvGHHVwiVhVv3vliEozh1WK/yTtPjTNBSYTHGt+ESsV/F5lpmINVXcpd4PenB2/9Ao/SyPSOV3FGxukNBCwcQvRO8XO78wFQmRkO5tq9Jbz0b/8vp3lUyouBhjPd3CtgOgRpVN8kBktNiREjO5MgUS70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dwz+Ec1s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DU7bKN5t; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dwz+Ec1s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DU7bKN5t" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61D5479D1827717 for ; Fri, 13 Feb 2026 09:40:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z/lfOtspcFXBYF/xLcKmtVed+E+KcHC6N491qAFBLng=; b=Dwz+Ec1shTYtQITA ToovLj98oZarfPQUb5fZIrOu6V3eV3q2NlN//7lGN/Rs76wZPJ5GZ/KXp5urIXEa 5jqbHFfi1HSYmUGM8XelNyiYAY2BFzGcOKKlLY/GgP0GPUJ4q2TMENcCQ3p+hu1L OLNQVgnpsU7fkw6pC4fCmycWJb1sh8G3DuebOQFbU4UjV6Ceupvnvrpd+lCzd07Q cwzJP/fpmyQAwImGf3eVJtcXQkRge7OhWiXLPLqgnEwu+NH6EGkhdoWxqwBKrs0Z FLQmtk6+Piu2FrbL/dAsxTleHSE6jwQL0EeJmLfAYmBWKAVINU6/M6bGk7CneC/K jc216A== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9wg0102b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 09:40:43 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c6e1dab2328so2227901a12.0 for ; Fri, 13 Feb 2026 01:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770975643; x=1771580443; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z/lfOtspcFXBYF/xLcKmtVed+E+KcHC6N491qAFBLng=; b=DU7bKN5tcErWUevkl3U1Mh3dK5QCR9nWFB858M4Tlvd1YWkgxV8HU/rjouUa2ykjsP vOOkzHkq0djzqeehwh0DkDEwiOoaIldzggnnJEjManTEzd/km8bJiv4YKeNXP8H5NFqg QFZVUJuZxAYDL0TJeTPgB4vobAOu2fKNYytbqICTt5exyZiPsSSpu7p9zDj9eNoGGXcj G/CIREOYAPpp++dG49URty3OMb2kme0Tf4hKBhCbt3avPjwFGt9f48nP3GamgiO7/StY lQT9zqFEHxX0rZEQvlwBdXdmtxAH6MWhs3kF+oe915lDK3GUxKerwe1Xf+496eLcG3l9 9VXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770975643; x=1771580443; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z/lfOtspcFXBYF/xLcKmtVed+E+KcHC6N491qAFBLng=; b=MnSoT+gl5KDueI8IOZyfCyt8PpxZqRXjPctlE7FcNhtVu5ig8i0m69z1Ks37iACeSu dJKauCub+xsLSwI8Xv3ogKTMNDTUClIjf5tBPQF+3nynwbQmwYPjm01yTlypGYxXVr/u EXhm8EvTlvGZj45y7XLR47xa8YypvVrjK3M5sIUTePeNdRJqkTEryRomyi3rMvoj5JJq V36VYXpgyZCO4RNsy91QbbA6+jb7An4LBZ76wBodKEON3mD1RqknVabuD7O5s1FKO5Qi EO0zq0Qxfn5PbqdvWHnVdU3u3R1spWCRJwlFdZ/hIZDCU9G8W/AwUS2tuTEjy7zxcwoq Opgg== X-Forwarded-Encrypted: i=1; AJvYcCVA2CIaqxT6MOp8KO2xxV3wuG0hbycTm0OgqyqUPikxb9jGLSk6QzXTferKm6RmwmoOuZY4A+dNTaztGcE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8R7yIVgYvUF878blv/9p9N/zzMO1MFmYKBs9MpjXs2UeuHoci UC6diX5XYg5Nl+d2hhyJZGg7NkvlP+4kh+qUd9sQ2V03Oduv+zhmkjnpg/GAEpKXsZ+626LyPgf xN8d0D9gYyg3YTdPOFtnl6o04BIhAkx/I1OftdxEx0KBN6dzJMblGBMCp87hNl1/fr2U= X-Gm-Gg: AZuq6aJJ3Hh2D4JEB21RxSsFksckc0NajZL1Z7iHz+xUy3JeX2r4ux6gm76n6Mo/45u F8oJQbMHUNyijehQHO8JX6+OkqoYsvwDDrI7rL8FWqi6RD/sOE3sDVNqigNKAKReFtussZntYO4 gkHFtiBZrl5YHi6L85MiJQiGMja45txSoaiLok8EWo4oz8aMsQPuiAdtCJofuankZ4bZLUvtV4+ BI9Mvuvcviz8nlVP3ufD8QpFUbU0QMdM6bAzdKfCrcy0gAyw965O35du325u0PNjNtcaZQN26+g SndIGAwMzTmQKOBDCi517zt3hK1/ptBo4Rq0XO0tHczMOPjcongAr6oi1WuTxiTSlhKXBsl1Vom /qMLGx9/Na5lfDgiWC+nxZMQ4aBnUyHhr/PDGajsGP4mfP96T2Zkx6w== X-Received: by 2002:a05:6a21:a345:b0:38d:edd4:2fc6 with SMTP id adf61e73a8af0-3946c9252a8mr1267460637.70.1770975642897; Fri, 13 Feb 2026 01:40:42 -0800 (PST) X-Received: by 2002:a05:6a21:a345:b0:38d:edd4:2fc6 with SMTP id adf61e73a8af0-3946c9252a8mr1267441637.70.1770975642488; Fri, 13 Feb 2026 01:40:42 -0800 (PST) Received: from [10.0.0.3] ([106.222.229.190]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a4316fsm2530543b3a.23.2026.02.13.01.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 01:40:42 -0800 (PST) Message-ID: Date: Fri, 13 Feb 2026 15:10:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] media: iris: Fix dma_free_attrs() size in iris_hfi_queues_init() Content-Language: en-US To: Thomas Fourier Cc: stable@vger.kernel.org, Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260213091330.23431-2-fourier.thomas@gmail.com> From: Dikshita Agarwal In-Reply-To: <20260213091330.23431-2-fourier.thomas@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDA3NCBTYWx0ZWRfX5aucJNwF9euw Pd5Lw0tYDjjwElvlrLDWZiN6NAiFmCCYJksdGeD27p6YN5BNKR2H/WKigrjE5dJjlQc4TjkOd3m OdDaQkellgWF1OQJ+lnCtGU2pnCtl6vQH9+E1gVI/xiyiIJtte7S05ZT410yFXgLdOpN9aQopYI ZkGrDIsgnUCpkEyyxAb8IBJ+BK+M5r9MWWDZJ1TdqMq2W1u46bD8rglDmQphykEs0sx2nrGUju0 twYEHlOGsx+5K7dFVwOXe97oIFwSYr6zivlNfq53UNcveOBI3UA5Yhs9FKNaGLPpJBTZRToXWDE qt5LsoSOfRZtGt9aRM75axr3/Xt9kPprtm1jkvID1lpLJjeJUhG3jqmqeAmC8Zo2Rgb6fkMwfhC SbOWzbgR9UxrC8iiSs33QFjiH9j9J7vZVIZUNmLyVsKXaGR85sexUYBEdOb/gK4NRx3ZLGG6EbA ebq5chbkkeNZDh3nWjw== X-Proofpoint-ORIG-GUID: y1QUldm0PF-DaaQ5YRB8DEnw4xjjlZd0 X-Proofpoint-GUID: y1QUldm0PF-DaaQ5YRB8DEnw4xjjlZd0 X-Authority-Analysis: v=2.4 cv=bo5BxUai c=1 sm=1 tr=0 ts=698ef19b cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=VDDfqcjMpRzOalc4LhIaOQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=jz17cmUFc4N99GX7AB4A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130074 On 2/13/2026 2:43 PM, Thomas Fourier wrote: > The core->iface_q_table_vaddr buffer is alloc'd with size queue_size > but freed with sizeof(*q_tbl_hdr) which is different. > > Change the dma_free_attrs() size. > > Fixes: d7378f84e94e ("media: iris: introduce iris core state management with shared queues") > Cc: > Signed-off-by: Thomas Fourier > --- > drivers/media/platform/qcom/iris/iris_hfi_queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_queue.c b/drivers/media/platform/qcom/iris/iris_hfi_queue.c > index b3ed06297953..bf6db23b53e2 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_queue.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_queue.c > @@ -263,7 +263,7 @@ int iris_hfi_queues_init(struct iris_core *core) > GFP_KERNEL, DMA_ATTR_WRITE_COMBINE); > if (!core->sfr_vaddr) { > dev_err(core->dev, "sfr alloc and map failed\n"); > - dma_free_attrs(core->dev, sizeof(*q_tbl_hdr), core->iface_q_table_vaddr, > + dma_free_attrs(core->dev, queue_size, core->iface_q_table_vaddr, > core->iface_q_table_daddr, DMA_ATTR_WRITE_COMBINE); > return -ENOMEM; > } Reviewed-by: Dikshita Agarwal Thanks, Dikshita