From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B70A3C1986 for ; Wed, 20 May 2026 22:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315726; cv=none; b=tKHNdkJdR3Gbxh7hDMw9BEuYf7/ysMCE5/J62uxEmBM2xMcxoWqFL4rBsLOttouW/BUWXWnW65/OQAteN0OnQPLvHjkrqXw2Epsr/3Md6CS6Ab7K+Hc7+krYUgKWSFhzWx56nr86J7RVd+VFU85d9nf1RmST7FQFpF98Dh74m/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315726; c=relaxed/simple; bh=OWZLv3RcZNMXBK++VDzgdX5Eo6g4iZLM958nD4m3nTc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ezwJZvaaGSINK8TAvKwa5AXOiNxvRF/CUfzxa2iXD2J0/QWBNS9/Z6cCQUkV71XjZx+HEisbcuU6YESWFucmrkI2/KTdJlB3EzLhAHaPPnB6HKu5wawjUx0MYbJWVKpv/t6sZcvMhan0P9DMTLWKNmX4ZkEY1hVdn9N2LSdUm28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ISU1+I4k; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q7tJUscg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ISU1+I4k"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q7tJUscg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779315724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JxMX/pzMUOtdSR/DFO8X8z+nr68xKXZK5hfRbiRHySU=; b=ISU1+I4ktR8e07pgIzWHS0Xb5knafZGInWbw8q+mvlvU/BTZOk8DTHjojZ2qFD2NMyvndE VqzFuGYUxX2IYlLY9St7c5Rs418eT2PE4HmH78MFVaCmkyUESvnQTrB6K4Z1csjgUdUSMi hUm6Oywi0rFkQuIGF//DA56xzgZ5qIk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-n5C57hbjPfuVoCZ1VZ4sqQ-1; Wed, 20 May 2026 18:22:02 -0400 X-MC-Unique: n5C57hbjPfuVoCZ1VZ4sqQ-1 X-Mimecast-MFC-AGG-ID: n5C57hbjPfuVoCZ1VZ4sqQ_1779315722 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-45dbbbf8d57so7163286f8f.3 for ; Wed, 20 May 2026 15:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779315721; x=1779920521; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JxMX/pzMUOtdSR/DFO8X8z+nr68xKXZK5hfRbiRHySU=; b=Q7tJUscg0KuxTTWquEnim3nenh2eMw+IsVw3Klb03St2gZdB72VosPfZeZOAGFVdPZ Po6w3UYOHRtGvieoa1m6zgT8eUlSiGWzAsPTeFDcOie6stjGCyPTlQ4HGG0t9G5UqYoO x0AvFPe3KtuxhnW0Gi2aSxIFs4+Y0moGZ4Qul8KkBaesP+JpX+7km0HO/nOd76+aUEvZ xv9Lx9vK3NSR1N0ua2rsPoteV2yQgpQaFpHgBy/Xtbcn2AbyLipLdUM2wGBZq76fkCLb 4wYDQDd3XyUVyXQ6ftZ1kKeX9De6ECGif7UrwpocHMEFdrM9UtKit5l00vp+/w5ta/jQ yf4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779315721; x=1779920521; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JxMX/pzMUOtdSR/DFO8X8z+nr68xKXZK5hfRbiRHySU=; b=tK1J2N4yCowX0uLMJdQ+wLJhN2IrLtbmnQB9mTfM8sj2uVIOi4zDWwc7ZNe6BWOqGg KnHO8A8FOXjbh5ixGtQRCcCPzhGtVTBqM2rtGcbSkgdAsOByeVK2UXUXKGbkF93HZ1IP 28qYUwOUxLo6R4SRBGmRiyZr0vm3ftpgO8174ToxhyeEuff/1otVB2e9L0OVdcAQz4pG dcrS6aPDvtO1gIbQAv5o5Jwo2PEPB+/cZVkz8lwW30cb3NjOo2B2mfKsvA8TVy/TEaFS gwsGjHcs8gqotxgRosHaU/TQ2cwgpQQ9sqb8LmvhTzk7+qIqzarUvpay5DLsNWB/Y6qA 1u/g== X-Gm-Message-State: AOJu0YwwNxzoaX1mC5i0OhVQqXqy3frRyo/ACnNVzIZBcpXcIfoUvv/8 m4IfT9DR80wLgd4TZc2neWRqZa8JC69qvDN4PK55onk5lXZ4yuUAPX7knHEOPixYX6xxXI2h21O SCAnDz5g0Y1k1N07iUR8PN6SD+VpEaN/FFF27Boz1iKwgC4LVj+PmooIq5UROiyZGj1D3dQfwNI t+o5rf1pCl6Z/S/MYCv/tdMTG5pYsZBJhx/rjMpnO46ks= X-Gm-Gg: Acq92OEW/l36GEnmi/nCq91ZDSkXLp2t3pBEM8qmW7GzNdg6r/QuLodqdIcCA56q6+r fCWQ0C/n3nDAWlP8acYpVQlyn6QWFQkdzK7fQhk866BjrsuUIFUYNJwi33v7bW6Cya+qKx+XGw1 oIRhb/uhH/UES8SqEJrnvG/K3DCfbMhrN0koRDBBDV+E+QaW+uuXGkga8nE6QLYKqkKQi0F4q7l RJqUZiETCeQNgQ4zfnjr5+O20nNpZU8+/PFqx3+gqgikB9h+4CIdrBdBI+55r5uwSKtbOryuwSq RJA5Ejm7oLkHq88N03qJv/N3NRjCexvv76hsnoyrdmH0nFSaNjZEHs2wzUamYKF3bZ3lRZIKOa0 79JjmaG7eZKoYxXbqGXXtN1uWtggl2Hl8eg6klcIoBdI= X-Received: by 2002:a05:6000:2f88:b0:45e:878b:6c36 with SMTP id ffacd0b85a97d-45ea3ce5a81mr251968f8f.35.1779315721384; Wed, 20 May 2026 15:22:01 -0700 (PDT) X-Received: by 2002:a05:6000:2f88:b0:45e:878b:6c36 with SMTP id ffacd0b85a97d-45ea3ce5a81mr251868f8f.35.1779315720651; Wed, 20 May 2026 15:22:00 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a178adsm60809630f8f.18.2026.05.20.15.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 15:22:00 -0700 (PDT) Date: Wed, 20 May 2026 18:21:55 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v8 17/37] mm: use __GFP_ZERO in alloc_anon_folio Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Convert alloc_anon_folio() to pass __GFP_ZERO instead of zeroing at the callsite. post_alloc_hook uses the fault address passed through vma_alloc_folio for cache-friendly zeroing. Note: with __GFP_ZERO, the folio is zeroed before mem_cgroup_charge(). If the charge fails, the zeroing work is wasted. Previously zeroing was done after a successful charge. This is inherent to moving zeroing into the allocator. Signed-off-by: Michael S. Tsirkin Reviewed-by: Gregory Price Assisted-by: Claude:claude-opus-4-6 --- mm/memory.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index adc228fe3578..895ac72121fe 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5249,7 +5249,7 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) goto fallback; /* Try allocating the highest of the remaining orders. */ - gfp = vma_thp_gfp_mask(vma); + gfp = vma_thp_gfp_mask(vma) | __GFP_ZERO; while (orders) { folio = vma_alloc_folio(gfp, order, vma, vmf->address); if (folio) { @@ -5259,15 +5259,6 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) goto next; } folio_throttle_swaprate(folio, gfp); - /* - * When a folio is not zeroed during allocation - * (__GFP_ZERO not used) or user folios require special - * handling, folio_zero_user() is used to make sure - * that the page corresponding to the faulting address - * will be hot in the cache after zeroing. - */ - if (user_alloc_needs_zeroing()) - folio_zero_user(folio, vmf->address); return folio; } next: -- MST