mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: David Laight <David.Laight@ACULAB.COM>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: add -MP to CFLAGS
Date: Mon, 30 Oct 2023 10:22:51 +0000	[thread overview]
Message-ID: <e1cd904dc8973733fbb836bdabb28e2f13d8a5ab.camel@infradead.org> (raw)
In-Reply-To: <aae76a24900444b7a812a21815a0b212@AcuMS.aculab.com>

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Mon, 2023-10-30 at 10:08 +0000, David Laight wrote:
> From: David Woodhouse
> > Sent: 30 October 2023 09:46
> > 
> > On Sun, 2023-10-29 at 21:13 +0000, David Laight wrote:
> > > From: David Woodhouse
> > > > Sent: 28 October 2023 20:35
> > > > 
> > > > Using -MD without -MP causes build failures when a header file is deleted
> > > > or moved. With -MP, the compiler will emit phony targets for the header
> > > > files it lists as dependencies, and the Makefiles won't refuse to attempt
> > > > to rebuild a C unit which no longer includes the deleted header.
> > > 
> > > Won't a phony target stop a header being built if there is
> > > an actual rule to build it?
> > 
> > It probably would have taken you about the same time to find the answer
> > for yourself, as it took to write that email. Why don't you try it?
> 
> I was sure that just adding
> 
> foo.h:
> 
> would generate a 'no rules to build' error.
> Maybe that was BSD make or SYS-V make.
> 
> But calling the 'phony' is probably wrong.
> PHONY has a very specific meaning to make - and these aren't PHONY.

I recommend filing a bug against the GCC documentation then.

https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html#index-MP



[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]

  reply	other threads:[~2023-10-30 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-28 19:34 David Woodhouse
2023-10-29 21:13 ` David Laight
2023-10-30  9:45   ` David Woodhouse
2023-10-30 10:08     ` David Laight
2023-10-30 10:22       ` David Woodhouse [this message]
2023-11-30  1:44 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1cd904dc8973733fbb836bdabb28e2f13d8a5ab.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=David.Laight@ACULAB.COM \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®