mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org,
	"Paul E . McKenney" <paulmck@kernel.org>,
	RCU <rcu@vger.kernel.org>
Subject: Re: [PATCH v1 5/6] scftorture: Count single_rpc offline failures in statistics output
Date: Sat, 18 Jul 2026 13:17:27 -0400	[thread overview]
Message-ID: <e1d02f43-2e3b-4e27-993a-ed2cd1672356@nvidia.com> (raw)
In-Reply-To: <20260718171539.3781595-6-joelagnelf@nvidia.com>

Some reason my scripting missed rcu list for these last 2 patches. But they
are on the lkml list :) sorry.

Adding back rcu@.

On 7/18/2026 1:15 PM, Joel Fernandes wrote:
> scf_torture_stats_print() aggregates each invoker thread's counters
> into a local scf_statistics structure before printing, but the
> n_single_rpc_ofl field is missing from the aggregation loop.  As a
> result, the "single_rpc_ofl" value printed in the statistics line is
> always zero, even when smp_call_function_single() invocations for the
> RPC test have failed due to offline CPUs and been counted by the
> invoker threads.
> 
> Add the missing accumulation so that the printed value reflects the
> actual counts.
> 
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
> ---
>  kernel/scftorture.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/scftorture.c b/kernel/scftorture.c
> index 327c315f411c..ffd6c83732ee 100644
> --- a/kernel/scftorture.c
> +++ b/kernel/scftorture.c
> @@ -193,6 +193,7 @@ static void scf_torture_stats_print(void)
>  		scfs.n_single += scf_stats_p[i].n_single;
>  		scfs.n_single_ofl += scf_stats_p[i].n_single_ofl;
>  		scfs.n_single_rpc += scf_stats_p[i].n_single_rpc;
> +		scfs.n_single_rpc_ofl += scf_stats_p[i].n_single_rpc_ofl;
>  		scfs.n_single_wait += scf_stats_p[i].n_single_wait;
>  		scfs.n_single_wait_ofl += scf_stats_p[i].n_single_wait_ofl;
>  		scfs.n_many += scf_stats_p[i].n_many;


  reply	other threads:[~2026-07-18 17:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 17:15 [PATCH v1 0/6] RCU and torture fixes and cleanups Joel Fernandes
2026-07-18 17:15 ` [PATCH v1 1/6] rcu: Remove unused expedited_need_qs field from rcu_state Joel Fernandes
2026-07-18 17:15 ` [PATCH v1 2/6] rcu: Remove unused rdp parameter from trace_rcu_this_gp() Joel Fernandes
2026-07-18 17:15 ` [PATCH v1 3/6] rcu: Remove unused func parameter from callback-enqueue functions Joel Fernandes
2026-07-18 17:15 ` [PATCH v1 4/6] torture: Don't leak shuffle_tmp_mask when shuffler kthread fails to start Joel Fernandes
2026-07-18 17:15 ` [PATCH v1 5/6] scftorture: Count single_rpc offline failures in statistics output Joel Fernandes
2026-07-18 17:17   ` Joel Fernandes [this message]
2026-07-18 17:15 ` [PATCH v1 6/6] scftorture: Make invoker threads actually wait for all threads to start Joel Fernandes
2026-07-18 17:17   ` Joel Fernandes
2026-07-20 15:52 ` [PATCH v1 0/6] RCU and torture fixes and cleanups Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1d02f43-2e3b-4e27-993a-ed2cd1672356@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®