From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1097C2D0E4 for ; Tue, 24 Nov 2020 03:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B6F02071E for ; Tue, 24 Nov 2020 03:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgKXDJm (ORCPT ); Mon, 23 Nov 2020 22:09:42 -0500 Received: from esa1.mentor.iphmx.com ([68.232.129.153]:11134 "EHLO esa1.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725827AbgKXDJl (ORCPT ); Mon, 23 Nov 2020 22:09:41 -0500 X-Greylist: delayed 428 seconds by postgrey-1.27 at vger.kernel.org; Mon, 23 Nov 2020 22:09:41 EST IronPort-SDR: nkAlleBpApnvRKyqxYvHVoR68ZHGhEabUl8bZCNRWBwHYYQQezjC2ZU1mFl/TqgsmflfddrFKV nf9/8ywcokMxGM6sumMBhxmmCypXCjFQhnpQz/BY2883GmUFXLxnsDp49wt3qwpH0FGG8anqWx yW0eaWRsd6jybAEqMfUQzLNQ3CrOputlL/+FEWkso8PDUA1KZgEsS7liQM4erOt433Jd0klpsY d+Vi52V4jq7pc+W0AvvvSwvzihcVg7arW8PQYh1fsMVfnYeUGu4J73Z7i8ybJ4+IL6zUC/ziIp E2E= X-IronPort-AV: E=Sophos;i="5.78,364,1599552000"; d="scan'208";a="57706121" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 23 Nov 2020 19:02:33 -0800 IronPort-SDR: 3IFsGI7h/kVXqVPpRLsuCYmoJbLtJaCOmMjOnJnk6UVkplnmfBWZHDSALgKEWCpX5ixB06AULG Rr8//gZaAoD6DzQbtTS9H8wrFJvm1qap89gB1Xw8yPr19zqXij2CKP6onK1nGORov+77mWGsZJ Pw4pt0i2jvMAHic/IWraTYNMOegpx9Mf89wpRzfHPI4/CHjFnkfPDy982C4+fGAnBbBFqCm5s+ ETvzEUr5jLNLDVwxdhlQdAIPUvMsjUjxrruwesDSUzfN/EbrWtFWg3cfUl84HNoOqQD46Xn+zO pTY= Subject: Re: [Regression]: Commit 74d905d2 breaks the touchpad and touchscreen of Google Chromebook "samus" To: Andre Muller , Nick Dyer CC: Dmitry Torokhov , "George G. Davis" , References: <735253bd-5500-2b8d-c98d-99bddb0617ce@web.de> <69305cdf-1ba7-a51a-302c-9b1b83e788aa@web.de> From: "Wang, Jiada" Message-ID: Date: Tue, 24 Nov 2020 12:02:28 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <69305cdf-1ba7-a51a-302c-9b1b83e788aa@web.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SVR-ORW-MBX-05.mgc.mentorg.com (147.34.90.205) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andre Thanks for the log, can you add more debug information like following diff, and get full log? diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 98f17fa3a892..60bccd5c42f6 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1298,21 +1298,29 @@ static int mxt_check_retrigen(struct mxt_data *data) data->use_retrigen_workaround = false; irqd = irq_get_irq_data(data->irq); - if (!irqd) + if (!irqd) { + dev_warn(&client->dev, "unable to get IRQ data\n"); return -EINVAL; + } - if (irqd_is_level_type(irqd)) + if (irqd_is_level_type(irqd)) { + dev_warn(&client->dev, "IRQ is level type\n"); return 0; + } if (data->T18_address) { error = __mxt_read_reg(client, data->T18_address + MXT_COMMS_CTRL, 1, &val); - if (error) + if (error) { + dev_warn(&client->dev, "failed to read reg: MXT_COMMS_CTRL\n"); return error; + } - if (val & MXT_COMMS_RETRIGEN) + if (val & MXT_COMMS_RETRIGEN) { + dev_warn(&client->dev, "RETRIGEN feature available\n"); return 0; + } } dev_warn(&client->dev, "Enabling RETRIGEN workaround\n"); Thanks, Jiada On 2020/11/05 23:23, Andre Muller wrote: > On 05/11/2020 14.25, Wang, Jiada wrote: >> Hi Andre >> >> Thanks for your report, >> could you also please post the log when with this commit reverted? >> >> Thanks, >> Jiada > > Shure! > The full dmesg with the revert is attached. > > The atmel_mxt bits are: > > [    0.195879] atmel_mxt_ts i2c-ATML0000:01: Family: 164 Variant: 17 > Firmware V1.0.AA Objects: 32 > [    0.211712] atmel_mxt_ts i2c-ATML0000:01: Direct firmware load for > maxtouch.cfg failed with error -2 > [    0.212986] atmel_mxt_ts i2c-ATML0000:01: Touchscreen size X960Y540 > [    0.213025] input: Atmel maXTouch Touchpad as > /devices/pci0000:00/INT3432:00/i2c-0/i2c-ATML0000:01/input/input4 > [    0.219208] atmel_mxt_ts i2c-ATML0001:01: Family: 164 Variant: 13 > Firmware V1.0.AA Objects: 41 > [    0.238825] atmel_mxt_ts i2c-ATML0001:01: Direct firmware load for > maxtouch.cfg failed with error -2 > [    0.238949] intel_rapl_common: Found RAPL domain package > [    0.238955] intel_rapl_common: Found RAPL domain core > [    0.238961] intel_rapl_common: Found RAPL domain uncore > [    0.238966] intel_rapl_common: Found RAPL domain dram > [    0.240121] atmel_mxt_ts i2c-ATML0001:01: Touchscreen size X2559Y1699 > [    0.240157] input: Atmel maXTouch Touchscreen as > /devices/pci0000:00/INT3433:00/i2c-1/i2c-ATML0001:01/input/input5 > > Regards, > Andre > >> >> On 2020/11/04 17:13, Andre wrote: >>> Hi, >>> >>> commit 74d905d2: Input: atmel_mxt_ts - only read messages in >>> mxt_acquire_irq() when necessary >>> >>> breaks the touchpad and touchscreen of the 2015 Chromebook Pixel >>> "Samus". >>> >>> Reverting the commit from the current git tree gets them to work again. >>> >>> I am not at all shure what info to include, but I will happily provide >>> it on request. >>> >>> The dmesgs of a boot with commit 74d905d2 show "Enabling RETRIGEN >>> workaround", but otherwise looks the same as a boot without. >>> >>> Here is the relevant bit (with 74d905d2): >>> >>> atmel_mxt_ts i2c-ATML0000:01: Family: 164 Variant: 17 Firmware V1.0.AA >>> Objects: 32 >>> atmel_mxt_ts i2c-ATML0000:01: Enabling RETRIGEN workaround >>> atmel_mxt_ts i2c-ATML0000:01: Direct firmware load for maxtouch.cfg >>> failed with error -2 >>> atmel_mxt_ts i2c-ATML0000:01: Touchscreen size X960Y540 >>> input: Atmel maXTouch Touchpad as >>> /devices/pci0000:00/INT3432:00/i2c-0/i2c-ATML0000:01/input/input4 >>> atmel_mxt_ts i2c-ATML0001:01: Family: 164 Variant: 13 Firmware V1.0.AA >>> Objects: 41 >>> atmel_mxt_ts i2c-ATML0001:01: Enabling RETRIGEN workaround >>> atmel_mxt_ts i2c-ATML0001:01: Direct firmware load for maxtouch.cfg >>> failed with error -2 >>> >>> Thank you, >>> Andre Müller >