From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbdLISF4 (ORCPT ); Sat, 9 Dec 2017 13:05:56 -0500 Received: from mout.web.de ([212.227.15.3]:63192 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdLISFx (ORCPT ); Sat, 9 Dec 2017 13:05:53 -0500 Subject: [PATCH 2/3] serial: ioc3: Improve size determinations in ioc3uart_probe() From: SF Markus Elfring To: linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Pat Gefre Cc: LKML , kernel-janitors@vger.kernel.org References: <962f1172-3f27-c6b5-653f-c09f2e8fe431@users.sourceforge.net> Message-ID: Date: Sat, 9 Dec 2017 19:05:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <962f1172-3f27-c6b5-653f-c09f2e8fe431@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2h8v6X2VGvt1eF/ujcU4R6qkZSJo5/hKzaEzdlP28LOheTpLa2g dPIELobFkIYW5wRua3T4CXIdxh+2Ymx+EiYh3EzRm1/UfwGafw0183shULBrMpNMc81N4LV HA0KDUqDn6hCVp4LhAPlOv4oWKrdGlnC0ANjwWzBm6V6NYY49ztahQs7FmMMO6R5AbRFMcb XrX3A7daB38jVQW+qf+Jw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GxD9ssoHA44=:yQbZ0107oeb7uWVH3x0QH6 A6f9DRtp+kzRbUjKvC7N7uUcQU9p8BTVT7BJXuKjkD9CnFThGpv6QuCpUbffKTb6Q4n6dwYYO v4XtAXlZFJaRDOy/q+ZEpzGmuxSCw0xdz33105QzF9E3C7a0SEu2Ru60RM07Y0QDgBKCRTpN1 KgXKRwS70gRauvWIKN86tHp1F0vbDFb2i17WxKDmIakNzKl24o9zFPsnXOMf9qNK8D+iH6rDs 0P7+3KFVxm0cnTkhGGbz9PWFPYxsayN9be55vHay80LBoUEewgOCGriLJdz1Uj1yO/3Her+qX 5iLmSFaUO0EhgekbK3XsCKw5knhQ5QNnbS8d+/JstFlINoyhgsxcrXWbqlsh5ScoH7sXvHRQK 7iC08FGSjkvvtKQyKzzC53nAc8MFZ7ufD0wa4zGT+fTxaeDA+BvlTdDy+6CqSUe+CCGgCrU9A 8WIddu6gtXemzrBV/JxeeJeYS3GdBUQoTv7HrBLOoD9YO8o7n9cgrWufcef0FiwhGXjDjo9MV PPrunNF/ZTWTU8Kw+1PsxGXYqcQWq4xRgiCh4HFIID4G3FBoLr57WVK/+0fKRvO6pVVw45foi 7ELnuOqNAAVYBO0kqtR8YshSFHwUDD5BYV+WJGgV7ZeKxYGEkTcmRqf62dwhInsosBnKVn33j 7IK6xNP2iEk6CGwI3IkuFK+lBT1CDeTw8TtMD4o2K6fZTVhYOXqSQrpHbuEp0pR94iIozx3ib nFq85hG/xoQifbi2UXbQzZZGg6oFOezLBnZTm+W7KtGkkonPt9Ic5KRIvQlvXExMmtzjA54hs Iul6bCZYs1AoLn2QyRniwByZY97ttTOBZt80OquRblsDYdal8w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 9 Dec 2017 18:38:13 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ioc3_serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/ioc3_serial.c b/drivers/tty/serial/ioc3_serial.c index 0007c2d65028..d211bb1407d3 100644 --- a/drivers/tty/serial/ioc3_serial.c +++ b/drivers/tty/serial/ioc3_serial.c @@ -2016,7 +2016,7 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd) DPRINT_CONFIG(("%s (0x%p, 0x%p)\n", __func__, is, idd)); - card_ptr = kzalloc(sizeof(struct ioc3_card), GFP_KERNEL); + card_ptr = kzalloc(sizeof(*card_ptr), GFP_KERNEL); if (!card_ptr) return -ENOMEM; @@ -2034,7 +2034,7 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd) /* Create port structures for each port */ for (phys_port = 0; phys_port < PORTS_PER_CARD; phys_port++) { - port = kzalloc(sizeof(struct ioc3_port), GFP_KERNEL); + port = kzalloc(sizeof(*port), GFP_KERNEL); if (!port) { ret = -ENOMEM; goto out4; -- 2.15.1