From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 724D744683F; Wed, 15 Jul 2026 12:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784117134; cv=none; b=YcV1Fy9p1JlQtudzkTNSIaScNhgVk1seOI9lnsQ0Os2DxjQtpuXkRrX/uUCOMsXSFJpf0fUqgyA7O+T2/621aobgkLldxxDqri3uJjUx7G4f5i7SnCWL9JD/Ryxq62l5QnVhZaakjNSG1TMstyjgEZtlI5g6QEqGi4tumZZl5dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784117134; c=relaxed/simple; bh=/o9HHiIx25qtbVnRGNIjpvHThwdiY52KohOEBMTOyh4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=UxN/Q/8EsaFxeG5D01qibzYW8C/NawD81et/xjGxYYLs8BtzHnbEQnYchzG0LG69dFl0o4qlRce/AjXevyBsMk5urSu03N8BlDQS9nh2LLaqWRYe2dXyfS54BPUZFJ2QDI7ws2iErp4E/UbcgXTGdeFgnCi9YTda04O8Xw4n3Xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KrL4Nu0Z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KrL4Nu0Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54B821F000E9; Wed, 15 Jul 2026 12:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784117130; bh=BHXExEiZmLjwi+6XKjqKp6tsYaAW/OyGLT7X7SWVf7k=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=KrL4Nu0Z8NJsmASVxgM1QYil+oSkPN2zPHyFGGp/jw+gtmdVNC5NRjYEW1YABieP3 LC87TOerR+2VweSx78st931kOY4SM1zXUxJQNjzZDIWykzYSuyX4z2EEnbew/qPyu8 lFf8u0O9JSw4jBfEkgKNqLlGRf3DgwKJiDo9G6xL/7cEmbthYS6fL+/ngISHuPM12u YPGLyzCI3xmAWTMdwZwq7oR1uyRbAtOCg8o6Bw2vR473YFOAp3PdW/tYoy9V88M2VS WgLLawbIFGEdRLqtQrsUG2MRkB5nPvIic46nMztm3WIoDpklHIdM1cgZyuevdJ3c7t dQ8bpPUSCU+8Q== Message-ID: Date: Wed, 15 Jul 2026 14:05:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: hverkuil+cisco@kernel.org Subject: Re: [PATCH v2 1/2] media: s2255: Rename CamelCase goto labels to snake_case To: Johan Hovold , Lei Huang Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Lei Huang References: <20260715092947.772768-1-huanglei814@163.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/07/2026 12:00, Johan Hovold wrote: > On Wed, Jul 15, 2026 at 05:29:46PM +0800, Lei Huang wrote: >> From: Lei Huang >> >> Rename the error-path goto labels in s2255_probe() from CamelCase to >> snake_case to comply with the Linux kernel coding style: >> >> errorBOARDINIT -> err_boardinit >> errorFWMARKER -> err_fwmarker >> errorREQFW -> err_reqfw >> errorFWDATA2 -> err_fwdata2 >> errorFWURB -> err_fwurb >> errorEP -> err_ep >> errorUDEV -> err_udev >> errorFWDATA1 -> err_fwdata1 >> >> No functional changes; all label definitions and goto references are >> updated consistently. >> >> Signed-off-by: Lei Huang > > This looks ok, but the fix should go before the cleanup (e.g. to > facilitate backporting). I'll just take the v1 patch and Lei Huang can make a cleanup patch on top of that. It is nice to get rid of the camelCase labels. Regards, Hans > > Also, always include a changelog (in a coverletter) when updating a > series. > > Johan >