From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823AbeDECFi (ORCPT ); Wed, 4 Apr 2018 22:05:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60298 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbeDECFg (ORCPT ); Wed, 4 Apr 2018 22:05:36 -0400 Subject: Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name To: Jeff Mahoney , Andrew Morton Cc: LKML , reiserfs-devel@vger.kernel.org, Alexander Viro , Jan Kara , Frederic Weisbecker , Artem Bityutskiy , syzkaller-bugs@googlegroups.com, syzbot+6bd77b88c1977c03f584@syzkaller.appspotmail.com References: <20180404184517.9f2b91b856a56f71464f5f7f@linux-foundation.org> <5e9ea36a-6a6a-921c-81b3-bc623a9e125a@suse.com> From: Randy Dunlap Message-ID: Date: Wed, 4 Apr 2018 19:05:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <5e9ea36a-6a6a-921c-81b3-bc623a9e125a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2018 06:48 PM, Jeff Mahoney wrote: > On 4/4/18 9:45 PM, Andrew Morton wrote: >> On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> If the reiserfs mount option's journal name contains a '%' character, >>> it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), >>> saying: "Please remove unsupported %/ in format string." >>> That's OK until panic_on_warn is set, at which point it's dead, Jim. >>> >>> To placate this situation, check the journal name string for a '%' >>> character and return an error if one is found. Also print a warning >>> (one that won't panic the kernel) about the invalid journal name (e.g.): >>> >>> reiserfs: journal device name is invalid: %/file0 >>> >>> (In this example, the caller app specified the journal device name as >>> "%/file0".) >>> >> >> Well, that is a valid filename and we should support it... >> >> Isn't the bug in journal_init_dev()? OK, thanks. > Yep. That's exactly it. > > Acked-by: Jeff Mahoney > > Thanks, > > -Jeff > >> --- a/fs/reiserfs/journal.c~a >> +++ a/fs/reiserfs/journal.c >> @@ -2643,7 +2643,7 @@ static int journal_init_dev(struct super >> if (IS_ERR(journal->j_dev_bd)) { >> result = PTR_ERR(journal->j_dev_bd); >> journal->j_dev_bd = NULL; >> - reiserfs_warning(super, >> + reiserfs_warning(super, "sh-457", >> "journal_init_dev: Cannot open '%s': %i", >> jdev_name, result); >> return result; >> _ >> >> > > -- ~Randy