From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5B91ACECB for ; Tue, 28 Jan 2025 16:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738080450; cv=fail; b=ebQ9t1PezgA+C+FzxCcdOYmSLeCGJT1/DnlV+EIhuQV9n92kQBnb/6ntDlD8NIuuRKYzU3mhjaarG6dROmkMvTgkgrGT/mlP0IYEpLlptVvLuiQ0Alwb7hNMv/kn0Ek2HF1v0zbFY9uaWhJ+tvaGV5+118LFwQ+D2lkrKd9Mbn4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738080450; c=relaxed/simple; bh=WkOA3fgunE76GLcSKdQ7r2GhhIHX75QiR8Pa179nzEQ=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=PT8gm7NhJDpW+rLs9SCKa7of89Lisgo9mdaO9Lbejtu/fJZJzRWfvnciAqsL/niJKbPfLNWBIFZKch1kBXPFGcTIzT9euOhXZ+w1d8XW1bHm4AXLeenJV6z7Fu3qtV7HVtYnazjrkCRIOHvp9XopZSpjDvZJua43KDw7Yed0v5o= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=lTbBkuJN; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=u+RYgScb; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="lTbBkuJN"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="u+RYgScb" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50SG6S9o015508; Tue, 28 Jan 2025 16:07:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=BREXPqn38h5Teujyoa yKOBKoE2OG+6uc0A2tWg7X0aA=; b=lTbBkuJNOdBZl22wyO17JhALA8ST7kE4Rq 2K1ss5rP0vtxaYxHpVcD1bTrUF7N2mTuohWu0mOhpNFIe/4Kv2TD6G8Gp8zIzq1b LggH8kUa6kvFRdeRKHB83WmU5L1XPEQ9IVYV4lHFc3W9nC59z55IlcUO/N+ycW3b pw16oJTc6b1R/Z8T7QlTgmLTI0FYZxnY/ZiuTBo2RAk8sHVCmdVsqSS+W83JrbuM vznTvky4R7A/2t2mWmJ4mxDgg/zhbTHmnNGWl5iQG1y5PtrbH5N4bB36c0BQd4PC A7Fh4EA+8Qy+SN5gQB+0OjOjwTsitdy1oPI6y84i4X43UrWTOlxg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44f2ax00v8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jan 2025 16:07:18 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50SFAMrv021406; Tue, 28 Jan 2025 16:07:16 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2047.outbound.protection.outlook.com [104.47.70.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd8jnxg-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jan 2025 16:07:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FnPLa0ZiYBi5r1nH/hkZ0/s8dBOcsB7mbNn8n+MvRmc5r3vj8R9AJ6Cw6E4REXC8ccEXUgkzbeoeehXiKgTOUX0kMKWk32rgs+QG/qVzzz/h1LejHnWso9gdI2DgD7Dxrcm5uUmNyD3bnOIpnjXXKjdyNfbjYdkmxHA8SwsGEowjMw6tltBUf2imZh+Diwfu89vfWEBVteI5ISSU3qtqa4NaRjx9awi68bSJ6jF/jMeXUhOeby5cV0eXtwnl9opIrTaTJQUnT6yMIyUSh0Bep6b70Cvk2DayK94pALT+OQBoXzDdWiuo7H/k3cC8tTfzbt2ms6SPNK/K4RAFeNpk0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BREXPqn38h5TeujyoayKOBKoE2OG+6uc0A2tWg7X0aA=; b=TdsaiaGjo5dEy7w/AlvRAH5wzjOQuykcoZqtPPYLBHZ95BfBr1yipUN7z4ARfZK46Bvz0fq8IPYVXG+dimC9MXzK+EaKVx7DEuEAfUPhTqNm9qPe9+teihMt0Q29uPFr8zyhxfZJMgpzJL7RvPRGbcUVruPhNGuVUfEwIdWa0/bAw9jSOnLnh9/1JLp4biDEP8B0bBgl63ulqT8H5qBx+Eha/L+uv12PDP6GYbAWrjlYoQErUv3Htf/9JAHkBRM29S2GN51xWmGYLztuhcZzHKUHxwM+wV+58DEyzcsuRrJEGvwJxqMy5LEJWhgH1oEzshWa1f4WTB1i5PYPfR43Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BREXPqn38h5TeujyoayKOBKoE2OG+6uc0A2tWg7X0aA=; b=u+RYgScbwtzkTGfZ48ftY/WFV03fiEBigldBd1v9Nf194IymM68G4nqlSpLq4SR7HlMCEAUEu/DEqvGRhJVMkv2vXB2kTajyK9OB9cBA/fzd/B5eu/iD+nmKL7cQqIQCCGA4jGD6B/u6L74Uz5JgRVyaDWJ8cS9RyB+Ub92JpCs= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by IA0PR10MB7275.namprd10.prod.outlook.com (2603:10b6:208:3de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Tue, 28 Jan 2025 16:07:07 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8377.021; Tue, 28 Jan 2025 16:07:07 +0000 Date: Tue, 28 Jan 2025 16:07:00 +0000 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Andrew Morton , "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mm: further refactor commit_merge() Message-ID: References: <0bbb2efbdc2ac2af2f6d73679cbb0811544d0647.1737929364.git.lorenzo.stoakes@oracle.com> <09484ff8-1b0c-4101-a793-e869aa8a6eeb@suse.cz> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09484ff8-1b0c-4101-a793-e869aa8a6eeb@suse.cz> X-ClientProxiedBy: LO6P123CA0020.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::8) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|IA0PR10MB7275:EE_ X-MS-Office365-Filtering-Correlation-Id: 4348f0e9-7fc4-415e-da06-08dd3fb5d03d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?q1kJedSNuuE2Kr1Y3eZ4JdNaGJgcS096XeVspCKHFHU2wW9Zz0tywTaJ3nZE?= =?us-ascii?Q?o1iP8ktEHfsRvPlVQTTPpHwJo8PlfNxyqRMJ1Qh3ZOlTFIAhwY2YPQGF+F43?= =?us-ascii?Q?/5M2LDwdtVfbHs1z2xm0IpC7u1brM1igQUlLb2KWjBG8zWXXk6ICH9YsJxMA?= =?us-ascii?Q?wVzmx7r+jPTcQhcBTUEKVKovZrVzc+hljY2hauJUCtsQ28eEn3E94JD5V+Mp?= =?us-ascii?Q?Qm2lK4W61+wzis4mYdtXD9e1zB06fRAYHhFvo12PT+36zOYIgsPj7kkn/3o3?= =?us-ascii?Q?lfRZOF/njK3JAbGmSD/aLyaoJrcHQzR7qmOKCox+wVS6gP8UALzLhV2jXueC?= =?us-ascii?Q?Cce9oXMsYsU/Ru/ZITxzLkq9l8zdBvxwHGunzhbYdoP0H7+QkmqQyM/UqCYy?= =?us-ascii?Q?fDdfOEXl3Gm8RvWubNx0rVS9uxSbWSMl1PPhfDE/aEHwFohNsFvrW1n2O6b0?= =?us-ascii?Q?XWXIJ5Ftufhp6/ojFOxu6KmvsjemOx+9K8qH9vFeI4UN3a7PXx2aYrUSCB3W?= =?us-ascii?Q?EID0Ckk3day2pTMUrHevUqCI/xTTfv9/OJ3wB3C7Lvu0L1WFgUtvdIRr12Dm?= =?us-ascii?Q?nt3Oh7ybklt0EBiLxrtJEUjidw++V44E7gUhrWpWBJbSimwSlo4QUOkc4fA1?= =?us-ascii?Q?Mgz1HV97U2HsP5QnOpCMYlX3OIVle+nFXs3zlGXFL563NLi4C8CZuKZg/5tJ?= =?us-ascii?Q?oY84s+VFqKjGx5bNELM0UqPJCKpLbqjeooqXbLutMVXjQbqeI+cEaMnl2nUT?= =?us-ascii?Q?PpAfqqhh1n8sVsyCgFmhBCYNY3ieJQWzor4hqr60VMJVX6TElhAyT69BXlLQ?= =?us-ascii?Q?KJuzPLP3HUQnTnBaSHKt7/4PGKx1ZMMnh3kLLcrSKNH6IopTLpCBAHwIcXCF?= =?us-ascii?Q?7X2sTrGOxZ+NrqGD3dpVtGxm4bNIvZ81yaxsWt6WA/47V8+WaC/g6Lei7ZNH?= =?us-ascii?Q?TIJbSV24VblYo4OzyRj3jGfkxluPWk7ABJv08mAIVIXgWPV1rBMgcUPtrYkv?= =?us-ascii?Q?iVHP01rI2Qt+wWBQQDljdfVRJZG2lAqpBZ3x4PCXGA/GawUxvq/NSkQsCjVS?= =?us-ascii?Q?MUgy9twJl2h+qfKTwHOlEfRy78yiq95mNffdNq+lxxyJVTEZg1pXY6n47eQg?= =?us-ascii?Q?Hb+SkKadFA8oOmEjVlJqfhopOCqAK6rqSFIvaMHkA7yUqQ1r4H16vg8Sdbas?= =?us-ascii?Q?hac4RwUZIIEo0u/An/GuWXZRKgmOCQyQMmRL2dy8fnpIOV8ZtQTgGN89j1h/?= =?us-ascii?Q?3CfPCj+D1n2GJvt555NMvjAKLjyzJw1JIEtp6OuRvro3QzFqie2OrwJq75sX?= =?us-ascii?Q?bzgUKkvVJ2dcUMis2hiNDGkWCaNjGmDSwqNsQBAhRyyE5w69iVDwQSdsMeXa?= =?us-ascii?Q?z8iWsJldFGrili9Cp2E6aTQLBsf9?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U7oEqBu2VGkz6ECAUZdq1zyIdDPVR9K7Ag2N5DX8fVLw/+4NY9SJzcL/w8PY?= =?us-ascii?Q?50hKPaqbz4/28JECwQMW1Q5UPAarERgOeTP62jELiI7264XDboKyTQZT4gCm?= =?us-ascii?Q?+uEWZhQeqf39Zb4T7AQra7zybsrXv1uIAZse+4ph161DpJtuWymbAY29ir/L?= =?us-ascii?Q?FC2K/c8qe7chzwe01XQmpS06Hk0Hu0xuvXKJCoaDDo3hxIvWVCk78dtNMNol?= =?us-ascii?Q?lbdSZZNk4OAeo6/+S/1kfT3v43BAMN9nu3smaRuV7V2gWTS4H2PbdMdxxv7r?= =?us-ascii?Q?2rZEQ/1Kq/bVdQiGZyxKzJ5jNRUt2Gx6qYvoTBVJp/XspdCclXZXaaavxBTP?= =?us-ascii?Q?O7f96305cmhg+pKEwPVvW/MAfBtsJOXTVY/CIvbHSOKEXwI+UnI5Fd+WLEg0?= =?us-ascii?Q?t/Bz3JJfGFGePqKd85V4LQOBjj5GcHlem7C7HhfExdl17aS1qHck6u3lrDqh?= =?us-ascii?Q?qe7ES0jvTPoeerWUAAeEBNO9BfB3pJan2471wWBmYxml+Lc1xUZE6+bFYvYR?= =?us-ascii?Q?Vfx8ht28cSmpR2opFoe89dTt4cdsGi76PysyYMxN+l0dncCR/h721KnM2LNK?= =?us-ascii?Q?AIor9z4yCxXGsiJy0egqgIX46fMYBOFjG/KBZxdSWi9LA8XdebcU0uVJXLAb?= =?us-ascii?Q?H1MFhPyIWFLyLxu1TyalXVkGkO4ucdnn+MlyEdy+HquIDpRnno6wxJZQV+M/?= =?us-ascii?Q?Rt0NULdV4nRfbrtHCRqtzYQM8vuvr50/K5q5rZoRc2Qg9jp/lrWMnxhZOF+s?= =?us-ascii?Q?B4repoF3QD5isihZA+cNT/uRkeLdhWSYRSJbELjlhxcx3kPqWoVd1gwsfiV7?= =?us-ascii?Q?l9Lo0IfNZJ2Qz1HPrzmWMFmcOiCPSNQUa23a6N4YBHoHp4cCXeFPK7LIP3vN?= =?us-ascii?Q?J0/WginguV4tFbXfiQvVPQ9u2MwEvHZTNF6iv5ajcGPOkRydZCNBRIJBDVEF?= =?us-ascii?Q?Gc+ENm9V8VCjcDv69wvJGRC3tF6M+DXGFyJFWURjHdaq9zZtL+m3g/4DsBDp?= =?us-ascii?Q?2bMq9oLcUqtl7QodGXn2dudFHK0gNRDH+/wUHnakUxpC/Hh4G8qcxxNUjTUX?= =?us-ascii?Q?mk+LrUIWDDK6tT8Tcv5ODnHExZhbBB6eEjeRi8S5X/hAwiDzq4o0zVY7OjNH?= =?us-ascii?Q?06N1iNg/ixHvT3r76C1EgmK/i8dRwdC1bqow4fPjCHoLEWtEDznRMA04AEpy?= =?us-ascii?Q?iBk3/93ziDTIB984t+4y/omkQO53Wz0NHzKzOmcyETv+7ff07SA6eg/uX7S4?= =?us-ascii?Q?6dsj6/quCw5Sx/VFMDJLUmhAngwb+pK8X2se0m+8VfveQaL30gqY2CuNZbJd?= =?us-ascii?Q?k0lp/CqfMSa6QyNhFM+ye8/QpoXUi0E1frmGFz2QjfnY/4oFJ/WvMbXMw4kW?= =?us-ascii?Q?c9Knd0wyXOL1gE1MuAhb+WT0VwHS3jEsVuU2WcmA/HQaW2TYrw0NH5tjvXTX?= =?us-ascii?Q?77cTOvXE/8Ow6LSr3D7KNq8esMmrIXUfl6PrARlcQ3XRHIvaUOUBOgpcxmq4?= =?us-ascii?Q?4ECoQ3N9WO8O4RrZSFsmAtsIRkE61PcptuImCEUhCrRgZOvtHWW2a3cIrbj8?= =?us-ascii?Q?lBNKPLKuSDXgtvqCeOOXnIZ5uVnDaurb+nzMT4RjkuQctWT5qVruJ/WbjHXU?= =?us-ascii?Q?KA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gjG6ZZW/yukpbe0zvfrabooJZeXeIX2W55BmbRSSQfP2ogZkBWrcg5b6ekMQM1AFVbeYH21EUC8jBGZ5olCmJSvVJOgfR60tWtsXSY/y0j/uGf7//FyCHDYPb97b7bkE5OPxWYjgXqPRIKWvk3HC+ZQ5XGHp15G+Mn6DiDAB3kFlfssUWL8qYeNjZtsRrdmQKbQJy/o7NWjfdkzqx/sUvpfTHQYgin0RVH1/2LFPe4JKi8RnuBUYT2Ttp0O243//fwZEExGnDQMCNN0WVE/c77SnLfYSA2jpV6kjHxY2HDfid92/nqke+8PVtwJaHUMD7+StdPwArxLAcx385RHQOCdBSz9jTk4AkJNtvaLq89/hB9MrfJm5jYbvZ+qbOKpsDaDzYkXAM/8pxHqz85j851NBNxP4MfWKdmjZXSud7MBlFaAgyjsEgMNAktz1M8+cRlT2dc8lkes/F9iiD43psW4/0RO9h/tUdRtKcUEylDZDf6BKSqulzqs6a50tnuOXK+gBDBX9Tq40A9hl1mjUeNqgQ6fqOE5M+clUbP7uSUq+l01Tse0ocyrfZKzqRNUIfXblYN2FPaJZCfOjWYv8fCG7TOdu48VeOidWhs34RSs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4348f0e9-7fc4-415e-da06-08dd3fb5d03d X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2025 16:07:07.3388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NjiWLw9ETW1lqfps48084qzpB2oY6SuoWRTd7LaFkYa1SrGjQoqk8sH89G46pQKG3Y/tMvgpO2R7t402m5TXD5xEIPSlwCewjxgTsgtGoxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7275 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-28_04,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxlogscore=673 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501280119 X-Proofpoint-GUID: UyLEGctt2GtDgrCw_c1vV3wfgcdmqldw X-Proofpoint-ORIG-GUID: UyLEGctt2GtDgrCw_c1vV3wfgcdmqldw On Tue, Jan 28, 2025 at 04:45:01PM +0100, Vlastimil Babka wrote: > On 1/27/25 16:50, Lorenzo Stoakes wrote: > > --- a/mm/vma.h > > +++ b/mm/vma.h > > @@ -67,6 +67,16 @@ enum vma_merge_flags { > > * at the gap. > > */ > > VMG_FLAG_JUST_EXPAND = 1 << 0, > > + /* > > + * Internal flag used during the merge operation to indicate we will > > + * remove vmg->middle. > > + */ > > + __VMG_FLAG_REMOVE_MIDDLE = 1 << 1, > > + /* > > + * Internal flag used during the merge operationr to indicate we will > > + * remove vmg->next. > > + */ > > + __VMG_FLAG_REMOVE_NEXT = 1 << 2, > > }; > > Hm this is actually kinda weird? It's an enum, but the values of it are > defined as different bits. And then struct vma_merge_struct has a "enum > vma_merge_flags merge_flags;" but we don't store to it a single "enum > vma_merge_flags" value defined above, but a combination of those. Is that > even legal to do in C? Yes it's legal to do. And we already did it. And other parts of the kernel do it. I get that it breaks a switch (enum val) { case ... } statement but we don't do that. > > AFAIK the more common pattern is enum that has normal incremental values > that are used for the shifts. > > But I don't think we need all of this at all here? Just have bitfields in > struct vma_merge_struct? > > bool just_expand : 1; > bool remove_middle : 1; I find that ugly, and it necessitates the addition of a new field for every new flag. It also prevents any masking stuff going forward and clutters everything. It also makes the interface confusiing, because now you have users having to know there's a field that lets you do X rather than just a simple flags field that can encapsulate all state. And some of those fields are now internal... If you were to insist we have to change this, then I'd pefer a set of defines and the but then it'd be a question of whether we typedef something for that or just pass an unsigned long. I prefer having the type safety of the enum even if it pedantically 'not correct'. C doesn't give you many sane choices for this. I am doing my part to make rust more of a thing in mm which will help on this front ;) > ... > > > /* > > diff --git a/tools/testing/vma/vma.c b/tools/testing/vma/vma.c > > index 3c0572120e94..8cce67237d86 100644 > > --- a/tools/testing/vma/vma.c > > +++ b/tools/testing/vma/vma.c > > @@ -154,6 +154,9 @@ static void vmg_set_range(struct vma_merge_struct *vmg, unsigned long start, > > vmg->end = end; > > vmg->pgoff = pgoff; > > vmg->flags = flags; > > + > > + vmg->merge_flags = VMG_FLAG_DEFAULT; > > + vmg->target = NULL; > > } > > > > /* >