From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdJYRXS (ORCPT ); Wed, 25 Oct 2017 13:23:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:59492 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbdJYRXN (ORCPT ); Wed, 25 Oct 2017 13:23:13 -0400 Subject: Re: [RFC 10/14] bootsplash: Add animation support To: Randy Dunlap , b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org Cc: tiwai@suse.com, oneukum@suse.com, msrb@suse.com, sndirsch@suse.com, michal@markovi.net, linux-kernel@vger.kernel.org References: <20171025124602.28292-1-mstaudt@suse.de> <20171025124602.28292-11-mstaudt@suse.de> <2b47c2af-1ddd-a526-601e-1781bef65232@infradead.org> From: Max Staudt Message-ID: Date: Wed, 25 Oct 2017 19:23:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2b47c2af-1ddd-a526-601e-1781bef65232@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/2017 07:20 PM, Randy Dunlap wrote: > On 10/25/17 05:45, Max Staudt wrote: >> @@ -117,17 +128,45 @@ static bool is_fb_compatible(struct fb_info *info) >> */ >> void bootsplash_render_full(struct fb_info *info) >> { >> + bool is_update = false; >> + >> mutex_lock(&splash_global.data_lock); >> >> - if (!is_fb_compatible(info)) >> - goto out; >> + /* If we've painted on this FB recently, we don't have to do >> + * the sanity checks and background drawing again. >> + */ > > multi-line comment style needs to be corrected in multiple places (in > several of the patches). Sorry, I'll fix that. Thanks. Max