mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: SVM: Tag sev_supported_vmsa_features as read-only after init
Date: Sun, 11 Jan 2026 11:40:25 -0600	[thread overview]
Message-ID: <e1df40a6-6f08-42fa-b0a3-05e2bded381c@amd.com> (raw)
In-Reply-To: <20260109033101.1005769-3-seanjc@google.com>

On 1/8/26 21:31, Sean Christopherson wrote:
> Tag sev_supported_vmsa_features with __ro_after_init as it's configured by
> sev_hardware_setup() and never written after initial configuration (and if
> it were, that'd be a blatant bug).
> 
> Opportunistically relocate the variable out of the module params area now
> that sev_es_debug_swap_enabled is gone (which largely motivated its
> original location).
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>  arch/x86/kvm/svm/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 9b92f0cccfe6..28150506b18c 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -53,8 +53,6 @@ module_param_named(sev_es, sev_es_enabled, bool, 0444);
>  static bool sev_snp_enabled = true;
>  module_param_named(sev_snp, sev_snp_enabled, bool, 0444);
>  
> -static u64 sev_supported_vmsa_features;
> -
>  static unsigned int nr_ciphertext_hiding_asids;
>  module_param_named(ciphertext_hiding_asids, nr_ciphertext_hiding_asids, uint, 0444);
>  
> @@ -81,6 +79,8 @@ module_param_named(ciphertext_hiding_asids, nr_ciphertext_hiding_asids, uint, 04
>  
>  static u64 snp_supported_policy_bits __ro_after_init;
>  
> +static u64 sev_supported_vmsa_features __ro_after_init;
> +
>  #define INITIAL_VMSA_GPA 0xFFFFFFFFF000
>  
>  static u8 sev_enc_bit;


  reply	other threads:[~2026-01-11 17:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  3:30 [PATCH 0/2] KVM: SVM: Drop SEV-ES DebugSwap module param Sean Christopherson
2026-01-09  3:31 ` [PATCH 1/2] KVM: SVM: Drop the module param to control SEV-ES DebugSwap Sean Christopherson
2026-01-11 17:39   ` Tom Lendacky
2026-01-09  3:31 ` [PATCH 2/2] KVM: SVM: Tag sev_supported_vmsa_features as read-only after init Sean Christopherson
2026-01-11 17:40   ` Tom Lendacky [this message]
2026-01-15 18:03 ` [PATCH 0/2] KVM: SVM: Drop SEV-ES DebugSwap module param Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1df40a6-6f08-42fa-b0a3-05e2bded381c@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®