From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B66C0015E for ; Thu, 6 Jul 2023 07:51:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233555AbjGFHvl (ORCPT ); Thu, 6 Jul 2023 03:51:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbjGFHvj (ORCPT ); Thu, 6 Jul 2023 03:51:39 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ABB310B for ; Thu, 6 Jul 2023 00:51:38 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-992dcae74e0so45124266b.3 for ; Thu, 06 Jul 2023 00:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688629897; x=1691221897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3XPuUPdPd4IL646MDP7xQxkm1mxaIaMz/LLFTlhEzpE=; b=jeihfA3SSlUzxo1jmrNrjXL158/UeCT7uZNbXEIqrzTux9MU7iS5WGGbJDTyncIKef a5qOL8cxKFTRDK1JEAQhioSHbp+K3JShdU14BfRA+g8bPiK13EUwSpK51+ZbTJLqGH+U EkbIsgnUJso8nWScVjexmDbyyM5QWz0enpCjUOis3Eid+Al+yBXkdYxC/W4mwXD4SIFi P3JuNpBuLAB55CRQAjYRboSOBZmUO0sh3I7xfVVVEj/UYh1WFZX9UyGz5piDNVQyz1Qk EoJTv3RTM97sM2FRGR1Wo0dHQYvUlmcT974XIJe1mdkkhrmFuB4q6NhcjLQUsOyjyc8X h7fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688629897; x=1691221897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3XPuUPdPd4IL646MDP7xQxkm1mxaIaMz/LLFTlhEzpE=; b=cGv7yMW3CIVlOqQ8DsUE3MZ69/3wLXbVULpUYmnzF17iLBZvic4EBaq+pQiDLFmLiN h1yFhakdErtgVYoV7/7k37RpF/bpR4OFEIX3sC89vNY1jgF2hpD5TGLPyMgTEZO4BetJ zj7xF912JLh+m/mCsSwQTNkH6LB7/7l6KgPFqNOTnvWaxMDA3L8HW7CWkHJahobi+FvA i0yy9S8KnmjmXGi+VkLwHSmo8B42HUOg6QAVXA+/4pB+JcT3rgyyH7fJK1AUi54zgu16 bVrt4c/3+8Enj3zjXmvzlHQ4rekdV68GD7liB3VA/5PqZnrjWnfcmUkg+pCCGQiz/lfG JdNw== X-Gm-Message-State: ABy/qLbSyuGLHvqWZBwxqOM5fz2HJYS9We4kbxVaIdD0fFn+lXG80iBg qD4i9rlG4hUaJAvMMpyCTPoViw== X-Google-Smtp-Source: APBJJlE1GzFFS11/BQZeeuoEMCqQI7WOCjyS5Cnvkbo7+aWcUl/LnigXelgXFEqsiJSV/bIfhHuY4g== X-Received: by 2002:a17:906:5346:b0:992:13c7:56d with SMTP id j6-20020a170906534600b0099213c7056dmr708586ejo.33.1688629897001; Thu, 06 Jul 2023 00:51:37 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lh6-20020a170906f8c600b0098e48ad11f2sm462030ejb.93.2023.07.06.00.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 00:51:36 -0700 (PDT) Message-ID: Date: Thu, 6 Jul 2023 09:51:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/3] dt-bindings: clock: amlogic: convert amlogic,gxbb-aoclkc.txt to dt-schema To: Jerome Brunet , Rob Herring , Neil Armstrong Cc: Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230705-b4-amlogic-bindings-convert-take2-v2-0-22be915ddc3b@linaro.org> <20230705-b4-amlogic-bindings-convert-take2-v2-2-22be915ddc3b@linaro.org> <20230705195631.GA1732680-robh@kernel.org> <1jttuh5www.fsf@starbuckisacylon.baylibre.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <1jttuh5www.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2023 09:15, Jerome Brunet wrote: >>> + then: >>> + properties: >>> + clock-names: >>> + minItems: 2 >>> + items: >>> + - const: xtal >>> + - const: mpeg-clk >>> + - const: ext-32k-0 >>> + - const: ext-32k-1 >>> + - const: ext-32k-2 >> >> As the names are always the same, move this to top-level and just set >> the length here (except the constraints are the same as top-level, so >> you can just drop this if/then). > > If this is done, aren't we losing information ? > > For example, "ext-32k-1" would become valid with a g12a as long as the > number of clocks is alright, which it is not. How it would be valid? It would be fourth item but only three are allowed. > > I'm not concerned by the automated verification, more the information > provided to the users, which we used to have in the txt format. No information is lost here, unless you claim that entries are entirely different? Best regards, Krzysztof