From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbdJBIhH convert rfc822-to-8bit (ORCPT ); Mon, 2 Oct 2017 04:37:07 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:3578 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbdJBIgu (ORCPT ); Mon, 2 Oct 2017 04:36:50 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 02 Oct 2017 01:36:28 -0700 Subject: Re: [PATCH] firmware: tegra: add BPMP debugfs support To: Jonathan Hunter , "thierry.reding@gmail.com" CC: "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" References: <1503410640-2691-1-git-send-email-talho@nvidia.com> <31191fe9-41d6-5527-2a31-389d113c459e@nvidia.com> <7d3aaba8-13ef-7713-d0a9-726ed5fbde0e@nvidia.com> <2a51649c-99d3-4e72-9a81-e93aec8f72de@nvidia.com> From: Timo Alho X-Nvconfidentiality: public Message-ID: Date: Mon, 2 Oct 2017 11:36:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2a51649c-99d3-4e72-9a81-e93aec8f72de@nvidia.com> X-Originating-IP: [10.21.24.139] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.09.2017 17:58, Jonathan Hunter wrote: >>>> +static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf >>>> *seqbuf, >>>> +                 struct dentry *parent, uint32_t depth) >>> >>> Do we need to use uint32_t here? >>> >>>> +{ >>>> +    int err; >>>> +    uint32_t d, t; >>> >>> And here? >> >> It's part of the BPMP ABI that the data passed is 32 bit unsigned >> integer. I wanted to emphasise that with the choice of integer type. Or >> did you mean why I did not use u32? > > Yes why not just u32? > No other reason than just a personal bias to use standard C99 integer types. The downstream driver was using a mix of both so wanted to standardize to just one.