From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A56C001DB for ; Fri, 11 Aug 2023 09:32:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbjHKJcN (ORCPT ); Fri, 11 Aug 2023 05:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234965AbjHKJcB (ORCPT ); Fri, 11 Aug 2023 05:32:01 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94A8A30DB for ; Fri, 11 Aug 2023 02:31:58 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b9b5ee9c5aso28458511fa.1 for ; Fri, 11 Aug 2023 02:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691746317; x=1692351117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G2VGyZBytmpnhJA0vv2u38IIsmTj+XuPqzVQBW8m7X8=; b=pC1Os6ZCtOEPs37F7qkk1QPZGPEYNG3QycSK86EQO7CfDh4WeEengx5Q7GbAdpbtyu NbGVzL/JtntLzzgbs4OSb1JOh0kZN5bqQ1v0/tdgr25+tFtLO9BQYB9xQ6HsimF197B9 Rdbr37zidkokL2for+H9vX+8p3WCo2R/nFhx4Vb5/aeal12LD/HglVlCte6QcXn9rRTh DJ+/EWj2HiLgBFV60XqexbZOhG5EJQL1rE2YtGvclqXO0tFMacDgkpSXghctoSITgJHi q2LoXpxtzrf6mc17Yus3kSunD5oA26l8YMxlyy0Q+XYyXWRulJMzfQSBbbXxcyu2/8WH dqcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691746317; x=1692351117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G2VGyZBytmpnhJA0vv2u38IIsmTj+XuPqzVQBW8m7X8=; b=Fb+309uY036eUrbbRJrA0ARwIHSVbSNwA14RSHwqKxvZXF10h4mjpE1TyMnri4ztN7 zZrRZj65QwRlihMn2XNJRyhhkB2ZaIFdK38itjGoMbDmgWnsBv8Wc3IY6x8iFHJXVQiu RQGxn9S5uekK/qAsO+pdkFHKlBleAO/YozazHibSfpz3Tu9UQha/C3TvOyvKBHHu192a s5Cld3lDwUNGEQPnF4wXpOMdLXeOww4V+4JmsMUHaO5HaC8cj5b/rLA/kuyoNNCQon1n kJ7i1F9CkmIhMX7+N+jnSbHdfrU/LQk6XzBWhqCB0dirU6El9fKbE/UuiNQAM8GHIqBo kF6g== X-Gm-Message-State: AOJu0Yz7tKqFicmffmsA3kJ1hRwgwkgxo5FkVQlsP1DqoogznUGHGpXR GFsbOvC0CrOha7WjlpQLOPBACg== X-Google-Smtp-Source: AGHT+IEgLWmt9jM55+QIvswvVbtk9wb3d49vZcs5e6sq7Hrp8q5aRDoXXwp7b+uYFEjuwAOVYgb/zw== X-Received: by 2002:a05:651c:104f:b0:2b7:2db:8ea4 with SMTP id x15-20020a05651c104f00b002b702db8ea4mr1336268ljm.30.1691746316757; Fri, 11 Aug 2023 02:31:56 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id f9-20020a7bc8c9000000b003fba92fad35sm7608507wml.26.2023.08.11.02.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 02:31:56 -0700 (PDT) Date: Fri, 11 Aug 2023 12:31:53 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: oe-kbuild@lists.linux.dev, Bartosz Golaszewski , Linus Walleij , Kent Gibson , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 2/2] gpio: sim: simplify code with cleanup helpers Message-ID: References: <20230809131442.25524-2-brgl@bgdev.pl> <2444c3ff-eaf3-4cb9-851b-8e92156128b0@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 12:14:52PM +0300, Andy Shevchenko wrote: > On Fri, Aug 11, 2023 at 08:20:11AM +0300, Dan Carpenter wrote: > > > smatch warnings: > > drivers/gpio/gpio-sim.c:1472 gpio_sim_config_make_device_group() warn: possible memory leak of 'dev' > > Isn't smatch a bit dumb about cleanup.h? > Aw. Crud. I hadn't seen that this was a cleanup.h thing. I did do some work to suppoort cleanup.h but probably it will take a while to work out the kinks. Let me figure this out. regards, dan carpenter