From: Dave Hansen <dave.hansen@intel.com>
To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: "H . Peter Anvin" <hpa@zytor.com>,
Mike Rapoport <rppt@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,
Pedro Falcato <pfalcato@suse.de>, Toshi Kani <toshi.kani@hpe.com>,
linux-mm@kvack.org, regressions@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/mm: Drop the page allocation from pud_free_pmd_page()
Date: Wed, 23 Sep 2026 16:07:02 -0700 [thread overview]
Message-ID: <e1f8a64a-e4b5-4c1b-b83d-50425a7621a4@intel.com> (raw)
In-Reply-To: <20260923223116.20090-1-mikhail.v.gavrilov@gmail.com>
On 9/23/26 15:31, Mikhail Gavrilov wrote:
> So clear the PUD, flush, and free the PTE tables straight from the
> detached PMD table - the same order pmd_free_pte_page() uses one level
> down. With no allocation left the cycle is gone, and so is the only way
> this function could fail.
Yeah, I basically agree with your analysis and fix.
There are a few things we need to figure out like having
pmd_free_pte_page() return 'int' when it doesn't ever fail, the
comments, and the reverse Christmas tree.
I'll dig into it a bit tomorrow and see what I come up with.
next prev parent reply other threads:[~2026-09-23 23:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 22:31 Mikhail Gavrilov
2026-09-23 23:07 ` Dave Hansen [this message]
2026-09-24 5:10 ` Mikhail Gavrilov
2026-09-24 16:45 ` Dave Hansen
2026-09-24 16:55 ` Pedro Falcato
2026-09-24 17:21 ` Dave Hansen
2026-09-24 17:54 ` Pedro Falcato
2026-09-24 20:39 ` Mikhail Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1f8a64a-e4b5-4c1b-b83d-50425a7621a4@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=luto@kernel.org \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pfalcato@suse.de \
--cc=regressions@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®