From: Georgi Djakov <georgi.djakov@linaro.org>
To: Pramod Gurav <pramod.gurav@linaro.org>,
ulf.hansson@linaro.org, adrian.hunter@intel.com,
linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, riteshh@codeaurora.org
Subject: Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support
Date: Thu, 20 Oct 2016 16:08:36 +0300 [thread overview]
Message-ID: <e203153c-da0a-d450-3471-9d0dabf0a2ed@linaro.org> (raw)
In-Reply-To: <20161018101624.27946-1-pramod.gurav@linaro.org>
Hi Pramod,
Thanks for the patch!
On 10/18/2016 01:16 PM, Pramod Gurav wrote:
> Provides runtime PM callbacks to enable and disable clock resources
> when idle. Also support system PM callbacks to be called during system
> suspend and resume.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@linaro.org>
> ---
>
> Tested on DB410C.
>
[..]
> +static int sdhci_msm_runtime_resume(struct device *dev)
> +{
> + struct sdhci_host *host = dev_get_drvdata(dev);
> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> + struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
> + int ret;
> +
> + ret = clk_prepare_enable(msm_host->clk);
> + if (ret) {
> + dev_err(dev, "clk_enable failed: %d\n", ret);
> + return ret;
> + }
> + ret = clk_prepare_enable(msm_host->pclk);
> + if (ret) {
> + dev_err(dev, "clk_enable failed: %d\n", ret);
Nit: Maybe mention in the prints which clock failed - core or peripheral.
> + clk_disable_unprepare(msm_host->clk);
> + return ret;
> + }
> +
> + return 0;
> +}
> +#endif
> +
> +static const struct dev_pm_ops sdhci_msm_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> + pm_runtime_force_resume)
Nit: Please align with the parenthesis.
> + SET_RUNTIME_PM_OPS(sdhci_msm_runtime_suspend, sdhci_msm_runtime_resume,
> + NULL)
Ditto.
Reviewed-by: Georgi Djakov <georgi.djakov@linaro.org>
BR,
Georgi
next prev parent reply other threads:[~2016-10-20 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 10:16 Pramod Gurav
2016-10-20 13:08 ` Georgi Djakov [this message]
2016-10-21 4:18 ` Pramod Gurav
2016-10-20 14:50 ` Ritesh Harjani
2016-10-21 4:22 ` Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e203153c-da0a-d450-3471-9d0dabf0a2ed@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pramod.gurav@linaro.org \
--cc=riteshh@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®