From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE47378813 for ; Fri, 24 Jul 2026 10:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784888373; cv=none; b=YEhfGSO04zZGSM5eJR6mpIWhiDSfX1cGmJu/e4/Jj6KBM8V/N6sSHjbF79qG6mpJlhkxN3NQfBKNPIuasuAMo66qYGbdyuIRRBRyvXmvyAnaekQvOE2+cXSWaskJ5avCbyN/ZaOQJNjUHvHhW90tjSTy/Cz3BxOYRT1ayTWQW4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784888373; c=relaxed/simple; bh=Nns+/5SBxPi2A84H5ttqcblp4FlRDsTFOKxc57iGwVY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z63cRFYvnGDcNy3rUNBLxqLrjmIGvyXi4BWZE81rhmpxqa+cs7vI9jDoamPtUDMYw0j3/KB6tbY0PUF6iWg6BcN7hybu4i1AINgalcaCKd5jpgXRIyDaEwgWp3GpvhBwKOAwzPdXzk8bW8XRNkMXwbYHApW9lYSHmJ7sL1Qwdx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M1MJKeik; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TDKjHiKi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M1MJKeik"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TDKjHiKi" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66OADXnG2478968 for ; Fri, 24 Jul 2026 10:19:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TzcThpzQ37KI9SS49pQBG6i2WjGuZuWj1VXCZ/oPMRw=; b=M1MJKeikrGQ75vy3 vJ16rtMvbgKDP3QJ5DTVRlDwcURzvKxQ4DxKVRuE5eeW8p2rOAc7KlRUYyvCKgK0 LFo+3m+xeQ1Ma7rioBim3MWcbAtYcxTelZmNikSrpVhGHwamf1n2tf+t5u9iHIcK Wqu+FStM8JuGn+FbSQ+GxWyey6XfcEYNUE6IBL4KSFqqN0eYoVwZcAf14pERJWu+ ZEYWddCk+fbhHO+HTTrnLMURidFKtA0le/1VYhejMV3Cln0EmPJbhwz27O3gQlTx faABTNB+6Y6g67HcEeJxCMg/hCeoplPEDdTevM0RgNW49kmLv5m7UK1eJcdlochN an0EcQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm2cx8yk7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 10:19:31 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cbb467e56aaso298247a12.1 for ; Fri, 24 Jul 2026 03:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784888371; x=1785493171; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TzcThpzQ37KI9SS49pQBG6i2WjGuZuWj1VXCZ/oPMRw=; b=TDKjHiKitvSLQQHgNWzQgKgVy+GxQkBG5QXBIMEPtJdwMalhOlpkry8B+Z/ocsZdxc YamcYzVAfSvz4MueMKFAZ7NosAo8RNYXqafl2SH+adBx2XmS96oJg6d2kQFEB3gQAr8S p47gFq0mAvbq3fLwmmc6DqT15V3vSE4YlSgSBZR8MTRlT9YoUIvdCROqo/8isp1SsFlg qh1Jg4sOJkgw+UGAMNybEJKSu4q7qdfD9JFsioJD0z3AdpT/D7VPKDlOvmWwV+hpfMrp oQG860UWqNwq+omTgnJzVg5LUuJKS64heUQ2rFDEmWSf+dimD+czY6pcZMLuvgTxFYoM 9atw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784888371; x=1785493171; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TzcThpzQ37KI9SS49pQBG6i2WjGuZuWj1VXCZ/oPMRw=; b=hfwQD+EHX5nKxW+g/J5ZBUPR5oHgNyPnaBEvR9pxuiYoQDdWh2OQhYLoxCCPMVeSsU orMqRSnH5aemCJfNorrufbSN8bBdUYecQp5qOFboDfBtV8aUXhN70TDyHJX/uV43W11W LOypS9KOOkREwwXDklX0/UgZd+lqPpFkCCvVvyWDTiW/RMtEqIW2ZlQrlco136KIBxeu soZ+ahI5/IBCZE6CgleKMXRyJksaci/updbrhph3Cc5prWSUwwMHNuDZZ9RB5v6G69Qg M+0ozAmuLCkNZItp4bC0S6IH45VJD6xtmzX0oIhnlSJvv5/1YQ3bhvf+TR+KCv05CZ63 JNKA== X-Forwarded-Encrypted: i=1; AHgh+Rrr9G4Q4G6C37fBrtoGoK7ZO9CIkUe6zVVxpklya39VDrym3VNqu5uPPBh71DB2QuvVk2Ow9/4Zna0O4uI=@vger.kernel.org X-Gm-Message-State: AOJu0Yytfvr9suXuRIPYvc4SCBZlCJg645vjURI+Z2vr1lzpc2zX1D6f Hp4uGFanWsunPJQKTZcqNsxVr3rEaREBZsjJs9bPT8k2fXmC1kcg53CSYYAJBXBlXiQuXXJ9GOY 4NAqBWISCl+Q+EKmmnSiy57dJJYjvDYrKFZ0CowpHr6obj9hPOTGyWUgr1KKuisZQPXM= X-Gm-Gg: AR+sD129pIuQRXmoAAlMKJBmsNstuqpd2ok6LeH8Ek6bxfF2P+anF5X+tHenDnZwCQo VI7II1lGhdhmVoxNqCMeHFqL1mTaF0hXAXjwC1T7BO9o/6Ti8MhixQ2gGYHuX38IqaFT7dF2cM/ USCU67IKXzHlx481c02mJrtcCEyf4QINZ3k0KyIyIbONGmWpx/HHapEfCdX/l6zth2w/e1kkgzk Dr95uNUnpdN0OiVoq4qd0UgAlUudD+sjZRmSidvcSphdCuVzc2nH7LI3aTWBMFcw28QuYiRt1Kr 9P5tQxMoUfh+bu9cK1zJSEtiBNUkKVlzZXHh10Qeum1rEFBkb9N7NoiyRb2IjK15dOl99IhB/oj 4fqi2fSapMYGy28qNTfozctxdq1MV X-Received: by 2002:a05:6a00:4194:b0:848:7475:29bd with SMTP id d2e1a72fcca58-84e2b7fa657mr7632805b3a.7.1784888371004; Fri, 24 Jul 2026 03:19:31 -0700 (PDT) X-Received: by 2002:a05:6a00:4194:b0:848:7475:29bd with SMTP id d2e1a72fcca58-84e2b7fa657mr7632780b3a.7.1784888370614; Fri, 24 Jul 2026 03:19:30 -0700 (PDT) Received: from [10.217.217.237] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17236c6fsm4554751b3a.5.2026.07.24.03.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 03:19:30 -0700 (PDT) Message-ID: Date: Fri, 24 Jul 2026 15:49:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] clk: qcom: Add Nord display clock controller support To: Alexandre Mergnat Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Shawn Guo , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Konrad Dybcio , Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio References: <20260721-nords_mm_v1-v2-0-17e5a445a512@oss.qualcomm.com> <20260721-nords_mm_v1-v2-4-17e5a445a512@oss.qualcomm.com> <178470914171.3016846.549735580156854018.b4-review@b4> Content-Language: en-US From: Taniya Das In-Reply-To: <178470914171.3016846.549735580156854018.b4-review@b4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JT47kBl4RwpfTDJ-ggNojhRDt4KWfgSt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA5MyBTYWx0ZWRfXydAr/ZWJra3J FqAb2rSX3fWu3KIYtuue1voz/53YumaKvW7PmR5gu2A5Gn1u+gSreghlpBZLSIxXnXIMlLgsVuE o7pj/t6TXdeYm1q8qMrm5xOGTWO6RzQ/IvQ9iwwa0+J6O+H/VbeBzhgGD/XdunwIVudQEWxvYwy xaNUD1c8Ebt0B1SFtY0B18rYvQakIf1WvxKjhkCLlt22YpSSQ5px9A0Dj0rdrkTjWftRyI88EZx TUSYYXn9pe7XRHWYx4SFd/XBO/NZkw4L+sjsA1M5tGxm+7tKnw7UoOKooD5hT5rpGialGdf+2P5 EVaNZZJDrscqin0f80y8mi9V3tl/k47Z1ksXYRTl50S2AAzUpqUgtWZzVm2sqDfnY2oqw4CadaV fOWe61feSk4HfRTYObbviXxoxb0vZHC6REU9SV+ECD2fSpJYv2/WiOeW12nT+fCKUkMi9YI5Kpy 1a5biIMBthsJqLH5USw== X-Authority-Analysis: v=2.4 cv=X51i7mTe c=1 sm=1 tr=0 ts=6a633c33 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=5U75EOjajMfvmKnCyHUA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: JT47kBl4RwpfTDJ-ggNojhRDt4KWfgSt X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA5MyBTYWx0ZWRfX4ehOAVZvjchG DM1VFrVxLez1eZSgYAAj/G+FLdG/2SClE7YI/626bw8nThKhZyD7jlw5XOxNxkYQuoeHwEch8Tn yeSF7OPCQTu9L1E69g5xccXF2AFguFM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_02,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240093 On 7/22/2026 2:02 PM, Alexandre Mergnat wrote: >> + >> +static const u32 disp_cc_0_nord_critical_cbcrs[] = { >> + 0xc00c, /* MDSS_DISP_CC_AHB_CLK */ >> + 0xc008, /* MDSS_DISP_CC_VSYNC_CLK */ > These two comments look mislabeled: offsets 0xc00c/0xc008 are the RSCC AHB/VSYNC > clocks (cf. disp_cc_mdss_rscc_ahb_clk @0xc00c and disp_cc_mdss_rscc_vsync_clk @0xc008 > in dispcc-sm8550.c / dispcc-milos.c), whereas the plain AHB/VSYNC branches in this > file are at 0x80c0 / 0x8030. dispcc1-nord.c labels these same offsets as RSCC. > Can you double check and update them to MDSS_DISP_CC_RSCC_AHB_CLK and > MDSS_DISP_CC_RSCC_VSYNC_CLK ? > The offsets looks correct, only the comments differ. Yes, Alexandra the comments are mislabeled. I will fix in the next patch. -- Thanks, Taniya Das