From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] io_uring: handle mm_fault outside of submission
Date: Sun, 27 Oct 2019 18:35:04 +0300 [thread overview]
Message-ID: <e208444f3c22d2ee118e88b8e0d591ee6c80a1e3.1572189860.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1572189860.git.asml.silence@gmail.com>
Preparation for the following patch.
Let callers of io_submit_sqes() handle an mm_fault case.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 44 ++++++++++++++++++++++++++------------------
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 76cc8add9e77..f65727f2ba95 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2640,7 +2640,7 @@ static bool io_get_sqring(struct io_ring_ctx *ctx, struct sqe_submit *s)
}
static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr,
- bool has_user, bool mm_fault)
+ bool has_user)
{
struct io_submit_state state, *statep = NULL;
struct io_kiocb *link = NULL;
@@ -2682,17 +2682,12 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr,
}
out:
- if (unlikely(mm_fault)) {
- io_cqring_add_event(ctx, s.sqe->user_data,
- -EFAULT);
- } else {
- s.has_user = has_user;
- s.in_async = true;
- s.needs_fixed_file = true;
- trace_io_uring_submit_sqe(ctx, true, true);
- io_submit_sqe(ctx, &s, statep, &link);
- submitted++;
- }
+ s.has_user = has_user;
+ s.in_async = true;
+ s.needs_fixed_file = true;
+ trace_io_uring_submit_sqe(ctx, true, true);
+ io_submit_sqe(ctx, &s, statep, &link);
+ submitted++;
}
if (link)
@@ -2703,6 +2698,16 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr,
return submitted;
}
+static void io_fail_all_sqes(struct io_ring_ctx *ctx)
+{
+ struct sqe_submit s;
+
+ while (io_get_sqring(ctx, &s))
+ io_cqring_add_event(ctx, s.sqe->user_data, -EFAULT);
+
+ io_commit_sqring(ctx);
+}
+
static int io_sq_thread(void *data)
{
struct io_ring_ctx *ctx = data;
@@ -2813,12 +2818,15 @@ static int io_sq_thread(void *data)
}
}
- to_submit = min(to_submit, ctx->sq_entries);
- inflight += io_submit_sqes(ctx, to_submit, cur_mm != NULL,
- mm_fault);
-
- /* Commit SQ ring head once we've consumed all SQEs */
- io_commit_sqring(ctx);
+ if (unlikely(mm_fault)) {
+ io_fail_all_sqes(ctx);
+ } else {
+ to_submit = min(to_submit, ctx->sq_entries);
+ inflight += io_submit_sqes(ctx, to_submit,
+ cur_mm != NULL);
+ /* Commit SQ ring head once we've consumed all SQEs */
+ io_commit_sqring(ctx);
+ }
}
set_fs(old_fs);
--
2.23.0
next prev parent reply other threads:[~2019-10-27 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 15:35 [PATCH 0/2][for-next] cleanup submission path Pavel Begunkov
2019-10-27 15:35 ` Pavel Begunkov [this message]
2019-10-27 15:35 ` [PATCH 2/2] io_uring: merge io_submit_sqes and io_ring_submit Pavel Begunkov
2019-10-27 16:32 ` [PATCH 0/2][for-next] cleanup submission path Jens Axboe
2019-10-27 16:44 ` Pavel Begunkov
2019-10-27 16:49 ` Jens Axboe
2019-10-27 16:56 ` Jens Axboe
2019-10-27 17:19 ` Pavel Begunkov
2019-10-27 17:26 ` Jens Axboe
2019-10-27 17:37 ` Pavel Begunkov
2019-10-27 18:56 ` Pavel Begunkov
2019-10-27 19:02 ` Jens Axboe
2019-10-27 19:17 ` Pavel Begunkov
2019-10-27 19:51 ` Jens Axboe
2019-10-27 19:59 ` Pavel Begunkov
2019-10-28 3:38 ` Jens Axboe
2019-10-28 11:12 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e208444f3c22d2ee118e88b8e0d591ee6c80a1e3.1572189860.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®