From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D116B3D3002; Fri, 13 Mar 2026 20:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773434405; cv=none; b=E/5rq87zlRh5p5Qqzu9xFuFBZW0x8MxWl9rdga5Am1xuf3Uo23fAMAaK97xVboJ6Q8m+ay330SOsMBGCyZMtTD0AT/cDGKaH+TnAypGq2Wj//uvqHUv0fC6675TaQbLbtwU0zJUFaxODE7Ovgp5+lNm1bsQEEm70o9TkWT3P0cE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773434405; c=relaxed/simple; bh=xn0O7SqGpf/SBvzD1sikVpzC7YwH94rqIZwDiiQabIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RBi5eHlra/cwICUS/yqNFFfWvL1qMNhY2E5qte5yLxj1mEZ9S6cetE9bRpKNW6BsGdVh8eVd4+McetTt5kAH9gMzOX2Kp8mGdgwow2P+SfpF7NH7kJQiXIFhNhQk5ZpEb59KMj22amKLs5flXruSmNPgzUbb8Has6UNyUaAWbL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=t0zcpa2q; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t0zcpa2q" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F1F7CF52; Fri, 13 Mar 2026 21:38:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773434330; bh=xn0O7SqGpf/SBvzD1sikVpzC7YwH94rqIZwDiiQabIo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=t0zcpa2q/w5s168z2O39680XO3V3MoAhAN7sQ5B/l4yV7c0Gh1ALxvTqemKi0SibN rmdnEXZJ8Xps2LxiEux/ldLxiL1mJFBlB0HK+fdO4HwMuvDU3JvRZ99PrntBIDjKxf MTfgnSEHmFYE20el4IUCEV2roiRBcQJhVvY/wqaQ= Message-ID: Date: Fri, 13 Mar 2026 20:39:56 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] media: rzv2h-ivc: Fix FM_STOP register write To: Jacopo Mondi , =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi , =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , stable@vger.kernel.org References: <20260313-mali-ivc-fixes-v7-0-v1-0-cb0714cd1279@ideasonboard.com> <20260313-mali-ivc-fixes-v7-0-v1-4-cb0714cd1279@ideasonboard.com> Content-Language: en-US From: Dan Scally In-Reply-To: <20260313-mali-ivc-fixes-v7-0-v1-4-cb0714cd1279@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jacopo and Barnabás On 13/03/2026 11:14, Jacopo Mondi wrote: > From: Barnabás Pőcze > > Bit 20 should be written in this register to stop frame processing. > So fix that, as well as the poll condition. > > Cc: stable@vger.kernel.org > Fixes: f0b3984d821b ("media: platform: Add Renesas Input Video Control block driver") > Signed-off-by: Barnabás Pőcze > Signed-off-by: Jacopo Mondi > --- Reviewed-by: Daniel Scally > drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-video.c | 5 +++-- > drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc.h | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-video.c b/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-video.c > index d894a880c33f..9b75e4b10e99 100644 > --- a/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-video.c > +++ b/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-video.c > @@ -297,9 +297,10 @@ static void rzv2h_ivc_stop_streaming(struct vb2_queue *q) > struct rzv2h_ivc *ivc = vb2_get_drv_priv(q); > u32 val = 0; > > - rzv2h_ivc_write(ivc, RZV2H_IVC_REG_FM_STOP, 0x1); > + rzv2h_ivc_write(ivc, RZV2H_IVC_REG_FM_STOP, RZV2H_IVC_REG_FM_STOP_FSTOP); > readl_poll_timeout(ivc->base + RZV2H_IVC_REG_FM_STOP, > - val, !val, 10 * USEC_PER_MSEC, 250 * USEC_PER_MSEC); > + val, !(val & RZV2H_IVC_REG_FM_STOP_FSTOP), > + 10 * USEC_PER_MSEC, 250 * USEC_PER_MSEC); > > rzv2h_ivc_return_buffers(ivc, VB2_BUF_STATE_ERROR); > video_device_pipeline_stop(&ivc->vdev.dev); > diff --git a/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc.h b/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc.h > index 54c70de31c1e..049f223200e3 100644 > --- a/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc.h > +++ b/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc.h > @@ -46,6 +46,7 @@ > #define RZV2H_IVC_REG_FM_MCON 0x0104 > #define RZV2H_IVC_REG_FM_FRCON 0x0108 > #define RZV2H_IVC_REG_FM_STOP 0x010c > +#define RZV2H_IVC_REG_FM_STOP_FSTOP BIT(20) > #define RZV2H_IVC_REG_FM_INT_EN 0x0120 > #define RZV2H_IVC_VVAL_IFPE BIT(0) > #define RZV2H_IVC_REG_FM_INT_STA 0x0124 >