From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB9E4C54EE9 for ; Mon, 19 Sep 2022 08:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbiISIw4 (ORCPT ); Mon, 19 Sep 2022 04:52:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbiISIwc (ORCPT ); Mon, 19 Sep 2022 04:52:32 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A2C123BDB for ; Mon, 19 Sep 2022 01:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663577537; x=1695113537; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=7QxS/3b+jv8oLEkVkI5TSPtcKOSVhNxh6zUhyAW+1bM=; b=mbZGxeLpVRUAKhleFKAea4EnAOQAuaYdcqsoWgPjXptMQ6jp8I4aLk2m yfQuUwzMmOqbMubqSTmIen4R1gmQNHb4wIrDLxSP97pUW8a4B7yO6qZli elicBuAxiDrI8c4sdgnz/PLh1WN/BTtTJb0Hq/orIud2EEZnZTp4kV0SJ 7CMJYrHBwlwBIpkW+oeIEKUr3gnEFq7TVUvIN3QGr6SJdvmW16hQa0pqr 2PN6FeBwaQF1N+G12a0QQyCG/WI2o3Huj1PAOiPuHu++/VbhMNAkQiOdI p+HeZfwQTXMULoGN04f56UhNia0YM0rSwWKbQZudn9aTikoYPllwACuZY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10474"; a="286389363" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="286389363" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 01:52:16 -0700 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="707485757" Received: from ilick-mobl1.ger.corp.intel.com (HELO [10.252.59.91]) ([10.252.59.91]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 01:52:12 -0700 Message-ID: Date: Mon, 19 Sep 2022 10:48:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] soundwire: cadence: Fix error check in cdns_xfer_msg() Content-Language: en-US To: Richard Fitzgerald , vkoul@kernel.org, yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20220917154822.690472-1-rf@opensource.cirrus.com> From: Pierre-Louis Bossart In-Reply-To: <20220917154822.690472-1-rf@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/22 17:48, Richard Fitzgerald wrote: > _cdns_xfer_msg() returns an sdw_command_response value, not a > negative error code. > > Signed-off-by: Richard Fitzgerald Reviewed-by: Pierre-Louis Bossart we've got other issues like this such as enum sdw_command_response cdns_xfer_msg_defer(struct sdw_bus *bus, struct sdw_msg *msg, struct sdw_defer *defer) { struct sdw_cdns *cdns = bus_to_cdns(bus); int cmd = 0, ret; /* for defer only 1 message is supported */ if (msg->len > 1) return -ENOTSUPP; <<< that's not right We should probably double-check that all functions return enums don't return negative values. > --- > drivers/soundwire/cadence_master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c > index ca241bbeadd9..3543a923ee6b 100644 > --- a/drivers/soundwire/cadence_master.c > +++ b/drivers/soundwire/cadence_master.c > @@ -708,7 +708,7 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg) > for (i = 0; i < msg->len / CDNS_MCP_CMD_LEN; i++) { > ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN, > CDNS_MCP_CMD_LEN, false); > - if (ret < 0) > + if (ret != SDW_CMD_OK) > goto exit; > } >