From: Ding Hui <dinghui@sangfor.com.cn>
To: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: pengdonglin@sangfor.com.cn, Huang Cun <huangcun@sangfor.com.cn>
Subject: Re: [PATCH] scsi: scsi_dh_rdac: Avoid crash when a disk attach failed
Date: Wed, 6 Sep 2023 16:37:43 +0800 [thread overview]
Message-ID: <e20bfd11-175d-e5ae-a224-c0e02e1646b8@sangfor.com.cn> (raw)
In-Reply-To: <20230803112841.588822-1-huangcun@sangfor.com.cn>
Friendly ping.
On 2023/8/3 19:28, Huang Cun wrote:
> When a disk fails to attach, the struct rdac_dh_data is released,
> but it is not removed from the ctlr->dh_list. When attaching another
> disk, the released rdac_dh_data will be accessed and the following
> BUG_ON() may be observed:
>
> [ 414.696167] scsi 5:0:0:7: rdac: Attach failed (8)
> ...
> [ 423.615364] kernel BUG at drivers/scsi/device_handler/scsi_dh_rdac.c:427!
> [ 423.615731] invalid opcode: 0000 [#1] SMP NOPTI
> ...
> [ 423.623247] Call Trace:
> [ 423.623598] rdac_bus_attach+0x203/0x4c0
> [ 423.623949] ? scsi_dh_handler_attach+0x2d/0x90
> [ 423.624300] scsi_dh_handler_attach+0x2d/0x90
> [ 423.624652] scsi_sysfs_add_sdev+0x88/0x270
> [ 423.625004] scsi_probe_and_add_lun+0xc47/0xd50
> [ 423.625354] scsi_report_lun_scan+0x339/0x3b0
> [ 423.625705] __scsi_scan_target+0xe9/0x220
> [ 423.626056] scsi_scan_target+0xf6/0x100
> [ 423.626404] fc_scsi_scan_rport+0xa5/0xb0
> [ 423.626757] process_one_work+0x15e/0x3f0
> [ 423.627106] worker_thread+0x4c/0x440
> [ 423.627453] ? rescuer_thread+0x350/0x350
> [ 423.627804] kthread+0xf8/0x130
> [ 423.628153] ? kthread_destroy_worker+0x40/0x40
> [ 423.628509] ret_from_fork+0x1f/0x40
>
> Fixes: 1a5dc166cd88 ("scsi_dh_rdac: update 'access_state' field")
> Signed-off-by: Huang Cun <huangcun@sangfor.com.cn>
> Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
> Cc: Donglin Peng <pengdonglin@sangfor.com.cn>
> ---
> drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c
> index c5538645057a..9d487c2b7708 100644
> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
> @@ -762,8 +762,10 @@ static int rdac_bus_attach(struct scsi_device *sdev)
>
> clean_ctlr:
> spin_lock(&list_lock);
> + list_del_rcu(&h->node);
> kref_put(&h->ctlr->kref, release_controller);
> spin_unlock(&list_lock);
> + synchronize_rcu();
>
> failed:
> kfree(h);
--
Thanks,
- Ding Hui
next prev parent reply other threads:[~2023-09-06 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:28 Huang Cun
2023-09-06 8:37 ` Ding Hui [this message]
2023-09-06 15:51 ` Mike Christie
2023-09-07 1:45 ` Ding Hui
2023-09-08 1:03 ` Ding Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e20bfd11-175d-e5ae-a224-c0e02e1646b8@sangfor.com.cn \
--to=dinghui@sangfor.com.cn \
--cc=huangcun@sangfor.com.cn \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pengdonglin@sangfor.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®