mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Conor Dooley <conor@kernel.org>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Ahmed Naseef <naseefkm@gmail.com>,
	Benjamin Larsson <benjamin.larsson@genexis.eu>,
	Christian Marangi <ansuelsmth@gmail.com>,
	devicetree@vger.kernel.org, lei.dong@airoha.com,
	Linqi.zhang@airoha.com, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	mfd@lists.linux.dev,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	Rajeev.kumar@airoha.com, upstream@airoha.com,
	Weifeng.xu@airoha.com, zhengping.zhang@airoha.com
Subject: Re: [PATCH v2 5/7] dt-bindings: pinctrl: airoha: add AN7589
Date: Mon, 16 Nov 2026 20:39:21 +0100	[thread overview]
Message-ID: <e20f708f-ebfe-4dc0-a64c-1590fdf608f3@phrozen.org> (raw)
In-Reply-To: <20261116-resolved-riot-c6a310bb2d8c@spud>

Hi Conor,

The largest users are EN7523 pcm_spi 14, AN7563 pnand 17, AN7583
pnand 17, EN7528 pnand 17, EN7581 pnand 17 and AN7589 emmc 12 (these
numbers are based on a hackish "grep foo | bar", so they might be
slightly off).

I copied and modified what the other AN/EN bindings do. These set the
limit to the pin count of the SoC: EN7523 38, AN7563 38, AN7583 53,
EN7528 50, EN7581 58. Your call really, I do not mind either way. I can
send a v4 and then a follow up series cleaning up the existing bindings
as well.

        John

On 16.11.26 19:15, Conor Dooley wrote:
> On Mon, Nov 16, 2026 at 06:47:27PM +0100, John Crispin wrote:
>> On Fri, Nov 13, 2026 at 05:40:42PM +0000, Conor Dooley wrote:
>>> As Lee requested, please split this out. Two patches, maybe even three.
>>
>> Agreed. v3 splits it into three patches.
>>
>>> Do we even need a child node here? If all this node does is
>>> gpio/pinctrl, why can the driver not bind directly to this node?
>>>
>>> What else does it do that warrants being a syscon?
>>
>> The block also holds the PWM controller. Its registers interleave with
>> the GPIO ones. The PWM series adds it as a second child, as on the
>> EN7581. That series has a depency on this one so I have not posted it yet.
>>
>>> Otherwise, there should only be one. uart1 and uart2 should have
>>> different nodes.
>>
>> Agreed. v3 sets maxItems to 1. Only pcm_spi and pcie keep more, as
>> their groups carry different signals of one device.
>>
>>> So here, maxItems should be 1 for similar reasons.
>>
>> Agreed, v3 does this for i2c too.
>>
>>> I'm also curious about why this goes up to 74. None of the functions
>>> have 74 pins, surely?
>>
>> A conf node can set the same config on any set of pins. 74 is all the
>> pins. The EN7581 binding does the same with 58.
> 
> A difference in philosophy I guess - I would be grouping the pins in the
> config node by user. So that there would be something like
> 
> spi1-stuff {
> 	spi1-function {
> 		function = spi
> 		group = spi1
> 	}
> 
> 	spi1-config1 {
> 		pins = 1, 2
> 		config1
> 		config2
> 	}
> 
> 	spi2-config2 {
> 		pins = 3
> 		config1
> 	}
> }
> 
> spi {
> 	pinctrl-0 = spi1-function, spi-config1, spi-config2
> }
> 
> or
> 
> spi {
> 	pinctrl-0 = spi1-stuff
> }
> 
> IMO, having config nodes covering more than one "feature" doesn't really
> make sense, as you'd end up with something like:
> 
> spi1-function {
> 	function = spi
> 	group = spi1
> }
> 
> all-config1-config2 {
> 	pins = 1, 2, 4, 5
> 	config1
> 	config2
> }
> 
> all-config1 {
> 	pins = 3
> 	config1
> }
> 
> which kinda falls apart I think when a node can request a setting for
> pins that are not part of it (in this case, that's pins 4 and 5)
> 
> spi {
> 	pinctrl-0 = spi1-function, all-config1, all-config1-config2
> }
> 
> So my opinion is that the max number of items should be the size of the
> largest peripheral.
> 
> What's the largest actual user on the 7581?
> 		
>>
>> v3 will follow shortly.
>>
>>         John
>>
>>


  reply	other threads:[~2026-11-16 19:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:59 [PATCH v2 0/7] pinctrl: airoha: add AN7589 support John Crispin
2026-11-12 18:59 ` [PATCH v2 1/7] pinctrl: airoha: make gpio register layout per SoC John Crispin
2026-11-12 18:59 ` [PATCH v2 2/7] pinctrl: airoha: add per pin mode field mux John Crispin
2026-11-12 18:59 ` [PATCH v2 3/7] pinctrl: airoha: make the chip SCU optional John Crispin
2026-11-13  8:12   ` Lorenzo Bianconi
2026-11-12 18:59 ` [PATCH v2 4/7] pinctrl: airoha: mux a requested GPIO through the IOMUX John Crispin
2026-11-12 18:59 ` [PATCH v2 5/7] dt-bindings: pinctrl: airoha: add AN7589 John Crispin
2026-11-13  9:45   ` Lee Jones
2026-11-13 17:40   ` Conor Dooley
2026-11-16 17:47     ` John Crispin
2026-11-16 18:15       ` Conor Dooley
2026-11-16 19:39         ` John Crispin [this message]
2026-11-12 18:59 ` [PATCH v2 6/7] pinctrl: airoha: move the GPIO register offsets to the common header John Crispin
2026-11-12 18:59 ` [PATCH v2 7/7] pinctrl: airoha: add support of an7589 SoC John Crispin
2026-11-13  8:14   ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e20f708f-ebfe-4dc0-a64c-1590fdf608f3@phrozen.org \
    --to=john@phrozen.org \
    --cc=Linqi.zhang@airoha.com \
    --cc=Rajeev.kumar@airoha.com \
    --cc=Weifeng.xu@airoha.com \
    --cc=ansuelsmth@gmail.com \
    --cc=benjamin.larsson@genexis.eu \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lei.dong@airoha.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=naseefkm@gmail.com \
    --cc=robh@kernel.org \
    --cc=upstream@airoha.com \
    --cc=zhengping.zhang@airoha.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®