From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86766192B9D for ; Thu, 2 Jan 2025 09:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735810863; cv=none; b=aVB4EMFhO3UeQNACe+tUXmJbO4Xhg7BHcfxwEx7tHPBFFEzYgm1kJV77hCfBtp/bz0VcTBdLW/8fXKcLrBy8tvkJQjGReo4hN8imegtW8gBkic8OQWkYLfTd+DeUcsxuuhVjYngfivvsg1bGckdeoaYt9BkQkkZ9+xlO6LpQfAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735810863; c=relaxed/simple; bh=rgCmt8G/s/XPcDlYvaXsyjCSuEhFs7q/O7o5TRNyScY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ffwR9Tcmx/wPbm1XPvGQK+BE4wYhlGPaN7cl1ibUgujMrw+3HXriXBLZpPAWMb7MdDGpSIzE8f6GRxX1peJ1MlJsH/dM1RXplDl+YaaEjlp+UNGxrETwOtnGTz2b20dEZlasjSNiQsEVDe5jIQGYQuk1anXgh1MT5yJsGbqxas0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ef5HpCdp; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ef5HpCdp" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4361dc6322fso73204195e9.3 for ; Thu, 02 Jan 2025 01:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735810860; x=1736415660; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=odDHdEKVo1ECoBHd6qSHP5bCx3nKUQG5008PYymM31w=; b=ef5HpCdp8DBMGyZVSBSbcNmev3w8VRBBJN+jfaQZSg6ENl4D4fe+UB6TJOTuk17a79 NvBpO19J7vaJGqo/ppuYGaAznVXjQWdEInmpV0P5YI3Hy6Em5FIkRlCbLRVI0MthdU3S 33AV9azvdlpqnt+SFuoihDymnOG2atjgm+CUe/2Xor0R957IiyxmKApjsX8hie7gIyNL 6RVUq6kykL6E4B5OeDuA0IqnY3PEo+d2cS2Bipr1801xstyVRHg8eXsVZXX59QYa8Uck Lg3KMJlKK+MiJV6YCpFmSIJPbGH9D7ner2djRz/8yOWcjbztbCrhxejdJhOa/cPfMAJH 8eyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735810860; x=1736415660; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=odDHdEKVo1ECoBHd6qSHP5bCx3nKUQG5008PYymM31w=; b=vKB44BQMbV7b53smqHSHvxDi40Qs4IDVv221M+ohTw1xFcltZv6edyt6Q2BFxaLM1w oU0N6nn94dM9z78Xy49OkU8S7JzrE0tQ5JZFgEI4D2bHW7KKd5ca2nmCspDlKug5QFs0 AbCzu/g+j0HkHUNLBMqZpM3JCkr+5fx1K2DIEV4ZyZMnhFzZHMzZ5OuGvu9wW2VfCBAm oT6+bGpabC+IEtj31Y+YhzfuYnyHeubPZwU5uwhVjkZMo3jZ9bqnAYg+Qp5CyQgORcOx ILtVQr+DU0JCdq3kmo37wliTAT0O7Y7AS3chyj4oioXHow2Y8rcxFNXfW1MJyyZFm4zl d+zg== X-Forwarded-Encrypted: i=1; AJvYcCWW748pMxOFS62WHYwPbo6bsSkerMNoDSNx9kgD0cNKsl24N724F0ELJQ8WBE6POvTLyVHglZ4PmeiG0Ck=@vger.kernel.org X-Gm-Message-State: AOJu0YyQBQ1UtV1kvj0ApT1qh7e+4tibMEoyKoavzN+ucnQcbT37bC2f /Y5wMbKg0OvAFtcefBs9sbOLQKYGtNbJONPYYiVsDd6QThfM43qu3VK9+Mm2qx4= X-Gm-Gg: ASbGncuDz7aEg3b2GPmzohTppr67RXX/+JvjgQYegawPWKB1/QNk6Tn8GunZ8MmTvRD 3nQQQNIhU80rGxBHP0XZabvuHNe0QIQTxqUlQNp4Wg1HFxQMKP2GR6l+ssLR1Y7yRu3MRoHnF/x 996bKX25gDI4HKY5DCu5THiZpWXaIfwj669AW+doIsdXmqgt/nksB8RU/xFI5ewPsRtj2sBBsaO CiFFqyDY8Vh4/B8vZAMsST6ar/muRDiE8nfgCKU8cFAnDIgh45if1R84wwGEnoJUrbItnVfGMdj uQiusK9NPwfF/6XwvQ+MgSGRjwo8vX2FNw== X-Google-Smtp-Source: AGHT+IFYDkDox7plguF5rgyeIEMg1cp8DLocgikphY1yErZzrrY6xhBUr9jUMcggCFeUOsushSH/Dg== X-Received: by 2002:a05:600c:4f92:b0:436:488f:50a with SMTP id 5b1f17b1804b1-43668646896mr407348285e9.17.1735810859938; Thu, 02 Jan 2025 01:40:59 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:1cfa:329a:aa2e:f0be? ([2a01:e0a:982:cbb0:1cfa:329a:aa2e:f0be]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8332absm37183733f8f.38.2025.01.02.01.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 01:40:59 -0800 (PST) Message-ID: Date: Thu, 2 Jan 2025 10:40:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/2] phy: amlogic: meson8b-usb2: Use FIELD_PREP instead of _SHIFT macros To: Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, kishon@kernel.org References: <20241231191718.2764065-1-martin.blumenstingl@googlemail.com> <20241231191718.2764065-2-martin.blumenstingl@googlemail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241231191718.2764065-2-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/12/2024 20:17, Martin Blumenstingl wrote: > This simplifies the code by re-using the FIELD_PREP helper. No > functional changes inteded. > > Signed-off-by: Martin Blumenstingl > --- > drivers/phy/amlogic/phy-meson8b-usb2.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c > index d63147c41b8c..d9c761b7c15c 100644 > --- a/drivers/phy/amlogic/phy-meson8b-usb2.c > +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c > @@ -5,6 +5,7 @@ > * Copyright (C) 2016 Martin Blumenstingl > */ > > +#include > #include > #include > #include > @@ -39,9 +40,7 @@ > #define REG_CTRL_TX_BITSTUFF_ENN BIT(18) > #define REG_CTRL_COMMON_ON BIT(19) > #define REG_CTRL_REF_CLK_SEL_MASK GENMASK(21, 20) > - #define REG_CTRL_REF_CLK_SEL_SHIFT 20 > #define REG_CTRL_FSEL_MASK GENMASK(24, 22) > - #define REG_CTRL_FSEL_SHIFT 22 > #define REG_CTRL_PORT_RESET BIT(25) > #define REG_CTRL_THREAD_ID_MASK GENMASK(31, 26) > > @@ -170,10 +169,10 @@ static int phy_meson8b_usb2_power_on(struct phy *phy) > REG_CONFIG_CLK_32k_ALTSEL); > > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_REF_CLK_SEL_MASK, > - 0x2 << REG_CTRL_REF_CLK_SEL_SHIFT); > + FIELD_PREP(REG_CTRL_REF_CLK_SEL_MASK, 0x2)); > > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_FSEL_MASK, > - 0x5 << REG_CTRL_FSEL_SHIFT); > + FIELD_PREP(REG_CTRL_FSEL_MASK, 0x5)); > > /* reset the PHY */ > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, Reviewed-by: Neil Armstrong