From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: hide unused nvmem_find_cell_by_index function
Date: Wed, 3 Oct 2018 09:30:11 +0100 [thread overview]
Message-ID: <e212aa6a-e3d3-8d58-fdf4-7d22919184d1@linaro.org> (raw)
In-Reply-To: <20181002211123.2662419-1-arnd@arndb.de>
On 02/10/18 22:11, Arnd Bergmann wrote:
> nvmem_find_cell_by_index() is only called from inside an #ifdef,
> so we get a build warning without CONFIG_OF:
>
> drivers/nvmem/core.c:496:1: error: 'nvmem_find_cell_by_index' defined but not used [-Werror=unused-function]
>
> Move it into the same #ifdef as the caller to avoid the warning.
>
> Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Missing Reported-by: other than that..
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
prev parent reply other threads:[~2018-10-03 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 21:11 Arnd Bergmann
2018-10-02 21:23 ` Bartosz Golaszewski
2018-10-03 8:30 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e212aa6a-e3d3-8d58-fdf4-7d22919184d1@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®