From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754725AbdEQQkv (ORCPT ); Wed, 17 May 2017 12:40:51 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58954 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbdEQQkt (ORCPT ); Wed, 17 May 2017 12:40:49 -0400 To: LKML , Anup Patel , Vinod Koul From: Randy Dunlap Subject: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies Cc: "dmaengine@vger.kernel.org" Message-ID: Date: Wed, 17 May 2017 09:40:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not enabled (seen on x86_64). drivers/built-in.o: In function `sba_prep_dma_pq_req': (.text+0x16132): undefined reference to `raid6_gflog' drivers/built-in.o: In function `sba_prep_dma_pq_single_req': (.text+0x162f4): undefined reference to `raid6_gflog' This driver needs RAID6_PQ and MAILBOX (from inspection) independent of ARM64 or COMPILE_TEST. However, RAID6_PQ is not defined in any Kconfig file, although it is used in several of them. :( Signed-off-by: Randy Dunlap Cc: Anup Patel Cc: Vinod Koul Cc: dmaengine@vger.kernel.org --- drivers/dma/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-next-20170517.orig/drivers/dma/Kconfig +++ linux-next-20170517/drivers/dma/Kconfig @@ -101,7 +101,8 @@ config AXI_DMAC config BCM_SBA_RAID tristate "Broadcom SBA RAID engine support" - depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST + depends on ARM64 || COMPILE_TEST + depends on MAILBOX && RAID6_PQ select DMA_ENGINE select DMA_ENGINE_RAID select ASYNC_TX_DISABLE_XOR_VAL_DMA