Re: [PATCH 1/5] bindings: Add devicetree bindings for new phyFLEX-i.MX 95 Libra RDK

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/10/2026 14:32, Benjamin Hahn wrote:
> Add devicetree bindings for new phyFLEX-i.MX 95 Libra RDK and
> phyFLEX-i.MX 95 FPSC Gamma SoM.
> 
> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>

You hit some combos for subject...


Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


A nit, subject: drop second/last, redundant "devicetree bindings for".
The "dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d5..f917ae7202e9 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1551,6 +1551,13 @@ properties:
>            - const: phytec,imx95-phycore-fpsc  # phyCORE-i.MX 95 FPSC
>            - const: fsl,imx95
>  
> +      - description: PHYTEC phyFLEX-i.MX95 FPSC-Gamma SoM based boards
> +        items:
> +          - enum:
> +            - phytec,imx95-phyflex-libra-rdk    # i.MX 95 phyFLEX Libra RDK

Never tested :/


Best regards,
Krzysztof