From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DB3C04A95 for ; Tue, 25 Oct 2022 10:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbiJYKTg (ORCPT ); Tue, 25 Oct 2022 06:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232616AbiJYKTQ (ORCPT ); Tue, 25 Oct 2022 06:19:16 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 347C0144099; Tue, 25 Oct 2022 03:14:44 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DD3355C0219; Tue, 25 Oct 2022 06:14:41 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Tue, 25 Oct 2022 06:14:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666692881; x=1666779281; bh=mbtl4BXNRq 9JJk803nUONhImAHZ6xfcC6jtFjkVSL7M=; b=TGfzSgdccEs/oOLx2bESIEPDG0 ptZDZynyxZm4KeHaXMmr3Mg413MHvhlg4BMhad3jleNuWm5QJ5+YUWIhNm9yrYfN 9tiytTDOOtRaO/7Uj/qLJo/bzvY5kQo66DZ5xOm6VhV2KZTRExlFX9OvwzJts3Rn Khd33FOrNyzfnCI/VumruxwH1e+yyrgZ4+0hU1HX8shzpWla3wyogVtMs/o77ngk S6eoj1N7d0rrWL1sh8ZbSHoRS5zfdViJByOEKZIPWBirb2y32ExlDJ13B5RnNa1j 0u1tGmVstfpFERrznLuxbHfFT0LUy5OcMbpy5ZtlUAmzZiM0m17K4apeS15g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666692881; x=1666779281; bh=mbtl4BXNRq9JJk803nUONhImAHZ6 xfcC6jtFjkVSL7M=; b=AQF1oGrCmtkaZ1hRNlsKmaUvDA0DdicPWLqVKT6EqLmW sSVJa+/B5Sz5XRxCCz95mg6ZEmlrmxqVpeGodcDXkMrG2VYqo9BBMuigSajdkC7m FTaHWu+ev55OKL+8PstOUneCLItsPBDOnhIZBrUxiGaR5025PB1UKIRQ+KaLahNI EtJdAMX13h86bmNTAKys28gsJojCGrrJ7O3aPPYbRKaB3K3olFjy/V8PEWJDvUCs I9rS37KOFdOH/9tj3kcKnUh86J7rI+4w6jkD6jkjQWAu5zSN3S1uU3pgc+08V0LW w3zCV8+0zRVOoXVPDjV1fp1dinvtIePxf6rK8qc96A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedtiedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 27918B60086; Tue, 25 Oct 2022 06:14:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20221021155000.4108406-1-arnd@kernel.org> <20221021155000.4108406-5-arnd@kernel.org> Date: Tue, 25 Oct 2022 12:14:19 +0200 From: "Arnd Bergmann" To: "Russell King" , "Arnd Bergmann" Cc: linux-arm-kernel@lists.infradead.org, "Linus Walleij" , "Lubomir Rintel" , "Rafael J . Wysocki" , "Viresh Kumar" , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 04/11] ARM: sa1100: make cpufreq driver build standalone Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2022, at 10:28, Russell King (Oracle) wrote: > On Fri, Oct 21, 2022 at 05:49:34PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Commit 59a2e613d07f ("cpufreq: sa11x0: move cpufreq driver >> to drivers/cpufreq") added an unnecessary reference to >> mach/generic.h. Just remove it again after moving the code >> into the corresponding driver. > > So how does arch/arm/mach-sa1100/clock.c get the MPLL rate with this > change? You are right, that's broken. It works for the defconfigs that enable the cpufreq driver, but it seems I need to improve my randconfig build testing to make sure I find problems like this sooner. I don't think anything depends on this patch, so I've dropped it from my series now. Thanks, Arnd