From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761340AbdEVTX0 (ORCPT ); Mon, 22 May 2017 15:23:26 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33385 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757576AbdEVTXV (ORCPT ); Mon, 22 May 2017 15:23:21 -0400 Subject: Re: [PATCH net-next 01/20] net: dsa: change scope of STP state setter To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170519210055.9366-1-vivien.didelot@savoirfairelinux.com> <20170519210055.9366-2-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Mon, 22 May 2017 12:23:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170519210055.9366-2-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2017 02:00 PM, Vivien Didelot wrote: > Instead of having multiple STP state helpers scoping a slave device > supporting both the DSA logic and the switchdev binding, provide a > single dsa_port_set_state helper scoping a DSA port, as well as its > dsa_port_set_state_now wrapper which skips the prepare phase. > > This allows us to better separate the DSA logic from the slave device > handling. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian