From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753865AbcEXBzU (ORCPT ); Mon, 23 May 2016 21:55:20 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:53018 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbcEXBzR (ORCPT ); Mon, 23 May 2016 21:55:17 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: devicetree@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <78764cc7ce9b2824a1bd0a600831f957> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v5 5/5] mmc: sdhci-of-arasan: implement enhanced strobe callback To: Doug Anderson References: <1463976789-29618-1-git-send-email-shawn.lin@rock-chips.com> <1463976853-29862-1-git-send-email-shawn.lin@rock-chips.com> Cc: shawn.lin@rock-chips.com, Ulf Hansson , Adrian Hunter , Jaehoon Chung , Michal Simek , soren.brinkmann@xilinx.com, Rob Herring , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Brian Norris , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" From: Shawn Lin Message-ID: Date: Tue, 24 May 2016 09:55:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/5/24 5:00, Doug Anderson 写道: > Shawn, > > On Sun, May 22, 2016 at 9:14 PM, Shawn Lin wrote: >> Currently sdhci-arasan 5.1 can support enhanced strobe function, >> and we now limit it just for "arasan,sdhci-5.1". Add >> mmc-hs400-enhanced-strobe in DT to enable the function if we're >> sure our controller can support it. >> >> Signed-off-by: Shawn Lin >> Acked-by: Adrian Hunter >> Reviewed-by: Doug Anderson >> --- >> >> Changes in v5: None >> Changes in v4: None > > Again, minor, but you did have changes... yes, it did. I moved all the change-log into the cover-letter but it seems better to keep them seperately for each patch. I will do it for the next version if needed. Thanks. > >> Changes in v3: None >> Changes in v2: None >> >> drivers/mmc/host/sdhci-of-arasan.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) > > I've tested this patch and it appears to work (not that I've hooked a > scope up, but since it's not doing tuning I think it would be pretty > obvious if it didn't work). > > Tested-by: Douglas Anderson > > > -- Best Regards Shawn Lin