From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbdKZSdk (ORCPT ); Sun, 26 Nov 2017 13:33:40 -0500 Received: from ale.deltatee.com ([207.54.116.67]:50714 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbdKZSdj (ORCPT ); Sun, 26 Nov 2017 13:33:39 -0500 To: Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft , Joe Perches References: <20171126054037.9743-1-logang@deltatee.com> <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> <3fc88c02-b9b6-80a3-0c41-63e0806d34aa@deltatee.com> From: Logan Gunthorpe Message-ID: Date: Sun, 26 Nov 2017 11:33:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: joe@perches.com, apw@canonical.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/17 11:17 AM, Julia Lawall wrote: > The main limitation that is likely to remain in my script is that > Coccinelle doesn't always understand ifdefs properly. So > #ifdef > printk("xxx"); > #else > printk("yyy"); > #endif > pr_cont("zzz"); > > may give a warning about the first printk. Yes, that's another clever corner case I didn't think of. My patch will have the same issue. But that's terrible style[1] and I should hope it's quite rare. > 0-day only runs on changed files and only reports on changed code, to > the best of my understanding, so I don't think it is a problem. Oh, cool. Logan [1] https://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation