From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E63347510 for ; Tue, 3 Mar 2026 06:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521037; cv=none; b=MaKDOyo4kbCJ3aa9zQ3z7gM7UbPt23H4AcrtU3d/jl7oXjfFySvATXc88IInE2s9yWgGqIhOfX9jBqAE1iEmJrbx7bZVkTqmpjLq7gM8ECV6u5HzUiXSvsVmNgEulY6qleo18Usxvp9PGjKOCLnSGu7DLcmRWmODPknKaTajcgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521037; c=relaxed/simple; bh=brmgYvldAEzJ2O8fsEmwzrbBh4ultBTeueXu8bmByKQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ctiXU75Dc2PA1ZalSxiAL+QCCFfwEjllpMlHu8sQQBlZOwkojg1gx4tg5li1nJraXeoYmXTiq97pbX1F7Q7b7SjxtQU7iAGbBiD7eWN3i9XcZo4UzSpmVqAFFVsYiZWnLRlWI85nbFKN9MEWIOUNfD+urFYPxWY416KgixHO1Kw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cFpmwWab; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cFpmwWab" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48372efa020so45478035e9.2 for ; Mon, 02 Mar 2026 22:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772521034; x=1773125834; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+UWoE6mn2375qZ/+kFXj+S+YU2oT2pZiLz3gYYgeg/c=; b=cFpmwWabk3Yww6ESHhDeYJi2bD22oPTWIhv36cwI0qbC3LM0/boXyXsa1yojvCJMMX BT0sEj+CAPryDqJlE9sZ8IpBg5cgK3Z7ahS989YrIhpkST/4T/vPIdkruCG+CpIwwuT2 LxUEOsJsN+j8OYxlrh/zIKcMpWP0Ju9rMszdPwobV393pfm/4Rtaqeq9CvZ8c12yfvfp FXI64GaowLdgEWAUzFXrhKHFEe89BY779V2U93522leikCVtf1OIiyg+2KTBhw+tGHG+ KLndZ9C8sFFHvKGeMNVQziXl/lDqU+Qox7g1etwpEKJqfhuok1FY1h3tzUJG/9cVxsHB Mk1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772521034; x=1773125834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+UWoE6mn2375qZ/+kFXj+S+YU2oT2pZiLz3gYYgeg/c=; b=ejSw7/ydcJaIdgY/okYlK6RAJPWiF8OGbDYsrFiBWQka5iKMD2AJPbD2qVEiZflnWX 4W9yFBWdeeact5EqvXG/n4aKhejvCjHTBTYscXv272qVVExen9qPbizhMBRY7X+rzVRW HCG4SiccEvJG5mQC6E8tpfI1DxW13gAsnsXokuJe3rCMNVpws3tCrheMZETZLwPRwjQb faifeDN3X8FO2qJ9IuZesoQHb00mN5RBZaCj4cq2BtdZeKVzZvnkAkinGjjtEUdXa/Fe v4wKete95O5LsI3jeo4+QHIj41XlIhY9y6iMtWOjg/3DVatjxr7wMz2IERJNWT0Ocet1 tOPQ== X-Forwarded-Encrypted: i=1; AJvYcCVH6GdL7kej1HDO5jbzt0VZxrTQ6kTlnzP6X28q5oOkpMv8coIX7ENGfLKqfL8QbgwXLoMbBIEwsVsMkHw=@vger.kernel.org X-Gm-Message-State: AOJu0YyOO6+SZDgqASad4PQ1DXcqjEkDMja815K7ErpC0NcUgSzDqW6b /dFX8Ew23T4nrggt2jGiEJEi0Rel9COVAsGW44XiIe7kSj4IJ2WbrsGwjljncSKobMU= X-Gm-Gg: ATEYQzxsIg5X0qzov5AmVTL8GT56GlCHCc5UlKA8d2p/aol3OH4GkHo3/K7x/5oWRyK J2U73LcShLdaLYWcIxZmJjT+iYEaCb7aO3j413xvgPSMvpNn+3xf0bZaz7UwvGphY4p/EQ1bq2J 4DE18LfY+tQuB2aq5A6V2KHgO4D3NQnznDwCa1L/+prZIN8jy3+aRaATD3tvqbQkn3HQKYHfu03 y9qDk1abH8tcY9NTfpbJ0JBMiuxBaEtbFt0p2BJt6LkLIAD8DX8FH4FvgCVGvLWR3wNLmJi+Ziu UbpcQYRegyyuNHur5e6iPKcX2XRnypxElpS8b01J2H4H1mDHDMK8+838e+hCMa7oxdAILTl7rOY uqXUANlWR203we6EZrLOu5uWYIqZAljOghXgqCaWeKPyQXqnzDqoaf9ZHxdanyXPh2st3vDFdvl g8N7ThC1o2i+cUSm1HgJdtURNe6jwZqE2gndS4VLDviN20uJCXTk7KwJ2M6EupYWygow== X-Received: by 2002:a05:600c:8108:b0:483:7907:ea02 with SMTP id 5b1f17b1804b1-483c9bfa9eamr271767355e9.16.1772521034082; Mon, 02 Mar 2026 22:57:14 -0800 (PST) Received: from [192.168.178.47] (aftr-82-135-83-117.dynamic.mnet-online.de. [82.135.83.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485132f202bsm16289535e9.0.2026.03.02.22.57.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 22:57:13 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 07:57:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/24] scsi-multipath: introduce basic SCSI device support To: John Garry , hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, martin.petersen@oracle.com, james.bottomley@hansenpartnership.com Cc: jmeneghi@redhat.com, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, michael.christie@oracle.com, snitzer@kernel.org, bmarzins@redhat.com, dm-devel@lists.linux.dev, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260225153627.1032500-1-john.g.garry@oracle.com> <20260225153627.1032500-3-john.g.garry@oracle.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260225153627.1032500-3-john.g.garry@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/25/26 16:36, John Garry wrote: > For a scsi_device to support multipath, introduce structure > scsi_mpath_device to hold multipath-specific details. > > Like NS structure for NVME, scsi_mpath_device holds the mpath_device > structure to device management and path selection. > > Two module params are introduced to enable multipath: > - scsi_multipath > - scsi_multipath_always > > SCSI multipath will only be available until the following conditions: > - scsi_multipath enabled and ALUA supported and unique ID available in > VPD page 83. > - scsi_multipath_always enabled and unique ID available in VPD page 83 > Why don't you merge these two options, and have scsi_multipath=on and scsi_multipath=always ? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.com +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich